diff --git a/spring-data-mongodb-cross-store/src/main/java/org/springframework/data/mongodb/crossstore/MongoChangeSetPersister.java b/spring-data-mongodb-cross-store/src/main/java/org/springframework/data/mongodb/crossstore/MongoChangeSetPersister.java index 3bb4ce601..19b071068 100644 --- a/spring-data-mongodb-cross-store/src/main/java/org/springframework/data/mongodb/crossstore/MongoChangeSetPersister.java +++ b/spring-data-mongodb-cross-store/src/main/java/org/springframework/data/mongodb/crossstore/MongoChangeSetPersister.java @@ -45,7 +45,7 @@ public class MongoChangeSetPersister implements ChangeSetPersister { private static final String ENTITY_FIELD_NAME = "_entity_field_name"; private static final String ENTITY_FIELD_CLASS = "_entity_field_class"; - protected final Logger log = LoggerFactory.getLogger(getClass()); + private static final Logger log = LoggerFactory.getLogger(getClass()); private MongoTemplate mongoTemplate; private EntityManagerFactory entityManagerFactory; diff --git a/spring-data-mongodb-log4j/src/main/java/org/springframework/data/mongodb/log4j/MongoLog4jAppender.java b/spring-data-mongodb-log4j/src/main/java/org/springframework/data/mongodb/log4j/MongoLog4jAppender.java index 0f466fd61..10883f583 100644 --- a/spring-data-mongodb-log4j/src/main/java/org/springframework/data/mongodb/log4j/MongoLog4jAppender.java +++ b/spring-data-mongodb-log4j/src/main/java/org/springframework/data/mongodb/log4j/MongoLog4jAppender.java @@ -160,7 +160,7 @@ public class MongoLog4jAppender extends AppenderSkeleton { // Copy properties into document Map props = event.getProperties(); - if (null != props && props.size() > 0) { + if (null != props && !props.isEmpty()) { BasicDBObject propsDbo = new BasicDBObject(); for (Map.Entry entry : props.entrySet()) { propsDbo.put(entry.getKey().toString(), entry.getValue().toString()); diff --git a/spring-data-mongodb-log4j/src/test/java/org/springframework/data/mongodb/log4j/MongoLog4jAppenderIntegrationTests.java b/spring-data-mongodb-log4j/src/test/java/org/springframework/data/mongodb/log4j/MongoLog4jAppenderIntegrationTests.java index 1f8c669d1..e8109d093 100644 --- a/spring-data-mongodb-log4j/src/test/java/org/springframework/data/mongodb/log4j/MongoLog4jAppenderIntegrationTests.java +++ b/spring-data-mongodb-log4j/src/test/java/org/springframework/data/mongodb/log4j/MongoLog4jAppenderIntegrationTests.java @@ -39,7 +39,7 @@ public class MongoLog4jAppenderIntegrationTests { static final String NAME = MongoLog4jAppenderIntegrationTests.class.getName(); - Logger log = Logger.getLogger(NAME); + private static final Logger log = Logger.getLogger(NAME); Mongo mongo; DB db; String collection; diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java index 870c59344..a57db5303 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java @@ -153,7 +153,7 @@ public class Aggregation { protected Aggregation(List aggregationOperations, AggregationOptions options) { Assert.notNull(aggregationOperations, "AggregationOperations must not be null!"); - Assert.isTrue(aggregationOperations.size() > 0, "At least one AggregationOperation has to be provided"); + Assert.isTrue(!aggregationOperations.isEmpty(), "At least one AggregationOperation has to be provided"); Assert.notNull(options, "AggregationOptions must not be null!"); this.operations = aggregationOperations; diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java index a5b6347cf..841a8a9b9 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java @@ -956,7 +956,7 @@ public class QueryMapper { private static boolean isPositionalParameter(String partial) { - if (partial.equals("$")) { + if ("$".equals(partial)) { return true; } diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/query/Criteria.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/query/Criteria.java index 8b9ddad87..7bea97ce9 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/query/Criteria.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/query/Criteria.java @@ -118,7 +118,7 @@ public class Criteria implements CriteriaDefinition { } private boolean lastOperatorWasNot() { - return this.criteria.size() > 0 && "$not".equals(this.criteria.keySet().toArray()[this.criteria.size() - 1]); + return !this.criteria.isEmpty() && "$not".equals(this.criteria.keySet().toArray()[this.criteria.size() - 1]); } /** diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/monitor/AbstractMonitor.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/monitor/AbstractMonitor.java index 26b23449b..c6af3ef1d 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/monitor/AbstractMonitor.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/monitor/AbstractMonitor.java @@ -32,7 +32,7 @@ import com.mongodb.MongoException; */ public abstract class AbstractMonitor { - private final Logger logger = LoggerFactory.getLogger(getClass()); + private static final Logger logger = LoggerFactory.getLogger(getClass()); protected Mongo mongo; private String username; diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/MongoQueryCreator.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/MongoQueryCreator.java index d2d355e19..a0cb9aa00 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/MongoQueryCreator.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/MongoQueryCreator.java @@ -420,7 +420,7 @@ class MongoQueryCreator extends AbstractQueryCreator { return PUNCTATION_PATTERN.matcher(source).find() ? Pattern.quote(source) : source; } - if (source.equals("*")) { + if ("*".equals(source)) { return ".*"; } diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoAdminIntegrationTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoAdminIntegrationTests.java index acd347f3f..924742ee0 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoAdminIntegrationTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoAdminIntegrationTests.java @@ -36,7 +36,7 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; @ContextConfiguration("classpath:infrastructure.xml") public class MongoAdminIntegrationTests { - private static Log logger = LogFactory.getLog(MongoAdminIntegrationTests.class); + private static final Log logger = LogFactory.getLog(MongoAdminIntegrationTests.class); @SuppressWarnings("unused") private DB testAdminDb; diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java index 49bfbb2cd..4430a0726 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java @@ -2402,10 +2402,10 @@ public class MappingMongoConverterUnitTests { return null; } - if (source.equals("foo-enum-value")) { + if ("foo-enum-value".equals(source)) { return FooBarEnum.FOO; } - if (source.equals("bar-enum-value")) { + if ("bar-enum-value".equals(source)) { return FooBarEnum.BAR; } diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/mapreduce/MapReduceTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/mapreduce/MapReduceTests.java index 5ebd4861d..d97116833 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/mapreduce/MapReduceTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/mapreduce/MapReduceTests.java @@ -118,13 +118,13 @@ public class MapReduceTests { int size = 0; for (ContentAndVersion cv : results) { - if (cv.getId().equals("Resume")) { + if ("Resume".equals(cv.getId())) { assertEquals(6, cv.getValue().longValue()); } - if (cv.getId().equals("Schema")) { + if ("Schema".equals(cv.getId())) { assertEquals(2, cv.getValue().longValue()); } - if (cv.getId().equals("mongoDB How-To")) { + if ("mongoDB How-To".equals(cv.getId())) { assertEquals(2, cv.getValue().longValue()); } size++; @@ -141,13 +141,13 @@ public class MapReduceTests { new MapReduceOptions().outputCollection("jmr2_out"), NumberAndVersion.class); int size = 0; for (NumberAndVersion nv : results) { - if (nv.getId().equals("1")) { + if ("1".equals(nv.getId())) { assertEquals(2, nv.getValue().longValue()); } - if (nv.getId().equals("2")) { + if ("2".equals(nv.getId())) { assertEquals(6, nv.getValue().longValue()); } - if (nv.getId().equals("3")) { + if ("3".equals(nv.getId())) { assertEquals(2, nv.getValue().longValue()); } size++;