From 95f6dfafddb82f6ac809aa0a9b7ee2eb8882cee9 Mon Sep 17 00:00:00 2001 From: Oliver Gierke Date: Mon, 23 Nov 2015 11:13:07 +0100 Subject: [PATCH] DATAMONGO-1287 - Optimizations in reading associations as constructor arguments. As per discussion on the ticket we now omit looking up the value for an association being used as constructor argument as the simple check whether the currently handled property is a constructor argument is sufficient to potentially skip handling the value. Related pull requests: #335, #322. --- .../data/mongodb/core/convert/MappingMongoConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java index 91be3aae8..0d1b64376 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MappingMongoConverter.java @@ -291,7 +291,7 @@ public class MappingMongoConverter extends AbstractMongoConverter implements App final MongoPersistentProperty property = association.getInverse(); Object value = dbo.get(property.getFieldName()); - if (value == null || (entity.isConstructorArgument(property) && accessor.getProperty(property) != null)) { + if (value == null || entity.isConstructorArgument(property)) { return; }