diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java index ea831b611..2b0a45b46 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/Aggregation.java @@ -305,11 +305,22 @@ public class Aggregation { * * @param elementsToSkip must not be less than zero. * @return + * @deprecated prepare to get this one removed in favor of {@link #skip(long)}. */ public static SkipOperation skip(int elementsToSkip) { return new SkipOperation(elementsToSkip); } + /** + * Creates a new {@link SkipOperation} skipping the given number of elements. + * + * @param elementsToSkip must not be less than zero. + * @return + */ + public static SkipOperation skip(long elementsToSkip) { + return new SkipOperation(elementsToSkip); + } + /** * Creates a new {@link LimitOperation} limiting the result to the given number of elements. * diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/SkipOperation.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/SkipOperation.java index 67d598134..8d87538e8 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/SkipOperation.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/aggregation/SkipOperation.java @@ -1,5 +1,5 @@ /* - * Copyright 2013-2015 the original author or authors. + * Copyright 2013-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -38,7 +38,7 @@ public class SkipOperation implements AggregationOperation { /** * Creates a new {@link SkipOperation} skipping the given number of elements. * - * @param skipCount number of documents to skip. + * @param skipCount number of documents to skip, must not be less than zero. */ public SkipOperation(long skipCount) { diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/aggregation/AggregationTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/aggregation/AggregationTests.java index 9acc01001..6a4b8ae81 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/aggregation/AggregationTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/aggregation/AggregationTests.java @@ -1476,7 +1476,7 @@ public class AggregationTests { newAggregation(match(new Criteria()), // group("field1").count().as("totalCount"), // out("collection1"), // - skip(100)); + skip(100L)); } /**