From 456ae2459f6af8dfa69493f60f24ec2c47670e5f Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Wed, 1 Mar 2017 15:47:38 +0100 Subject: [PATCH] DATAMONGO-1605 - Polishing. Remove additional quoting around JSON serialization because JSON serialization adds quotes to a string. Reformat code. --- .../repository/query/ExpressionEvaluatingParameterBinder.java | 4 ---- .../repository/query/StringBasedMongoQueryUnitTests.java | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ExpressionEvaluatingParameterBinder.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ExpressionEvaluatingParameterBinder.java index 764c56916..82df6f3a3 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ExpressionEvaluatingParameterBinder.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/ExpressionEvaluatingParameterBinder.java @@ -219,10 +219,6 @@ class ExpressionEvaluatingParameterBinder { return base64representation; } - if (binding.isExpression() && value instanceof String) { - return "\"" + JSON.serialize(value) + "\""; - } - return JSON.serialize(value); } diff --git a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQueryUnitTests.java b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQueryUnitTests.java index 91367378f..15ac53445 100644 --- a/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQueryUnitTests.java +++ b/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQueryUnitTests.java @@ -519,7 +519,7 @@ public class StringBasedMongoQueryUnitTests { public void findUsingSpelShouldRetainNullValues() throws Exception { StringBasedMongoQuery mongoQuery = createQueryForMethod("findByUsingSpel", Object.class); - ConvertingParameterAccessor accessor = StubParameterAccessor.getAccessor(converter, new Object[]{null}); + ConvertingParameterAccessor accessor = StubParameterAccessor.getAccessor(converter, new Object[] { null }); org.springframework.data.mongodb.core.query.Query query = mongoQuery.createQuery(accessor); assertThat(query.getQueryObject(), is(new Document("arg0", null)));