From 2026097be84df8b4867965abbe3e5e0691ee6fe7 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Tue, 23 Aug 2016 14:59:43 +0200 Subject: [PATCH] DATAMONGO-1465 - Polishing. Replace boolean flag in convertAndJoinScriptArgs with literal. Joined args are rendered to JavaScript and require always string quotation. Original pull request: #383. --- .../data/mongodb/core/DefaultScriptOperations.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultScriptOperations.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultScriptOperations.java index 2269473a0..78de5e738 100644 --- a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultScriptOperations.java +++ b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultScriptOperations.java @@ -116,7 +116,7 @@ class DefaultScriptOperations implements ScriptOperations { @Override public Object doInDB(DB db) throws MongoException, DataAccessException { - return db.eval(String.format("%s(%s)", scriptName, convertAndJoinScriptArgs(true, args))); + return db.eval(String.format("%s(%s)", scriptName, convertAndJoinScriptArgs(args))); } }); } @@ -171,8 +171,8 @@ class DefaultScriptOperations implements ScriptOperations { return convertedValues.toArray(); } - private String convertAndJoinScriptArgs(boolean quote, Object... args) { - return ObjectUtils.isEmpty(args) ? "" : StringUtils.arrayToCommaDelimitedString(convertScriptArgs(quote, args)); + private String convertAndJoinScriptArgs(Object... args) { + return ObjectUtils.isEmpty(args) ? "" : StringUtils.arrayToCommaDelimitedString(convertScriptArgs(true, args)); } /**