diff --git a/spring-data-envers/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java b/spring-data-envers/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java index 2f3e29861..25abac67e 100755 --- a/spring-data-envers/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java +++ b/spring-data-envers/src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java @@ -172,7 +172,7 @@ public class EnversRevisionRepositoryImpl orderMapped = (pageable.getSort()instanceof RevisionSort revisionSort) + List orderMapped = (pageable.getSort() instanceof RevisionSort revisionSort) ? List.of(mapRevisionSort(revisionSort)) : mapPropertySort(pageable.getSort()); diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaMetamodelMappingContext.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaMetamodelMappingContext.java index 6335aec76..ee663c687 100644 --- a/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaMetamodelMappingContext.java +++ b/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaMetamodelMappingContext.java @@ -54,7 +54,6 @@ public class JpaMetamodelMappingContext */ public JpaMetamodelMappingContext(Set models) { - Assert.notNull(models, "JPA metamodel must not be null"); Assert.notEmpty(models, "JPA metamodel must not be empty"); this.models = new Metamodels(models); diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentEntityImpl.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentEntityImpl.java index cd6c1a00f..fa8eebd38 100644 --- a/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentEntityImpl.java +++ b/spring-data-jpa/src/main/java/org/springframework/data/jpa/mapping/JpaPersistentEntityImpl.java @@ -58,7 +58,6 @@ class JpaPersistentEntityImpl extends BasicPersistentEntity ALL = List.of(HIBERNATE, ECLIPSELINK, GENERIC_JPA); - static ConcurrentReferenceHashMap, PersistenceProvider> CACHE = new ConcurrentReferenceHashMap<>(); + private static final ConcurrentReferenceHashMap, PersistenceProvider> CACHE = new ConcurrentReferenceHashMap<>(); private final Iterable entityManagerClassNames; private final Iterable metamodelClassNames; diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JSqlParserQueryEnhancer.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JSqlParserQueryEnhancer.java index c377d666c..5a9950371 100644 --- a/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JSqlParserQueryEnhancer.java +++ b/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JSqlParserQueryEnhancer.java @@ -120,7 +120,7 @@ public class JSqlParserQueryEnhancer implements QueryEnhancer { Select selectStatement = parseSelectStatement(queryString); - if (selectStatement.getSelectBody()instanceof SetOperationList setOperationList) { + if (selectStatement.getSelectBody() instanceof SetOperationList setOperationList) { return applySortingToSetOperationList(setOperationList, sort); } else if (!(selectStatement.getSelectBody() instanceof PlainSelect)) { return queryString; @@ -221,7 +221,7 @@ public class JSqlParserQueryEnhancer implements QueryEnhancer { } Select selectStatement = (Select) statement; - if (selectStatement.getSelectBody()instanceof PlainSelect selectBody) { + if (selectStatement.getSelectBody() instanceof PlainSelect selectBody) { return getJoinAliases(selectBody); } @@ -319,7 +319,7 @@ public class JSqlParserQueryEnhancer implements QueryEnhancer { * ValuesStatement has no alias * SetOperation can have multiple alias for each operation item */ - if (!(selectStatement.getSelectBody()instanceof PlainSelect selectBody)) { + if (!(selectStatement.getSelectBody() instanceof PlainSelect selectBody)) { return null; } @@ -374,7 +374,7 @@ public class JSqlParserQueryEnhancer implements QueryEnhancer { /* We only support count queries for {@link PlainSelect}. */ - if (!(selectStatement.getSelectBody()instanceof PlainSelect selectBody)) { + if (!(selectStatement.getSelectBody() instanceof PlainSelect selectBody)) { return this.query.getQueryString(); } @@ -441,7 +441,7 @@ public class JSqlParserQueryEnhancer implements QueryEnhancer { SelectBody selectBody = selectStatement.getSelectBody(); - if (selectStatement.getSelectBody()instanceof SetOperationList setOperationList) { + if (selectStatement.getSelectBody() instanceof SetOperationList setOperationList) { // using the first one since for setoperations the projection has to be the same selectBody = setOperationList.getSelects().get(0); diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetterFactory.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetterFactory.java index 9e2718458..696ac6653 100644 --- a/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetterFactory.java +++ b/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetterFactory.java @@ -186,7 +186,7 @@ abstract class QueryParameterSetterFactory { @Override public QueryParameterSetter create(ParameterBinding binding, DeclaredQuery declaredQuery) { - if (!(binding.getOrigin()instanceof ParameterBinding.Expression e)) { + if (!(binding.getOrigin() instanceof ParameterBinding.Expression e)) { return null; } @@ -239,7 +239,7 @@ abstract class QueryParameterSetterFactory { Assert.notNull(binding, "Binding must not be null"); JpaParameter parameter; - if (!(binding.getOrigin()instanceof MethodInvocationArgument mia)) { + if (!(binding.getOrigin() instanceof MethodInvocationArgument mia)) { return QueryParameterSetter.NOOP; } diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/util/JpaMetamodelCacheCleanup.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/util/JpaMetamodelCacheCleanup.java index ed83f5d18..df17d56ad 100644 --- a/spring-data-jpa/src/main/java/org/springframework/data/jpa/util/JpaMetamodelCacheCleanup.java +++ b/spring-data-jpa/src/main/java/org/springframework/data/jpa/util/JpaMetamodelCacheCleanup.java @@ -30,7 +30,7 @@ import org.springframework.context.ApplicationContext; class JpaMetamodelCacheCleanup implements DisposableBean { @Override - public void destroy() throws Exception { + public void destroy() { JpaMetamodel.clear(); } } diff --git a/spring-data-jpa/src/test/java/org/springframework/data/jpa/provider/PersistenceProviderUnitTests.java b/spring-data-jpa/src/test/java/org/springframework/data/jpa/provider/PersistenceProviderUnitTests.java index 2e4ce22ca..bcb9582bc 100644 --- a/spring-data-jpa/src/test/java/org/springframework/data/jpa/provider/PersistenceProviderUnitTests.java +++ b/spring-data-jpa/src/test/java/org/springframework/data/jpa/provider/PersistenceProviderUnitTests.java @@ -22,6 +22,7 @@ import static org.springframework.data.jpa.provider.PersistenceProvider.Constant import jakarta.persistence.EntityManager; import java.util.Arrays; +import java.util.Map; import org.assertj.core.api.Assumptions; import org.hibernate.Version; @@ -32,6 +33,7 @@ import org.mockito.Mockito; import org.springframework.asm.ClassWriter; import org.springframework.asm.Opcodes; import org.springframework.instrument.classloading.ShadowingClassLoader; +import org.springframework.test.util.ReflectionTestUtils; import org.springframework.util.ClassUtils; /** @@ -48,7 +50,8 @@ class PersistenceProviderUnitTests { @BeforeEach void setup() { - PersistenceProvider.CACHE.clear(); + Map cache = (Map) ReflectionTestUtils.getField(PersistenceProvider.class, "CACHE"); + cache.clear(); this.shadowingClassLoader = new ShadowingClassLoader(getClass().getClassLoader()); }