From a6a4ea00a74f2d404868fbe865ac1611559c3264 Mon Sep 17 00:00:00 2001 From: Jens Schauder Date: Tue, 6 Jan 2026 09:51:10 +0100 Subject: [PATCH] Fix wrong Optional.of usage Original pull request #4132 See #4131 --- .../data/jpa/repository/support/SimpleJpaRepository.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java index 17d25a923..2e3171aa6 100644 --- a/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java +++ b/spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java @@ -333,13 +333,13 @@ public class SimpleJpaRepository implements JpaRepositoryImplementation domainType = getDomainClass(); if (metadata == null) { - return Optional.of(entityManager.find(domainType, id)); + return Optional.ofNullable(entityManager.find(domainType, id)); } LockModeType type = metadata.getLockModeType(); Map hints = getHints(); - return Optional.of( + return Optional.ofNullable( type == null ? entityManager.find(domainType, id, hints) : entityManager.find(domainType, id, type, hints)); } @@ -457,7 +457,7 @@ public class SimpleJpaRepository implements JpaRepositoryImplementation findOne(Specification spec) { - return Optional.of(getQuery(spec, Sort.unsorted()).setMaxResults(2).getSingleResultOrNull()); + return Optional.ofNullable(getQuery(spec, Sort.unsorted()).setMaxResults(2).getSingleResultOrNull()); } @Override