@ -70,33 +70,35 @@ class QueryMethodUnitTests {
@@ -70,33 +70,35 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "pagingMethodWithInvalidReturnType" , Pageable . class ) ;
assertThatIllegalStateException ( ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatIllegalStateException ( )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // DATAJPA-59
void rejectsPagingMethodWithoutPageable ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "pagingMethodWithoutPageable" ) ;
assertThatIllegalArgumentException ( ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatIllegalArgumentException ( )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // DATACMNS-64
void setsUpSimpleQueryMethodCorrectly ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "findByUsername" , String . class ) ;
new QueryMethod ( method , metadata , factory ) ;
new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
}
@Test // DATACMNS-61
void considersIterableMethodForCollectionQuery ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "sampleMethod" ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isCollectionQuery ( ) ) . isTrue ( ) ;
}
@Test // DATACMNS-67
void doesNotConsiderPageMethodCollectionQuery ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "anotherSampleMethod" , Pageable . class ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isPageQuery ( ) ) . isTrue ( ) ;
assertThat ( queryMethod . isCollectionQuery ( ) ) . isFalse ( ) ;
}
@ -104,7 +106,7 @@ class QueryMethodUnitTests {
@@ -104,7 +106,7 @@ class QueryMethodUnitTests {
@Test // GH-2151
void supportsImperativecursorQueries ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "cursorWindow" , ScrollPosition . class ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isPageQuery ( ) ) . isFalse ( ) ;
assertThat ( queryMethod . isScrollQuery ( ) ) . isTrue ( ) ;
@ -114,7 +116,7 @@ class QueryMethodUnitTests {
@@ -114,7 +116,7 @@ class QueryMethodUnitTests {
@Test // GH-2151
void supportsReactiveCursorQueries ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "reactiveCursorWindow" , ScrollPosition . class ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isPageQuery ( ) ) . isFalse ( ) ;
assertThat ( queryMethod . isScrollQuery ( ) ) . isTrue ( ) ;
@ -125,14 +127,16 @@ class QueryMethodUnitTests {
@@ -125,14 +127,16 @@ class QueryMethodUnitTests {
void rejectsInvalidReactiveCursorQueries ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "invalidReactiveCursorWindow" , ScrollPosition . class ) ;
assertThatIllegalStateException ( ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatIllegalStateException ( )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // GH-2151
void rejectsCursorWindowMethodWithoutPageable ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "cursorWindowWithoutScrollPosition" ) ;
assertThatIllegalArgumentException ( ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatIllegalArgumentException ( )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // GH-2151
@ -140,14 +144,15 @@ class QueryMethodUnitTests {
@@ -140,14 +144,15 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "cursorWindowMethodWithInvalidReturnType" , ScrollPosition . class ) ;
assertThatIllegalStateException ( ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatIllegalStateException ( )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // DATACMNS-171
void detectsAnEntityBeingReturned ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "returnsEntitySubclass" ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isQueryForEntity ( ) ) . isTrue ( ) ;
}
@ -156,7 +161,7 @@ class QueryMethodUnitTests {
@@ -156,7 +161,7 @@ class QueryMethodUnitTests {
void detectsNonEntityBeingReturned ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "returnsProjection" ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isQueryForEntity ( ) ) . isFalse ( ) ;
}
@ -166,7 +171,7 @@ class QueryMethodUnitTests {
@@ -166,7 +171,7 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "sliceOfUsers" ) ;
var queryMethod = new QueryMethod ( method , repositoryMetadata , factory ) ;
var queryMethod = new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isSliceQuery ( ) ) . isTrue ( ) ;
assertThat ( queryMethod . isCollectionQuery ( ) ) . isFalse ( ) ;
@ -179,7 +184,8 @@ class QueryMethodUnitTests {
@@ -179,7 +184,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "arrayOfUsers" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isTrue ( ) ;
}
@Test // DATACMNS-650
@ -188,7 +194,7 @@ class QueryMethodUnitTests {
@@ -188,7 +194,7 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "streaming" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isStreamQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isStreamQuery ( ) ) . isTrue ( ) ;
}
@Test // DATACMNS-650
@ -197,7 +203,7 @@ class QueryMethodUnitTests {
@@ -197,7 +203,7 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "streaming" , Pageable . class ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isStreamQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isStreamQuery ( ) ) . isTrue ( ) ;
}
@Test // DATACMNS-716
@ -206,7 +212,8 @@ class QueryMethodUnitTests {
@@ -206,7 +212,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsCompletableFutureForSingleEntity" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isFalse ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isFalse ( ) ;
}
@Test // DATACMNS-716
@ -215,7 +222,8 @@ class QueryMethodUnitTests {
@@ -215,7 +222,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsCompletableFutureForEntityCollection" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isTrue ( ) ;
}
@Test // DATACMNS-716
@ -224,7 +232,8 @@ class QueryMethodUnitTests {
@@ -224,7 +232,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsFutureForSingleEntity" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isFalse ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isFalse ( ) ;
}
@Test // DATACMNS-716
@ -233,7 +242,8 @@ class QueryMethodUnitTests {
@@ -233,7 +242,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsFutureForEntityCollection" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isTrue ( ) ;
}
/ * *
@ -245,7 +255,8 @@ class QueryMethodUnitTests {
@@ -245,7 +255,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsSeq" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isTrue ( ) ;
}
/ * *
@ -257,7 +268,8 @@ class QueryMethodUnitTests {
@@ -257,7 +268,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsFutureOfSeq" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isTrue ( ) ;
}
/ * *
@ -269,7 +281,8 @@ class QueryMethodUnitTests {
@@ -269,7 +281,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsFutureOfOption" ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isFalse ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isFalse ( ) ;
}
@Test // DATACMNS-1005
@ -278,7 +291,8 @@ class QueryMethodUnitTests {
@@ -278,7 +291,8 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "returnsSeq" , Pageable . class ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory ) . isCollectionQuery ( ) ) . isTrue ( ) ;
assertThat ( new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) )
. isTrue ( ) ;
}
@Test // DATACMNS-1300
@ -287,7 +301,7 @@ class QueryMethodUnitTests {
@@ -287,7 +301,7 @@ class QueryMethodUnitTests {
var metadata = AbstractRepositoryMetadata . getMetadata ( ContainerRepository . class ) ;
var method = ContainerRepository . class . getMethod ( "someMethod" ) ;
assertThat ( new QueryMethod ( method , metadata , factory ) . isCollectionQuery ( ) ) . isFalse ( ) ;
assertThat ( new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) . isCollectionQuery ( ) ) . isFalse ( ) ;
}
@Test // DATACMNS-1762
@ -296,7 +310,7 @@ class QueryMethodUnitTests {
@@ -296,7 +310,7 @@ class QueryMethodUnitTests {
RepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata ( SampleRepository . class ) ;
var method = SampleRepository . class . getMethod ( "reactiveSlice" ) ;
var queryMethod = new QueryMethod ( method , repositoryMetadata , factory ) ;
var queryMethod = new QueryMethod ( method , repositoryMetadata , factory , DefaultParameters : : new ) ;
var returnedType = queryMethod . getResultProcessor ( ) . getReturnedType ( ) ;
assertThat ( queryMethod . isSliceQuery ( ) ) . isTrue ( ) ;
assertThat ( returnedType . getTypeToRead ( ) ) . isEqualTo ( User . class ) ;
@ -307,7 +321,7 @@ class QueryMethodUnitTests {
@@ -307,7 +321,7 @@ class QueryMethodUnitTests {
void considersEclipseCollectionCollectionQuery ( ) throws Exception {
var method = SampleRepository . class . getMethod ( "returnsEclipseCollection" ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isCollectionQuery ( ) ) . isTrue ( ) ;
}
@ -317,7 +331,8 @@ class QueryMethodUnitTests {
@@ -317,7 +331,8 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "pageableAndSort" , Pageable . class , Sort . class ) ;
assertThatExceptionOfType ( IllegalStateException . class ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatExceptionOfType ( IllegalStateException . class )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // GH-2827
@ -325,7 +340,8 @@ class QueryMethodUnitTests {
@@ -325,7 +340,8 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "pageableAndLimit" , Pageable . class , Limit . class ) ;
assertThatExceptionOfType ( IllegalStateException . class ) . isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory ) ) ;
assertThatExceptionOfType ( IllegalStateException . class )
. isThrownBy ( ( ) - > new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ) ;
}
@Test // GH-2827
@ -333,7 +349,7 @@ class QueryMethodUnitTests {
@@ -333,7 +349,7 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "sortAndLimit" , Sort . class , Limit . class ) ;
new QueryMethod ( method , metadata , factory ) ;
new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
}
@Test // GH-2827
@ -341,7 +357,7 @@ class QueryMethodUnitTests {
@@ -341,7 +357,7 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "scrollPositionAndLimit" , ScrollPosition . class , Limit . class ) ;
new QueryMethod ( method , metadata , factory ) ;
new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
}
@Test // GH-2827
@ -349,7 +365,7 @@ class QueryMethodUnitTests {
@@ -349,7 +365,7 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "findTop5By" , Limit . class ) ;
new QueryMethod ( method , metadata , factory ) ;
new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
}
@Test // GH-2827
@ -357,7 +373,7 @@ class QueryMethodUnitTests {
@@ -357,7 +373,7 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "findTop5By" , Pageable . class ) ;
new QueryMethod ( method , metadata , factory ) ;
new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
}
@Test // GH-2827
@ -365,7 +381,7 @@ class QueryMethodUnitTests {
@@ -365,7 +381,7 @@ class QueryMethodUnitTests {
var method = SampleRepository . class . getMethod ( "scrollPositionAndSort" , ScrollPosition . class , Sort . class ) ;
new QueryMethod ( method , metadata , factory ) ;
new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
}
@TestFactory // GH-2869
@ -373,10 +389,7 @@ class QueryMethodUnitTests {
@@ -373,10 +389,7 @@ class QueryMethodUnitTests {
throws Exception {
var metadata = AbstractRepositoryMetadata . getMetadata ( StreamableAggregateRepository . class ) ;
var stream = Stream . of (
Map . entry ( "findBy" , false ) ,
Map . entry ( "findSubTypeBy" , false ) ,
Map . entry ( "findAllBy" , true ) ,
var stream = Stream . of ( Map . entry ( "findBy" , false ) , Map . entry ( "findSubTypeBy" , false ) , Map . entry ( "findAllBy" , true ) ,
Map . entry ( "findOptionalBy" , false ) ) ;
return DynamicTest . stream ( stream , //
@ -384,7 +397,7 @@ class QueryMethodUnitTests {
@@ -384,7 +397,7 @@ class QueryMethodUnitTests {
it - > {
var method = StreamableAggregateRepository . class . getMethod ( it . getKey ( ) ) ;
var queryMethod = new QueryMethod ( method , metadata , factory ) ;
var queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isCollectionQuery ( ) ) . isEqualTo ( it . getValue ( ) ) ;
} ) ;
@ -394,7 +407,7 @@ class QueryMethodUnitTests {
@@ -394,7 +407,7 @@ class QueryMethodUnitTests {
void considersSearchResults ( ) throws NoSuchMethodException {
var method = SampleRepository . class . getMethod ( "searchTop5By" ) ;
QueryMethod queryMethod = new QueryMethod ( method , metadata , factory ) ;
QueryMethod queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isSearchQuery ( ) ) . isTrue ( ) ;
}
@ -403,7 +416,7 @@ class QueryMethodUnitTests {
@@ -403,7 +416,7 @@ class QueryMethodUnitTests {
void considersSearchResult ( ) throws NoSuchMethodException {
var method = SampleRepository . class . getMethod ( "searchListTop5By" ) ;
QueryMethod queryMethod = new QueryMethod ( method , metadata , factory ) ;
QueryMethod queryMethod = new QueryMethod ( method , metadata , factory , DefaultParameters : : new ) ;
assertThat ( queryMethod . isSearchQuery ( ) ) . isTrue ( ) ;
}