Browse Source

DATACMNS-634 - Repositories now als returns repositories for super types of a domain class.

In case the repository lookup for a given domain type fails we traverse the given types super-types and try to detect a repository for those.

Original pull request: #110.
pull/112/head
Thomas Eizinger 11 years ago committed by Oliver Gierke
parent
commit
9f21cc2f28
  1. 15
      src/main/java/org/springframework/data/repository/support/Repositories.java
  2. 12
      src/test/java/org/springframework/data/repository/support/RepositoriesUnitTests.java

15
src/main/java/org/springframework/data/repository/support/Repositories.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2012-2014 the original author or authors.
* Copyright 2012-2015 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -39,6 +39,7 @@ import org.springframework.util.ClassUtils; @@ -39,6 +39,7 @@ import org.springframework.util.ClassUtils;
*
* @author Oliver Gierke
* @author Thomas Darimont
* @author Thomas Eizinger
*/
public class Repositories implements Iterable<Class<?>> {
@ -133,11 +134,19 @@ public class Repositories implements Iterable<Class<?>> { @@ -133,11 +134,19 @@ public class Repositories implements Iterable<Class<?>> {
Assert.notNull(domainClass, DOMAIN_TYPE_MUST_NOT_BE_NULL);
RepositoryFactoryInformation<Object, Serializable> repositoryInfo = repositoryFactoryInfos.get(ClassUtils
.getUserClass(domainClass));
Class<?> classToInspect = domainClass;
RepositoryFactoryInformation<Object, Serializable> repositoryInfo = repositoryFactoryInfos
.get(ClassUtils.getUserClass(classToInspect));
while (repositoryInfo == null && !classToInspect.equals(Object.class)) {
classToInspect = classToInspect.getSuperclass();
repositoryInfo = repositoryFactoryInfos.get(ClassUtils.getUserClass(classToInspect));
}
return repositoryInfo == null ? EMPTY_REPOSITORY_FACTORY_INFO : repositoryInfo;
}
/**
* Returns the {@link EntityInformation} for the given domain class.
*

12
src/test/java/org/springframework/data/repository/support/RepositoriesUnitTests.java

@ -108,10 +108,22 @@ public class RepositoriesUnitTests { @@ -108,10 +108,22 @@ public class RepositoriesUnitTests {
assertThat(repositories.getPersistentEntity(Address.class), is(notNullValue()));
}
/**
* @see DATACMNS-634
*/
@Test
public void findsRepositoryForSubTypes() {
Repositories repositories = new Repositories(context);
assertThat(repositories.getPersistentEntity(AdvancedAddress.class), is(notNullValue()));
}
class Person {}
class Address {}
class AdvancedAddress extends Address {}
interface PersonRepository extends CrudRepository<Person, Long> {}
interface AddressRepository extends Repository<Address, Long> {}

Loading…
Cancel
Save