Browse Source

DATACMNS-1122 - Improve message for absent required property in PersistentEntity.getRequiredPersistentProperty(…).

Exception message now contains the property name.
pull/229/merge
Mark Paluch 9 years ago
parent
commit
86945f81d1
  1. 2
      src/main/java/org/springframework/data/mapping/PersistentEntity.java
  2. 10
      src/test/java/org/springframework/data/mapping/model/BasicPersistentEntityUnitTests.java

2
src/main/java/org/springframework/data/mapping/PersistentEntity.java

@ -151,7 +151,7 @@ public interface PersistentEntity<T, P extends PersistentProperty<P>> extends It @@ -151,7 +151,7 @@ public interface PersistentEntity<T, P extends PersistentProperty<P>> extends It
return property;
}
throw new IllegalStateException(String.format("Required identifier property not found for %s!", getType()));
throw new IllegalStateException(String.format("Required property %s not found for %s!", name, getType()));
}
/**

10
src/test/java/org/springframework/data/mapping/model/BasicPersistentEntityUnitTests.java

@ -165,6 +165,16 @@ public class BasicPersistentEntityUnitTests<T extends PersistentProperty<T>> { @@ -165,6 +165,16 @@ public class BasicPersistentEntityUnitTests<T extends PersistentProperty<T>> {
assertThat(entity.getPersistentProperty(CreatedDate.class)).isNull();
}
@Test // DATACMNS-1122
public void reportsRequiredPropertyName() {
SampleMappingContext context = new SampleMappingContext();
PersistentEntity<Object, SamplePersistentProperty> entity = context.getRequiredPersistentEntity(Entity.class);
assertThatThrownBy(() -> entity.getRequiredPersistentProperty("foo"))
.hasMessageContaining("Required property foo not found");
}
@Test // DATACMNS-596
public void returnsBeanWrapperForPropertyAccessor() {

Loading…
Cancel
Save