From 7ceb7614575bbfab1860c73b3fa78a42d40a53de Mon Sep 17 00:00:00 2001
From: Oliver Gierke <ogierke@pivotal.io>
Date: Thu, 24 Nov 2016 17:21:11 +0100
Subject: [PATCH] DATACMNS-943 - We prefer direct matches on repository query
 method overloads.

We now try to look up a target class method based on concrete name and parameter type before falling back on the more expensive type matches. This also eliminates the possibility of invalid method matches as described in the ticket.
---
 .../support/DefaultRepositoryInformation.java |  6 +++++
 ...DefaultRepositoryInformationUnitTests.java | 23 ++++++++++++++++++-
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/springframework/data/repository/core/support/DefaultRepositoryInformation.java b/src/main/java/org/springframework/data/repository/core/support/DefaultRepositoryInformation.java
index 93bb39914..69f4a12b1 100644
--- a/src/main/java/org/springframework/data/repository/core/support/DefaultRepositoryInformation.java
+++ b/src/main/java/org/springframework/data/repository/core/support/DefaultRepositoryInformation.java
@@ -243,6 +243,12 @@ class DefaultRepositoryInformation implements RepositoryInformation {
 			return method;
 		}
 
+		Method result = findMethod(baseClass, method.getName(), method.getParameterTypes());
+
+		if (result != null) {
+			return result;
+		}
+
 		for (Method baseClassMethod : baseClass.getMethods()) {
 
 			// Wrong name
diff --git a/src/test/java/org/springframework/data/repository/core/support/DefaultRepositoryInformationUnitTests.java b/src/test/java/org/springframework/data/repository/core/support/DefaultRepositoryInformationUnitTests.java
index 875d65475..c39beee9b 100644
--- a/src/test/java/org/springframework/data/repository/core/support/DefaultRepositoryInformationUnitTests.java
+++ b/src/test/java/org/springframework/data/repository/core/support/DefaultRepositoryInformationUnitTests.java
@@ -254,6 +254,21 @@ public class DefaultRepositoryInformationUnitTests {
 		assertThat(information.isCustomMethod(customBaseRepositoryMethod), is(true));
 	}
 
+	/**
+	 * @see DATACMNS-943
+	 * @throws Exception
+	 */
+	@Test
+	public void usesCorrectSaveOverload() throws Exception {
+
+		RepositoryMetadata metadata = new DefaultRepositoryMetadata(DummyRepository.class);
+		RepositoryInformation information = new DefaultRepositoryInformation(metadata, CrudRepository.class, null);
+
+		Method method = DummyRepository.class.getMethod("save", Iterable.class);
+
+		assertThat(information.getTargetClassMethod(method), is(CrudRepository.class.getMethod("save", Iterable.class)));
+	}
+
 	private static Method getMethodFrom(Class<?> type, String name) {
 
 		for (Method method : type.getMethods()) {
@@ -303,7 +318,7 @@ public class DefaultRepositoryInformationUnitTests {
 
 		@Override
 		public Iterator<User> iterator() {
-			return Collections.<User>emptySet().iterator();
+			return Collections.<User> emptySet().iterator();
 		}
 	}
 
@@ -366,4 +381,10 @@ public class DefaultRepositoryInformationUnitTests {
 	}
 
 	static class Sample {}
+
+	interface DummyRepository extends CrudRepository<User, Integer> {
+
+		@Override
+		<S extends User> List<S> save(Iterable<S> entites);
+	}
 }