diff --git a/src/main/java/org/springframework/data/util/TypeDiscoverer.java b/src/main/java/org/springframework/data/util/TypeDiscoverer.java index 97ab4319e..6ce897ac4 100644 --- a/src/main/java/org/springframework/data/util/TypeDiscoverer.java +++ b/src/main/java/org/springframework/data/util/TypeDiscoverer.java @@ -177,7 +177,7 @@ class TypeDiscoverer implements TypeInformation { Assert.notNull(constructor, "Constructor must not be null!"); List> parameterTypes = new ArrayList<>(constructor.getParameterCount()); - for(Parameter parameter : constructor.getParameters()) { + for (Parameter parameter : constructor.getParameters()) { parameterTypes.add(createInfo(parameter.getParameterizedType())); } return parameterTypes; diff --git a/src/test/java/org/springframework/data/mapping/PreferredConstructorDiscovererUnitTests.java b/src/test/java/org/springframework/data/mapping/PreferredConstructorDiscovererUnitTests.java index 29349cb2d..031f91604 100755 --- a/src/test/java/org/springframework/data/mapping/PreferredConstructorDiscovererUnitTests.java +++ b/src/test/java/org/springframework/data/mapping/PreferredConstructorDiscovererUnitTests.java @@ -35,10 +35,10 @@ import org.springframework.data.util.ClassTypeInformation; * @author Mark Paluch * @author Christoph Strobl */ -public class PreferredConstructorDiscovererUnitTests

> { +class PreferredConstructorDiscovererUnitTests

> { @Test // DATACMNS-1126 - public void findsNoArgConstructorForClassWithoutExplicitConstructor() { + void findsNoArgConstructorForClassWithoutExplicitConstructor() { assertThat(PreferredConstructorDiscoverer.discover(EntityWithoutConstructor.class)).satisfies(constructor -> { @@ -49,7 +49,7 @@ public class PreferredConstructorDiscovererUnitTests

{ @@ -60,35 +60,34 @@ public class PreferredConstructorDiscovererUnitTests

{ - assertThat(constructor).isNotNull(); - assertThat(constructor.isNoArgConstructor()).isFalse(); - assertThat(constructor.isExplicitlyAnnotated()).isTrue(); + assertThat(constructor).isNotNull(); + assertThat(constructor.isNoArgConstructor()).isFalse(); + assertThat(constructor.isExplicitlyAnnotated()).isTrue(); - assertThat(constructor.hasParameters()).isTrue(); + assertThat(constructor.hasParameters()).isTrue(); Iterator> parameters = (Iterator) constructor.getParameters().iterator(); - Parameter parameter = parameters.next(); - assertThat(parameter.getType().getType()).isEqualTo(Long.class); - assertThat(parameters.hasNext()).isFalse(); - }); + Parameter parameter = parameters.next(); + assertThat(parameter.getType().getType()).isEqualTo(Long.class); + assertThat(parameters.hasNext()).isFalse(); + }); } @Test // DATACMNS-134, DATACMNS-1126 - public void discoversInnerClassConstructorCorrectly() { + void discoversInnerClassConstructorCorrectly() { PersistentEntity entity = new BasicPersistentEntity<>(ClassTypeInformation.from(Inner.class)); @@ -100,7 +99,7 @@ public class PreferredConstructorDiscovererUnitTests

entity = new BasicPersistentEntity<>( ClassTypeInformation.from(SyntheticConstructor.class)); @@ -116,13 +115,12 @@ public class PreferredConstructorDiscovererUnitTests

{ + assertThat(PreferredConstructorDiscoverer.discover(NonStaticWithGenericTypeArgUsedInCtor.class)).satisfies(ctor -> { - assertThat(ctor.getParameters()).hasSize(2); - assertThat(ctor.getParameters().get(0).getName()).isEqualTo("this$0"); - assertThat(ctor.getParameters().get(1).getName()).isEqualTo("value"); - }); + assertThat(ctor.getParameters()).hasSize(2); + assertThat(ctor.getParameters().get(0).getName()).isEqualTo("this$0"); + assertThat(ctor.getParameters().get(1).getName()).isEqualTo("value"); + }); } @Test // GH-2313 @@ -150,7 +148,7 @@ public class PreferredConstructorDiscovererUnitTests

{ - protected GenericTypeArgUsedInCtor(T value) {} + GenericTypeArgUsedInCtor(T value) {} } - class NonStaticWithGenericTypeArgUsedInCtor { protected NonStaticWithGenericTypeArgUsedInCtor(T value) {}