Browse Source

DATACMNS-1076 - Deprecate RxJava1CrudRepository and RxJava1SortingRepository interfaces.

Spring Data 2.0 is going GA after the feature freeze of RxJava 1. In prospect of its EOL it makes no sense to ship new APIs based on a library that goes towards EOL.

RxJava1CrudRepository and RxJava1SortingRepository are subject to removal in a future milestone.
pull/224/merge
Mark Paluch 9 years ago
parent
commit
07da629356
  1. 2
      src/main/java/org/springframework/data/repository/reactive/RxJava1CrudRepository.java
  2. 2
      src/main/java/org/springframework/data/repository/reactive/RxJava1SortingRepository.java
  3. 10
      src/test/java/org/springframework/data/repository/core/support/ReactiveRepositoryInformationUnitTests.java

2
src/main/java/org/springframework/data/repository/reactive/RxJava1CrudRepository.java

@ -28,9 +28,11 @@ import org.springframework.data.repository.Repository; @@ -28,9 +28,11 @@ import org.springframework.data.repository.Repository;
*
* @author Mark Paluch
* @since 2.0
* @deprecated interface to be removed in 2.0 RC1.
* @see Single
* @see Observable
*/
@Deprecated
@NoRepositoryBean
public interface RxJava1CrudRepository<T, ID> extends Repository<T, ID> {

2
src/main/java/org/springframework/data/repository/reactive/RxJava1SortingRepository.java

@ -27,11 +27,13 @@ import org.springframework.data.repository.NoRepositoryBean; @@ -27,11 +27,13 @@ import org.springframework.data.repository.NoRepositoryBean;
*
* @author Mark Paluch
* @since 2.0
* @deprecated interface to be removed in 2.0 RC1.
* @see Sort
* @see Single
* @see Observable
* @see RxJava1CrudRepository
*/
@Deprecated
@NoRepositoryBean
public interface RxJava1SortingRepository<T, ID> extends RxJava1CrudRepository<T, ID> {

10
src/test/java/org/springframework/data/repository/core/support/ReactiveRepositoryInformationUnitTests.java

@ -18,6 +18,7 @@ package org.springframework.data.repository.core.support; @@ -18,6 +18,7 @@ package org.springframework.data.repository.core.support;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
import io.reactivex.Completable;
import io.reactivex.Flowable;
import reactor.core.publisher.Flux;
import rx.Observable;
@ -29,10 +30,10 @@ import org.junit.Test; @@ -29,10 +30,10 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
import org.reactivestreams.Publisher;
import org.springframework.data.repository.Repository;
import org.springframework.data.repository.core.RepositoryInformation;
import org.springframework.data.repository.reactive.ReactiveCrudRepository;
import org.springframework.data.repository.reactive.ReactiveSortingRepository;
import org.springframework.data.repository.reactive.RxJava1CrudRepository;
import org.springframework.data.repository.reactive.RxJava2CrudRepository;
/**
@ -133,7 +134,12 @@ public class ReactiveRepositoryInformationUnitTests { @@ -133,7 +134,12 @@ public class ReactiveRepositoryInformationUnitTests {
return information.getTargetClassMethod(repositoryType.getMethod(methodName, args));
}
interface RxJava1InterfaceWithGenerics extends RxJava1CrudRepository<User, String> {}
interface RxJava1InterfaceWithGenerics extends Repository<User, String> {
Observable<User> saveAll(Observable<User> entities);
Completable deleteAll();
}
interface RxJava2InterfaceWithGenerics extends RxJava2CrudRepository<User, String> {}

Loading…
Cancel
Save