Browse Source

Polishing.

Use Any instead of Object for type comparison. Align copy method visibility with constructor visibility.

See spring-projects/spring-data-build#2772
pull/3460/head
Mark Paluch 1 month ago
parent
commit
06da76ab9c
No known key found for this signature in database
GPG Key ID: 55BC6374BAA9D973
  1. 6
      src/test/kotlin/org/springframework/data/mapping/model/KotlinValueUtilsUnitTests.kt
  2. 2
      src/test/kotlin/org/springframework/data/mapping/model/UnusedCustomCopy.kt

6
src/test/kotlin/org/springframework/data/mapping/model/KotlinValueUtilsUnitTests.kt

@ -214,7 +214,7 @@ class KotlinValueUtilsUnitTests { @@ -214,7 +214,7 @@ class KotlinValueUtilsUnitTests {
val vh = KotlinValueUtils.getCopyValueHierarchy(
copyFunction.parameters.get(1)
)
assertThat(vh.actualType).isEqualTo(Object::class.java)
assertThat(vh.actualType).isEqualTo(Any::class.java)
}
@Test // GH-2986
@ -226,7 +226,7 @@ class KotlinValueUtilsUnitTests { @@ -226,7 +226,7 @@ class KotlinValueUtilsUnitTests {
val vh = KotlinValueUtils.getCopyValueHierarchy(
copyFunction.parameters.get(1)
)
assertThat(vh.actualType).isEqualTo(Object::class.java)
assertThat(vh.actualType).isEqualTo(Any::class.java)
}
@Test // GH-1947
@ -267,7 +267,7 @@ class KotlinValueUtilsUnitTests { @@ -267,7 +267,7 @@ class KotlinValueUtilsUnitTests {
assertThat(charseq.appliesBoxing()).isFalse
val recursive = KotlinValueUtils.getConstructorValueHierarchy(parameters[3]);
assertThat(recursive.actualType).isEqualTo(Object::class.java)
assertThat(recursive.actualType).isEqualTo(Any::class.java)
assertThat(recursive.parameterType).isEqualTo(MyGenericValue::class.java)
assertThat(recursive.appliesBoxing()).isFalse
}

2
src/test/kotlin/org/springframework/data/mapping/model/UnusedCustomCopy.kt

@ -22,7 +22,7 @@ import java.sql.Timestamp @@ -22,7 +22,7 @@ import java.sql.Timestamp
*/
data class UnusedCustomCopy internal constructor(val date: Timestamp) {
fun copy(date: Long): UnusedCustomCopy {
internal fun copy(date: Long): UnusedCustomCopy {
return UnusedCustomCopy(Timestamp(date))
}
}

Loading…
Cancel
Save