Browse Source

Revert "Add or avoid proxy configurations for integration tests"

This reverts commit 251f2805a8.
pull/4414/head
Dave Syer 10 years ago
parent
commit
fa9724becb
  1. 3
      README.adoc
  2. 22
      spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/ProjectCreator.java
  3. 2
      spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/starter/StarterDependenciesIntegrationTests.java
  4. 4
      spring-boot-samples/spring-boot-sample-ant/ivysettings.xml
  5. 16
      spring-boot-tools/spring-boot-antlib/pom.xml
  6. 8
      spring-boot-tools/spring-boot-antlib/src/it/sample/ivysettings.xml

3
README.adoc

@ -111,9 +111,6 @@ tests there (e.g. in Eclipse go to `Preferences->Java->Installed JREs` and edit
JRE definition so that all processes are launched with those arguments). This property JRE definition so that all processes are launched with those arguments). This property
is automatically set if you use the maven wrapper. is automatically set if you use the maven wrapper.
NOTE: Make sure that your Git config property "core.autocrlf" setting is set to true
under Windows to avoid build and test failures due to missing CRLF EOL characters.
_Also see link:CONTRIBUTING.adoc[CONTRIBUTING.adoc] if you wish to submit pull requests, _Also see link:CONTRIBUTING.adoc[CONTRIBUTING.adoc] if you wish to submit pull requests,
and in particular please fill out the and in particular please fill out the
https://support.springsource.com/spring_committer_signup[Contributor's Agreement] https://support.springsource.com/spring_committer_signup[Contributor's Agreement]

22
spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/ProjectCreator.java

@ -16,9 +16,7 @@
package org.springframework.boot.gradle; package org.springframework.boot.gradle;
import java.io.BufferedWriter;
import java.io.File; import java.io.File;
import java.io.FileWriter;
import java.io.IOException; import java.io.IOException;
import org.gradle.tooling.GradleConnector; import org.gradle.tooling.GradleConnector;
@ -48,8 +46,7 @@ public class ProjectCreator {
projectDirectory.mkdirs(); projectDirectory.mkdirs();
File gradleScript = new File(projectDirectory, "build.gradle"); File gradleScript = new File(projectDirectory, "build.gradle");
writeGradleProperties(projectDirectory);
if (new File("src/test/resources", name).isDirectory()) { if (new File("src/test/resources", name).isDirectory()) {
FileSystemUtils.copyRecursively(new File("src/test/resources", name), FileSystemUtils.copyRecursively(new File("src/test/resources", name),
projectDirectory); projectDirectory);
@ -65,21 +62,4 @@ public class ProjectCreator {
((DefaultGradleConnector) gradleConnector).embedded(true); ((DefaultGradleConnector) gradleConnector).embedded(true);
return gradleConnector.forProjectDirectory(projectDirectory).connect(); return gradleConnector.forProjectDirectory(projectDirectory).connect();
} }
private void writeGradleProperties(File projectDirectory) throws IOException {
File gradleProperties = new File(projectDirectory, "gradle.properties");
BufferedWriter writer = new BufferedWriter(new FileWriter(gradleProperties));
writeProperty(writer, "http.proxyHost");
writeProperty(writer, "https.proxyHost");
writeProperty(writer, "http.proxyPort");
writeProperty(writer, "https.proxyPort");
writer.close();
}
private void writeProperty(BufferedWriter writer, String name) throws IOException {
String value = System.getProperty(name);
if (value != null) {
writer.write("systemProp." + name + "=" + value + "\n");
}
}
} }

2
spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/starter/StarterDependenciesIntegrationTests.java

@ -91,7 +91,7 @@ public class StarterDependenciesIntegrationTests {
public StarterDependenciesIntegrationTests(String starter) { public StarterDependenciesIntegrationTests(String starter) {
this.buildArguments = new String[] { "-Pstarter=" + starter, this.buildArguments = new String[] { "-Pstarter=" + starter,
"-PbootVersion=" + bootVersion, "-PspringVersion=" + springVersion, "--stacktrace" }; "-PbootVersion=" + bootVersion, "-PspringVersion=" + springVersion };
} }
@Test @Test

4
spring-boot-samples/spring-boot-sample-ant/ivysettings.xml

@ -7,6 +7,10 @@
<artifact pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].[ext]" /> <artifact pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].[ext]" />
<ivy pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].pom" /> <ivy pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].pom" />
</filesystem> </filesystem>
<ibiblio name="ibiblio" m2compatible="true" />
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/release" />
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/milestone" />
<ibiblio name="spring-snapshots" m2compatible="true" root="http://repo.spring.io/snapshot" />
</chain> </chain>
</resolvers> </resolvers>
</ivysettings> </ivysettings>

16
spring-boot-tools/spring-boot-antlib/pom.xml

@ -36,21 +36,7 @@
<version>${ant.version}</version> <version>${ant.version}</version>
<scope>provided</scope> <scope>provided</scope>
</dependency> </dependency>
<!-- The antunit tests require joda-time --> </dependencies>
<dependency>
<groupId>joda-time</groupId>
<artifactId>joda-time</artifactId>
<version>${joda-time.version}</version>
<scope>compile</scope>
</dependency>
<!-- This is an optional depencency in the joda-time 2.8.1 pom.xml but Ivy tries to resolve it -->
<dependency>
<groupId>org.joda</groupId>
<artifactId>joda-convert</artifactId>
<version>1.2</version>
<scope>compile</scope>
</dependency>
</dependencies>
<build> <build>
<plugins> <plugins>
<plugin> <plugin>

8
spring-boot-tools/spring-boot-antlib/src/it/sample/ivysettings.xml

@ -4,9 +4,13 @@
<chain name="chain"> <chain name="chain">
<!-- NOTE: You should declare only repositories that you need here --> <!-- NOTE: You should declare only repositories that you need here -->
<filesystem name="local" local="true" m2compatible="true"> <filesystem name="local" local="true" m2compatible="true">
<artifact pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].[ext]" /> <artifact pattern="${user.home}/.m2/[organisation]/[module]/[revision]/[module]-[revision].[ext]" />
<ivy pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].pom" /> <ivy pattern="${user.home}/.m2/[organisation]/[module]/[revision]/[module]-[revision].pom" />
</filesystem> </filesystem>
<ibiblio name="ibiblio" m2compatible="true" />
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/release" />
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/milestone" />
<ibiblio name="spring-snapshots" m2compatible="true" root="http://repo.spring.io/snapshot" />
</chain> </chain>
</resolvers> </resolvers>
</ivysettings> </ivysettings>

Loading…
Cancel
Save