From fa95de7172893d6698aeb4476b92fb69800463e8 Mon Sep 17 00:00:00 2001 From: Sandipan Date: Thu, 4 Dec 2025 19:20:14 +0530 Subject: [PATCH] Address review comments Signed-off-by: Sandipan --- .../task/TaskExecutionProperties.java | 2 +- .../task/TaskExecutorConfigurations.java | 27 ++++--------------- 2 files changed, 6 insertions(+), 23 deletions(-) diff --git a/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionProperties.java b/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionProperties.java index 93eacc89c7f..306d34630ef 100644 --- a/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionProperties.java +++ b/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionProperties.java @@ -45,7 +45,7 @@ public class TaskExecutionProperties { private Mode mode = Mode.AUTO; /** - * Indicates whether to register ContextPropagatingTaskDecorator bean + * Whether to propagate the current context to task executions. */ private boolean propagateContext = false; diff --git a/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java b/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java index e4819f21058..35116708569 100644 --- a/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java +++ b/core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutorConfigurations.java @@ -75,36 +75,19 @@ class TaskExecutorConfigurations { @Bean(TaskExecutionAutoConfiguration.APPLICATION_TASK_EXECUTOR_BEAN_NAME) @ConditionalOnThreading(Threading.VIRTUAL) - SimpleAsyncTaskExecutor applicationTaskExecutorVirtualThreads(SimpleAsyncTaskExecutorBuilder builder, - ObjectProvider decorators) { - TaskDecorator decorator = decorators.getIfAvailable(); - SimpleAsyncTaskExecutor executor = builder.build(); - if (decorator != null) { - executor.setTaskDecorator(decorator); - } - return executor; + SimpleAsyncTaskExecutor applicationTaskExecutorVirtualThreads(SimpleAsyncTaskExecutorBuilder builder) { + return builder.build(); } @Bean(TaskExecutionAutoConfiguration.APPLICATION_TASK_EXECUTOR_BEAN_NAME) @Lazy @ConditionalOnThreading(Threading.PLATFORM) - ThreadPoolTaskExecutor applicationTaskExecutor( ThreadPoolTaskExecutorBuilder threadPoolTaskExecutorBuilder, - ObjectProvider decorators ) { - TaskDecorator decorator = decorators.getIfAvailable(); - ThreadPoolTaskExecutor executor = builder.build(); - if (decorator != null) { - executor.setTaskDecorator(decorator); - } - return executor; + ThreadPoolTaskExecutor applicationTaskExecutor(ThreadPoolTaskExecutorBuilder threadPoolTaskExecutorBuilder) { + return threadPoolTaskExecutorBuilder.build(); } @Bean - @ConditionalOnProperty( - prefix = "spring.task.execution", - name = "propagate-context", - havingValue = "true", - matchIfMissing = false - ) + @ConditionalOnProperty(prefix = "spring.task.execution.propagate-context", havingValue = "true") TaskDecorator contextPropagatingTaskDecorator() { return new ContextPropagatingTaskDecorator(); }