Browse Source

Fix warnings

pull/7512/head
Phillip Webb 9 years ago
parent
commit
ec73144240
  1. 1
      spring-boot-autoconfigure/pom.xml
  2. 1
      spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java
  3. 16
      spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration.java

1
spring-boot-autoconfigure/pom.xml

@ -613,7 +613,6 @@ @@ -613,7 +613,6 @@
<dependency>
<groupId>org.springframework.kafka</groupId>
<artifactId>spring-kafka-test</artifactId>
<version>${spring-kafka.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>

1
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java

@ -103,6 +103,7 @@ public class DataSourceAutoConfiguration { @@ -103,6 +103,7 @@ public class DataSourceAutoConfiguration {
@Import({ DataSourceConfiguration.Tomcat.class, DataSourceConfiguration.Hikari.class,
DataSourceConfiguration.Dbcp.class, DataSourceConfiguration.Dbcp2.class,
DataSourceConfiguration.Generic.class })
@SuppressWarnings("deprecation")
protected static class PooledDataSourceConfiguration {
}

16
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration.java

@ -42,6 +42,9 @@ abstract class DataSourceConfiguration { @@ -42,6 +42,9 @@ abstract class DataSourceConfiguration {
return (T) properties.initializeDataSourceBuilder().type(type).build();
}
/**
* Tomcat Pool DataSource configuration.
*/
@ConditionalOnClass(org.apache.tomcat.jdbc.pool.DataSource.class)
@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "org.apache.tomcat.jdbc.pool.DataSource", matchIfMissing = true)
static class Tomcat extends DataSourceConfiguration {
@ -64,6 +67,9 @@ abstract class DataSourceConfiguration { @@ -64,6 +67,9 @@ abstract class DataSourceConfiguration {
}
/**
* Hikari DataSource configuration.
*/
@ConditionalOnClass(HikariDataSource.class)
@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "com.zaxxer.hikari.HikariDataSource", matchIfMissing = true)
static class Hikari extends DataSourceConfiguration {
@ -75,6 +81,10 @@ abstract class DataSourceConfiguration { @@ -75,6 +81,10 @@ abstract class DataSourceConfiguration {
}
}
/**
* DBCP DataSource configuration.
* @deprecated as of Spring Boot 1.5 in favor of DBCP2
*/
@ConditionalOnClass(org.apache.commons.dbcp.BasicDataSource.class)
@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "org.apache.commons.dbcp.BasicDataSource", matchIfMissing = true)
@Deprecated
@ -97,6 +107,9 @@ abstract class DataSourceConfiguration { @@ -97,6 +107,9 @@ abstract class DataSourceConfiguration {
}
}
/**
* DBCP DataSource configuration.
*/
@ConditionalOnClass(org.apache.commons.dbcp2.BasicDataSource.class)
@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "org.apache.commons.dbcp2.BasicDataSource", matchIfMissing = true)
static class Dbcp2 extends DataSourceConfiguration {
@ -110,6 +123,9 @@ abstract class DataSourceConfiguration { @@ -110,6 +123,9 @@ abstract class DataSourceConfiguration {
}
}
/**
* Generic DataSource configuration.
*/
@ConditionalOnMissingBean(DataSource.class)
@ConditionalOnProperty(name = "spring.datasource.type")
static class Generic {

Loading…
Cancel
Save