diff --git a/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ApiVersion.java b/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ApiVersion.java index 6267ef8f851..6a89f6d96da 100644 --- a/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ApiVersion.java +++ b/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/http/ApiVersion.java @@ -70,7 +70,7 @@ public enum ApiVersion { private static ApiVersion forType(String type) { if (type.startsWith(MEDIA_TYPE_PREFIX)) { type = type.substring(MEDIA_TYPE_PREFIX.length()); - int suffixIndex = type.indexOf("+"); + int suffixIndex = type.indexOf('+'); type = (suffixIndex != -1) ? type.substring(0, suffixIndex) : type; try { return valueOf(type.toUpperCase()); diff --git a/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/init/ProjectGenerator.java b/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/init/ProjectGenerator.java index e44c31e3d28..1ecde55effa 100644 --- a/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/init/ProjectGenerator.java +++ b/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/init/ProjectGenerator.java @@ -74,10 +74,7 @@ class ProjectGenerator { return true; } // explicit name hasn't been provided for an archive and there is no extension - if (isZipArchive(response) && request.getOutput() != null && !request.getOutput().contains(".")) { - return true; - } - return false; + return isZipArchive(response) && request.getOutput() != null && !request.getOutput().contains("."); } private boolean isZipArchive(ProjectGenerationResponse entity) { diff --git a/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/DependencyCustomizer.java b/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/DependencyCustomizer.java index 5e12d8476ff..bfbeed9e454 100644 --- a/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/DependencyCustomizer.java +++ b/spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/DependencyCustomizer.java @@ -140,10 +140,7 @@ public class DependencyCustomizer { protected boolean canAdd() { for (String path : paths) { try { - if (DependencyCustomizer.this.loader.getResource(path) == null) { - return false; - } - return true; + return DependencyCustomizer.this.loader.getResource(path) != null; } catch (Exception ex) { // swallow exception and continue @@ -166,10 +163,7 @@ public class DependencyCustomizer { protected boolean canAdd() { for (String path : paths) { try { - if (DependencyCustomizer.this.loader.getResource(path) != null) { - return true; - } - return false; + return DependencyCustomizer.this.loader.getResource(path) != null; } catch (Exception ex) { // swallow exception and continue diff --git a/spring-boot-project/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java b/spring-boot-project/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java index a4488836201..cfe20c14b74 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java @@ -381,10 +381,7 @@ public abstract class MainClassFinder { return false; } MainClass other = (MainClass) obj; - if (!this.name.equals(other.name)) { - return false; - } - return true; + return this.name.equals(other.name); } @Override diff --git a/spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/ClassPathIndexFile.java b/spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/ClassPathIndexFile.java index ed11b19f01e..e60036340d3 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/ClassPathIndexFile.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/ClassPathIndexFile.java @@ -54,7 +54,7 @@ final class ClassPathIndexFile { } private String getFolder(String name) { - int lastSlash = name.lastIndexOf("/"); + int lastSlash = name.lastIndexOf('/'); return (lastSlash != -1) ? name.substring(0, lastSlash) : null; }