diff --git a/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironment.java b/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironment.java index b06fc5aa8cb..78011a7d6cf 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironment.java +++ b/spring-boot-project/spring-boot-docker-compose/src/main/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironment.java @@ -42,12 +42,12 @@ class OracleEnvironment { private String extractPassword(Map env) { if (env.containsKey("APP_USER")) { - String password = env.get("APP_PASSWORD"); + String password = env.get("APP_USER_PASSWORD"); Assert.state(StringUtils.hasLength(password), "No Oracle app password found"); return password; } Assert.state(!env.containsKey("ORACLE_RANDOM_PASSWORD"), - "ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_PASSWORD"); + "ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_USER_PASSWORD"); String password = env.get("ORACLE_PASSWORD"); Assert.state(StringUtils.hasLength(password), "No Oracle password found"); return password; diff --git a/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironmentTests.java b/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironmentTests.java index 334ee0812d4..4b9f37fca7b 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironmentTests.java +++ b/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleEnvironmentTests.java @@ -34,7 +34,8 @@ class OracleEnvironmentTests { @Test void getUsernameWhenHasAppUser() { - OracleEnvironment environment = new OracleEnvironment(Map.of("APP_USER", "alice", "APP_PASSWORD", "secret")); + OracleEnvironment environment = new OracleEnvironment( + Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "secret")); assertThat(environment.getUsername()).isEqualTo("alice"); } @@ -46,7 +47,8 @@ class OracleEnvironmentTests { @Test void getPasswordWhenHasAppPassword() { - OracleEnvironment environment = new OracleEnvironment(Map.of("APP_USER", "alice", "APP_PASSWORD", "secret")); + OracleEnvironment environment = new OracleEnvironment( + Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "secret")); assertThat(environment.getPassword()).isEqualTo("secret"); } @@ -59,14 +61,14 @@ class OracleEnvironmentTests { @Test void createWhenRandomPasswordAndAppPasswordDoesNotThrow() { assertThatNoException().isThrownBy(() -> new OracleEnvironment( - Map.of("APP_USER", "alice", "APP_PASSWORD", "secret", "ORACLE_RANDOM_PASSWORD", "true"))); + Map.of("APP_USER", "alice", "APP_USER_PASSWORD", "secret", "ORACLE_RANDOM_PASSWORD", "true"))); } @Test void createWhenRandomPasswordThrowsException() { assertThatIllegalStateException() .isThrownBy(() -> new OracleEnvironment(Map.of("ORACLE_RANDOM_PASSWORD", "true"))) - .withMessage("ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_PASSWORD"); + .withMessage("ORACLE_RANDOM_PASSWORD is not supported without APP_USER and APP_USER_PASSWORD"); } @Test @@ -78,7 +80,7 @@ class OracleEnvironmentTests { @Test void createWhenAppUserAndEmptyAppPasswordThrowsException() { assertThatIllegalStateException() - .isThrownBy(() -> new OracleEnvironment(Map.of("APP_USER", "alice", "APP_PASSWORD", ""))) + .isThrownBy(() -> new OracleEnvironment(Map.of("APP_USER", "alice", "APP_USER_PASSWORD", ""))) .withMessage("No Oracle app password found"); } diff --git a/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java b/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java index 4a56f269726..0d3c71cdc5a 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java +++ b/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/oracle/OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests.java @@ -51,8 +51,8 @@ class OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests extends Ab @SuppressWarnings("unchecked") void runCreatesConnectionDetailsThatCanBeUsedToAccessDatabase() throws Exception { JdbcConnectionDetails connectionDetails = run(JdbcConnectionDetails.class); - assertThat(connectionDetails.getUsername()).isEqualTo("system"); - assertThat(connectionDetails.getPassword()).isEqualTo("secret"); + assertThat(connectionDetails.getUsername()).isEqualTo("app_user"); + assertThat(connectionDetails.getPassword()).isEqualTo("app_user_secret"); assertThat(connectionDetails.getJdbcUrl()).startsWith("jdbc:oracle:thin:@").endsWith("/xepdb1"); SimpleDriverDataSource dataSource = new SimpleDriverDataSource(); dataSource.setUrl(connectionDetails.getJdbcUrl()); diff --git a/spring-boot-project/spring-boot-docker-compose/src/test/resources/org/springframework/boot/docker/compose/service/connection/oracle/oracle-compose.yaml b/spring-boot-project/spring-boot-docker-compose/src/test/resources/org/springframework/boot/docker/compose/service/connection/oracle/oracle-compose.yaml index fd467f44d45..1cfa3ca87a1 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/test/resources/org/springframework/boot/docker/compose/service/connection/oracle/oracle-compose.yaml +++ b/spring-boot-project/spring-boot-docker-compose/src/test/resources/org/springframework/boot/docker/compose/service/connection/oracle/oracle-compose.yaml @@ -4,6 +4,8 @@ services: ports: - '1521' environment: + - 'APP_USER=app_user' + - 'APP_USER_PASSWORD=app_user_secret' - 'ORACLE_PASSWORD=secret' healthcheck: test: ["CMD-SHELL", "healthcheck.sh"]