Browse Source

Fix bug introduced by Spring @Configuration processing

pull/1/head
Dave Syer 13 years ago
parent
commit
ad19edf03b
  1. 9
      spring-bootstrap-actuator/src/main/java/org/springframework/bootstrap/actuate/autoconfigure/TraceFilterConfiguration.java
  2. 42
      spring-bootstrap-actuator/src/test/java/org/springframework/bootstrap/actuate/autoconfigure/TraceFilterConfigurationTests.java
  3. 4
      spring-bootstrap/src/main/java/org/springframework/bootstrap/context/annotation/ConfigurationPropertiesBindingConfiguration.java
  4. 1
      spring-bootstrap/src/test/resources/logback-test.xml

9
spring-bootstrap-actuator/src/main/java/org/springframework/bootstrap/actuate/autoconfigure/TraceFilterConfiguration.java

@ -45,10 +45,13 @@ public class TraceFilterConfiguration { @@ -45,10 +45,13 @@ public class TraceFilterConfiguration {
@Value("${management.dump_requests:false}")
private boolean dumpRequests;
@Bean
@ConditionalOnMissingBean(TraceRepository.class)
protected TraceRepository traceRepository() {
return this.traceRepository;
@Configuration
protected static class TraceRepositoryConfiguration {
@Bean
public TraceRepository traceRepository() {
return new InMemoryTraceRepository();
}
}
@Bean

42
spring-bootstrap-actuator/src/test/java/org/springframework/bootstrap/actuate/autoconfigure/TraceFilterConfigurationTests.java

@ -0,0 +1,42 @@ @@ -0,0 +1,42 @@
/*
* Copyright 2012-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.bootstrap.actuate.autoconfigure;
import org.junit.Test;
import org.springframework.bootstrap.actuate.trace.TraceRepository;
import org.springframework.bootstrap.autoconfigure.PropertyPlaceholderAutoConfiguration;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import static org.junit.Assert.assertNotNull;
/**
* @author Dave Syer
*/
public class TraceFilterConfigurationTests {
private AnnotationConfigApplicationContext context;
@Test
public void testTraceConfiguration() throws Exception {
this.context = new AnnotationConfigApplicationContext();
this.context.register(PropertyPlaceholderAutoConfiguration.class,
TraceFilterConfiguration.class);
this.context.refresh();
assertNotNull(this.context.getBean(TraceRepository.class));
}
}

4
spring-bootstrap/src/main/java/org/springframework/bootstrap/context/annotation/ConfigurationPropertiesBindingConfiguration.java

@ -58,13 +58,11 @@ public class ConfigurationPropertiesBindingConfiguration { @@ -58,13 +58,11 @@ public class ConfigurationPropertiesBindingConfiguration {
@ConditionalOnMissingBean(name = VALIDATOR_BEAN_NAME)
@ConditionalOnClass(name = "javax.validation.Validator")
public static class ValidatorConfiguration {
protected static class ValidatorConfiguration {
@Bean
protected Validator configurationPropertiesValidator() {
return new LocalValidatorFactoryBean();
}
}
/**

1
spring-bootstrap/src/test/resources/logback-test.xml

@ -7,6 +7,7 @@ @@ -7,6 +7,7 @@
<pattern>${LOG_PATTERN}</pattern>
</encoder>
</appender>
<logger name="org.springframework.beans.factory.annotation" level="TRACE" />
<root level="INFO">
<appender-ref ref="CONSOLE" />
</root>

Loading…
Cancel
Save