From a6afc3995688b59a9ca71a5916abcf43d51f4d14 Mon Sep 17 00:00:00 2001 From: Moritz Halbritter Date: Tue, 2 Sep 2025 14:33:48 +0200 Subject: [PATCH] Polish "Create service connections for image with registry host and without project" See gh-46974 --- .../service/connection/ConnectionNamePredicateTests.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/ConnectionNamePredicateTests.java b/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/ConnectionNamePredicateTests.java index 3209a5aa2c6..4050f17f06d 100644 --- a/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/ConnectionNamePredicateTests.java +++ b/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/ConnectionNamePredicateTests.java @@ -61,10 +61,15 @@ class ConnectionNamePredicateTests { @Test void customDomain() { + assertThat(predicateOf("redis")).accepts(sourceOf("internalhost:8080/redis")); assertThat(predicateOf("redis")).accepts(sourceOf("internalhost:8080/library/redis")); + assertThat(predicateOf("redis")).accepts(sourceOf("myhost.com/redis")); assertThat(predicateOf("redis")).accepts(sourceOf("myhost.com/library/redis")); assertThat(predicateOf("redis")).accepts(sourceOf("myhost.com:8080/library/redis")); - assertThat(predicateOf("redis")).accepts(sourceOf("internalhost:8080/redis")); + assertThat(predicateOf("openzipkin/zipkin")).rejects(sourceOf("myhost.com:8080/zipkin")); + assertThat(predicateOf("openzipkin/zipkin")).rejects(sourceOf("myhost.com:8080/library/zipkin")); + assertThat(predicateOf("openzipkin/zipkin")).accepts(sourceOf("myhost.com:8080/openzipkin/zipkin")); + assertThat(predicateOf("postgres")).accepts(sourceOf("docker.my-company.com/postgres:latest")); } @Test