From 9b1c07c0eb44dc1226d86228b2710bc9fbb04e87 Mon Sep 17 00:00:00 2001 From: Moritz Halbritter Date: Thu, 14 Aug 2025 14:54:59 +0200 Subject: [PATCH] Improve null-safety of configuration-metadata/spring-boot-configuration-metadata-changelog-generator See gh-46926 --- .../configurationmetadata/changelog/ChangelogGenerator.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configuration-metadata/spring-boot-configuration-metadata-changelog-generator/src/main/java/org/springframework/boot/configurationmetadata/changelog/ChangelogGenerator.java b/configuration-metadata/spring-boot-configuration-metadata-changelog-generator/src/main/java/org/springframework/boot/configurationmetadata/changelog/ChangelogGenerator.java index 1dca635ee67..3adb1cdbdf9 100644 --- a/configuration-metadata/spring-boot-configuration-metadata-changelog-generator/src/main/java/org/springframework/boot/configurationmetadata/changelog/ChangelogGenerator.java +++ b/configuration-metadata/spring-boot-configuration-metadata-changelog-generator/src/main/java/org/springframework/boot/configurationmetadata/changelog/ChangelogGenerator.java @@ -62,7 +62,11 @@ public final class ChangelogGenerator { static ConfigurationMetadataRepository buildRepository(File directory) { ConfigurationMetadataRepositoryJsonBuilder builder = ConfigurationMetadataRepositoryJsonBuilder.create(); - for (File file : directory.listFiles()) { + File[] files = directory.listFiles(); + if (files == null) { + throw new IllegalStateException("'files' must not be null"); + } + for (File file : files) { try (JarFile jarFile = new JarFile(file)) { JarEntry metadataEntry = jarFile.getJarEntry("META-INF/spring-configuration-metadata.json"); if (metadataEntry != null) {