Browse Source

Merge branch '3.5.x'

Closes gh-47718
pull/47720/head
Brian Clozel 2 months ago
parent
commit
90c656c529
  1. 9
      module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyVirtualThreadsWebServerFactoryCustomizer.java
  2. 19
      module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyVirtualThreadsWebServerFactoryCustomizerTests.java

9
module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyVirtualThreadsWebServerFactoryCustomizer.java

@ -17,7 +17,7 @@ @@ -17,7 +17,7 @@
package org.springframework.boot.jetty.autoconfigure;
import org.eclipse.jetty.util.VirtualThreads;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
import org.eclipse.jetty.util.thread.VirtualThreadPool;
import org.springframework.boot.context.properties.bind.Bindable;
import org.springframework.boot.context.properties.bind.Binder;
@ -32,6 +32,7 @@ import org.springframework.util.Assert; @@ -32,6 +32,7 @@ import org.springframework.util.Assert;
* Activates virtual threads on the {@link ConfigurableJettyWebServerFactory}.
*
* @author Moritz Halbritter
* @author Brian Clozel
* @since 4.0.0
*/
public class JettyVirtualThreadsWebServerFactoryCustomizer
@ -49,9 +50,9 @@ public class JettyVirtualThreadsWebServerFactoryCustomizer @@ -49,9 +50,9 @@ public class JettyVirtualThreadsWebServerFactoryCustomizer
@Override
public void customize(ConfigurableJettyWebServerFactory factory) {
Assert.state(VirtualThreads.areSupported(), "Virtual threads are not supported");
QueuedThreadPool threadPool = JettyThreadPool.create(this.jettyProperties.getThreads());
threadPool.setVirtualThreadsExecutor(VirtualThreads.getNamedVirtualThreadsExecutor("jetty-"));
factory.setThreadPool(threadPool);
VirtualThreadPool virtualThreadPool = new VirtualThreadPool();
virtualThreadPool.setName("jetty-");
factory.setThreadPool(virtualThreadPool);
}
@Override

19
module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyVirtualThreadsWebServerFactoryCustomizerTests.java

@ -16,13 +16,7 @@ @@ -16,13 +16,7 @@
package org.springframework.boot.jetty.autoconfigure;
import java.time.Duration;
import java.util.concurrent.Executor;
import java.util.concurrent.atomic.AtomicReference;
import org.awaitility.Awaitility;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
import org.hamcrest.Matchers;
import org.eclipse.jetty.util.thread.VirtualThreadPool;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledForJreRange;
import org.junit.jupiter.api.condition.JRE;
@ -50,14 +44,9 @@ class JettyVirtualThreadsWebServerFactoryCustomizerTests { @@ -50,14 +44,9 @@ class JettyVirtualThreadsWebServerFactoryCustomizerTests {
ConfigurableJettyWebServerFactory factory = mock(ConfigurableJettyWebServerFactory.class);
customizer.customize(factory);
then(factory).should().setThreadPool(assertArg((threadPool) -> {
assertThat(threadPool).isInstanceOf(QueuedThreadPool.class);
QueuedThreadPool queuedThreadPool = (QueuedThreadPool) threadPool;
Executor executor = queuedThreadPool.getVirtualThreadsExecutor();
assertThat(executor).isNotNull();
AtomicReference<String> threadName = new AtomicReference<>();
executor.execute(() -> threadName.set(Thread.currentThread().getName()));
Awaitility.await().atMost(Duration.ofSeconds(1)).untilAtomic(threadName, Matchers.notNullValue());
assertThat(threadName.get()).startsWith("jetty-");
assertThat(threadPool).isInstanceOf(VirtualThreadPool.class);
VirtualThreadPool virtualThreadPool = (VirtualThreadPool) threadPool;
assertThat(virtualThreadPool.getName()).isEqualTo("jetty-");
}));
}

Loading…
Cancel
Save