From f13e487724838cafcb10e76bb1ec33459d492b5c Mon Sep 17 00:00:00 2001 From: Moritz Halbritter Date: Fri, 26 Apr 2024 09:20:36 +0200 Subject: [PATCH] Close streams in test before deleting file --- .../boot/buildpack/platform/build/ImageBuildpackTests.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java b/spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java index e62cb63da6d..b10b0f0c760 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java @@ -180,8 +180,7 @@ class ImageBuildpackTests extends AbstractJsonTests { try { IOBiConsumer consumer = invocation.getArgument(1); File tarFile = File.createTempFile("create-builder-test-", null); - FileOutputStream out = new FileOutputStream(tarFile); - try (TarArchiveOutputStream tarOut = new TarArchiveOutputStream(out)) { + try (TarArchiveOutputStream tarOut = new TarArchiveOutputStream(new FileOutputStream(tarFile))) { tarOut.setLongFileMode(TarArchiveOutputStream.LONGFILE_POSIX); writeTarEntry(tarOut, "/cnb/"); writeTarEntry(tarOut, "/cnb/buildpacks/"); @@ -191,7 +190,9 @@ class ImageBuildpackTests extends AbstractJsonTests { writeTarEntry(tarOut, "/cnb/buildpacks/example_buildpack/0.0.1/" + this.longFilePath); tarOut.finish(); } - consumer.accept("test", TarArchive.fromInputStream(new FileInputStream(tarFile), Compression.NONE)); + try (FileInputStream tarFileStream = new FileInputStream(tarFile)) { + consumer.accept("test", TarArchive.fromInputStream(tarFileStream, Compression.NONE)); + } Files.delete(tarFile.toPath()); } catch (IOException ex) {