From ff855d9421c72502dfbcca3f354b57a77231c605 Mon Sep 17 00:00:00 2001 From: Tran Ngoc Nhan Date: Sun, 27 Oct 2024 12:14:00 +0700 Subject: [PATCH 1/2] Remove redundant null check See gh-42901 --- .../boot/test/mock/mockito/QualifierDefinition.java | 2 +- .../boot/configurationprocessor/PropertyDescriptor.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java b/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java index b2bab55feac..7202c0b9fb5 100644 --- a/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java +++ b/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java @@ -78,7 +78,7 @@ class QualifierDefinition { } static QualifierDefinition forElement(AnnotatedElement element) { - if (element != null && element instanceof Field field) { + if (element instanceof Field field) { Set annotations = getQualifierAnnotations(field); if (!annotations.isEmpty()) { return new QualifierDefinition(field, annotations); diff --git a/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java b/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java index 83cc3470422..a13dc69c197 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java @@ -176,7 +176,7 @@ abstract class PropertyDescriptor { } returnType = getTopLevelType(returnType); Element candidate = element; - while (candidate != null && candidate instanceof TypeElement) { + while (candidate instanceof TypeElement) { if (returnType.equals(getTopLevelType(candidate))) { return true; } From eba7a5a0771c7b4a603bbe7a5f546e21480cf60f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Nicoll?= Date: Tue, 29 Oct 2024 13:35:35 +0900 Subject: [PATCH 2/2] Update copyright year of changed files See gh-42901 --- .../boot/test/mock/mockito/QualifierDefinition.java | 2 +- .../boot/configurationprocessor/PropertyDescriptor.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java b/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java index 7202c0b9fb5..c3830adec8d 100644 --- a/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java +++ b/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/QualifierDefinition.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2022 the original author or authors. + * Copyright 2012-2024 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java b/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java index a13dc69c197..b8a7bb5da8d 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/PropertyDescriptor.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2022 the original author or authors. + * Copyright 2012-2024 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.