Browse Source

Polish "Add server-side support for custom gRPC conventions"

See gh-49730
pull/49730/head
Stéphane Nicoll 1 week ago
parent
commit
3ebc8653d5
  1. 10
      module/spring-boot-grpc-server/src/test/java/org/springframework/boot/grpc/server/autoconfigure/GrpcServerObservationAutoConfigurationTests.java

10
module/spring-boot-grpc-server/src/test/java/org/springframework/boot/grpc/server/autoconfigure/GrpcServerObservationAutoConfigurationTests.java

@ -22,6 +22,7 @@ import java.util.Map; @@ -22,6 +22,7 @@ import java.util.Map;
import io.grpc.BindableService;
import io.grpc.ServerInterceptor;
import io.micrometer.context.ContextRegistry;
import io.micrometer.core.instrument.binder.grpc.GrpcServerObservationConvention;
import io.micrometer.core.instrument.binder.grpc.ObservationGrpcServerInterceptor;
import io.micrometer.core.instrument.kotlin.ObservationCoroutineContextServerInterceptor;
import io.micrometer.observation.ObservationRegistry;
@ -35,6 +36,7 @@ import org.springframework.grpc.server.GlobalServerInterceptor; @@ -35,6 +36,7 @@ import org.springframework.grpc.server.GlobalServerInterceptor;
import org.springframework.grpc.server.GrpcServerFactory;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
/**
* Tests for the {@link GrpcServerObservationAutoConfiguration}.
@ -123,6 +125,14 @@ class GrpcServerObservationAutoConfigurationTests { @@ -123,6 +125,14 @@ class GrpcServerObservationAutoConfigurationTests {
});
}
@Test
void whenCustomConventionBeanIsPresentThenInterceptorUsesIt() {
GrpcServerObservationConvention customConvention = mock(GrpcServerObservationConvention.class);
this.contextRunner.withBean(GrpcServerObservationConvention.class, () -> customConvention)
.run((context) -> assertThat(context.getBean(ObservationGrpcServerInterceptor.class))
.hasFieldOrPropertyWithValue("customConvention", customConvention));
}
@Test
void whenMicrometerContextPropagationIsNotOnClasspathCoroutineInterceptorIsNotCreated() {
this.contextRunner.withClassLoader(new FilteredClassLoader(ContextRegistry.class))

Loading…
Cancel
Save