Browse Source

Polish

pull/5636/merge
Phillip Webb 10 years ago
parent
commit
2d992c1324
  1. 7
      spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfiguration.java
  2. 12
      spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfigurationTests.java
  3. 2
      spring-boot/src/main/java/org/springframework/boot/jta/narayana/NarayanaProperties.java

7
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfiguration.java

@ -50,7 +50,7 @@ import org.springframework.data.couchbase.config.CouchbaseConfigurer; @@ -50,7 +50,7 @@ import org.springframework.data.couchbase.config.CouchbaseConfigurer;
public class CouchbaseAutoConfiguration {
@Configuration
@ConditionalOnMissingBean({CouchbaseConfigurer.class, CouchbaseConfiguration.class})
@ConditionalOnMissingBean({ CouchbaseConfigurer.class, CouchbaseConfiguration.class })
public static class CouchbaseConfiguration {
private final CouchbaseProperties properties;
@ -91,9 +91,10 @@ public class CouchbaseAutoConfiguration { @@ -91,9 +91,10 @@ public class CouchbaseAutoConfiguration {
/**
* Initialize an environment builder based on the specified settings.
* @param properties the couchbase properties to use
* @return a {@link DefaultCouchbaseEnvironment.Builder}
* @return the {@link DefaultCouchbaseEnvironment} builder.
*/
protected DefaultCouchbaseEnvironment.Builder initializeEnvironmentBuilder(CouchbaseProperties properties) {
protected DefaultCouchbaseEnvironment.Builder initializeEnvironmentBuilder(
CouchbaseProperties properties) {
CouchbaseProperties.Endpoints endpoints = properties.getEnv().getEndpoints();
CouchbaseProperties.Timeouts timeouts = properties.getEnv().getTimeouts();
DefaultCouchbaseEnvironment.Builder builder = DefaultCouchbaseEnvironment

12
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfigurationTests.java

@ -124,10 +124,12 @@ public class CouchbaseAutoConfigurationTests @@ -124,10 +124,12 @@ public class CouchbaseAutoConfigurationTests
@Test
public void customizeEnvWithCustomCouchbaseConfiguration() {
load(CustomCouchbaseConfiguration.class, "spring.couchbase.bootstrap-hosts=localhost",
load(CustomCouchbaseConfiguration.class,
"spring.couchbase.bootstrap-hosts=localhost",
"spring.couchbase.env.timeouts.connect=100");
assertThat(this.context.getBeansOfType(CouchbaseConfiguration.class)).hasSize(1);
DefaultCouchbaseEnvironment env = this.context.getBean(DefaultCouchbaseEnvironment.class);
DefaultCouchbaseEnvironment env = this.context
.getBean(DefaultCouchbaseEnvironment.class);
assertThat(env.socketConnectTimeout()).isEqualTo(5000);
assertThat(env.connectTimeout()).isEqualTo(2000);
}
@ -136,8 +138,7 @@ public class CouchbaseAutoConfigurationTests @@ -136,8 +138,7 @@ public class CouchbaseAutoConfigurationTests
throws Exception {
load(CouchbaseTestConfigurer.class, environment);
CouchbaseProperties properties = this.context.getBean(CouchbaseProperties.class);
return new CouchbaseConfiguration(
properties).couchbaseEnvironment();
return new CouchbaseConfiguration(properties).couchbaseEnvironment();
}
@Configuration
@ -149,7 +150,8 @@ public class CouchbaseAutoConfigurationTests @@ -149,7 +150,8 @@ public class CouchbaseAutoConfigurationTests
}
@Override
protected DefaultCouchbaseEnvironment.Builder initializeEnvironmentBuilder(CouchbaseProperties properties) {
protected DefaultCouchbaseEnvironment.Builder initializeEnvironmentBuilder(
CouchbaseProperties properties) {
return super.initializeEnvironmentBuilder(properties)
.socketConnectTimeout(5000).connectTimeout(2000);
}

2
spring-boot/src/main/java/org/springframework/boot/jta/narayana/NarayanaProperties.java

@ -48,7 +48,7 @@ public class NarayanaProperties { @@ -48,7 +48,7 @@ public class NarayanaProperties {
private String transactionManagerId = "1";
/**
* Enable one phase commit optimisation.
* Enable one phase commit optimization.
*/
private boolean onePhaseCommit = true;

Loading…
Cancel
Save