diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsFilterTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsFilterTests.java index 5ee55dbaf43..4d967751378 100644 --- a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsFilterTests.java +++ b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsFilterTests.java @@ -186,7 +186,7 @@ class WebMvcMetricsFilterTests { void streamingError() throws Exception { MvcResult result = this.mvc.perform(get("/api/c1/streamingError")).andExpect(request().asyncStarted()) .andReturn(); - assertThatCode(() -> this.mvc.perform(asyncDispatch(result)).andExpect(status().isOk())); + this.mvc.perform(asyncDispatch(result)).andExpect(status().isOk()); assertThat(this.registry.get("http.server.requests").tags("exception", "IOException").timer().count()) .isEqualTo(1L); } diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsIntegrationTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsIntegrationTests.java index e1536775e6a..974654153e2 100644 --- a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsIntegrationTests.java +++ b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsIntegrationTests.java @@ -46,7 +46,6 @@ import org.springframework.web.context.WebApplicationContext; import org.springframework.web.servlet.config.annotation.EnableWebMvc; import static org.assertj.core.api.Assertions.assertThat; -import static org.assertj.core.api.Assertions.assertThatCode; import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; @@ -84,8 +83,8 @@ class WebMvcMetricsIntegrationTests { } @Test - void rethrownExceptionIsRecordedInMetricTag() { - assertThatCode(() -> this.mvc.perform(get("/api/rethrownError")).andExpect(status().is5xxServerError())); + void rethrownExceptionIsRecordedInMetricTag() throws Exception { + this.mvc.perform(get("/api/rethrownError")).andExpect(status().is5xxServerError()); assertThat(this.registry.get("http.server.requests").tags("exception", "Exception2", "status", "500").timer() .count()).isEqualTo(1L); } diff --git a/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/metadata/TestJsonConverter.java b/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/metadata/TestJsonConverter.java index 2072ebcac8b..0f2c92e9445 100644 --- a/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/metadata/TestJsonConverter.java +++ b/spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/metadata/TestJsonConverter.java @@ -31,7 +31,7 @@ public class TestJsonConverter extends JsonConverter { @Override public JSONArray toJsonArray(ConfigurationMetadata metadata, ItemType itemType) throws Exception { - return toJsonArray(metadata, itemType); + return super.toJsonArray(metadata, itemType); } @Override diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java index f1b7a2c969a..6e4b500aec4 100644 --- a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java +++ b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/netty/NettyWebServer.java @@ -106,7 +106,9 @@ public class NettyWebServer implements WebServer { } private void applyRouteProviders(HttpServerRoutes routes) { - this.routeProviders.forEach((provider) -> provider.apply(routes)); + for (NettyRouteProvider provider : this.routeProviders) { + routes = provider.apply(routes); + } routes.route(ALWAYS, this.handlerAdapter); }