From 1a140a80d8e2953bbeecbe591cdf6fa0f0e6077e Mon Sep 17 00:00:00 2001
From: Stephane Nicoll <snicoll@pivotal.io>
Date: Wed, 10 Oct 2018 18:40:10 +0200
Subject: [PATCH] Improve logger-name value hint definition

This commit improve the logger-name value hint by adding a group
attribute that can be defined to specify whether logging groups should
be considered.

Closes gh-14748
---
 .../appendix-configuration-metadata.adoc      | 20 +++++++++++++++----
 ...itional-spring-configuration-metadata.json | 12 +++++++++++
 2 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-configuration-metadata.adoc b/spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-configuration-metadata.adoc
index ef9732189c0..8b395211381 100644
--- a/spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-configuration-metadata.adoc
+++ b/spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-configuration-metadata.adoc
@@ -599,10 +599,22 @@ keep the original String value to pass it to the Liquibase API.
 ===== Logger Name
 The **logger-name** provider auto-completes valid logger names and
 <<spring-boot-features.adoc#boot-features-custom-log-groups,logger groups>>. Typically,
-package and class names available in the current project can be auto-completed. If a
-custom logger group is identified in the configuration, auto-completion for it should
-be provided. Specific frameworks may have extra magic logger names that can be supported
-as well.
+package and class names available in the current project can be auto-completed. If groups
+are enabled (default) and if a custom logger group is identified in the configuration,
+auto-completion for it should be provided. Specific frameworks may have extra magic logger
+names that can be supported as well.
+
+This provider supports the following parameters:
+
+[cols="1,1,2,4"]
+|===
+|Parameter |Type |Default value |Description
+
+|`group`
+|`boolean`
+|`true`
+|Specify whether known groups should be considered.
+|===
 
 Since a logger name can be any arbitrary name, this provider should allow any
 value but could highlight valid package and class names that are not available in the
diff --git a/spring-boot-project/spring-boot/src/main/resources/META-INF/additional-spring-configuration-metadata.json b/spring-boot-project/spring-boot/src/main/resources/META-INF/additional-spring-configuration-metadata.json
index 8bd45e1b418..a251338b9ba 100644
--- a/spring-boot-project/spring-boot/src/main/resources/META-INF/additional-spring-configuration-metadata.json
+++ b/spring-boot-project/spring-boot/src/main/resources/META-INF/additional-spring-configuration-metadata.json
@@ -338,6 +338,18 @@
     }
   ],
   "hints": [
+    {
+      "name": "logging.group.values",
+      "providers": [
+        {
+          "name": "logger-name",
+          "parameters": {
+            "group": false
+          }
+
+        }
+      ]
+    },
     {
       "name": "logging.level.keys",
       "values": [