From 11d6c434d97559e600263991e49e6acdcca09ea0 Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Thu, 4 Sep 2025 09:27:44 +0100 Subject: [PATCH] Test that default max HTTP request header aligns with Tomcat Closes gh-46977 --- .../boot/autoconfigure/web/ServerPropertiesTests.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java index bf00a27d935..6ad3b20bc70 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java @@ -30,6 +30,7 @@ import org.apache.catalina.core.StandardEngine; import org.apache.catalina.valves.AccessLogValve; import org.apache.catalina.valves.RemoteIpValve; import org.apache.coyote.AbstractProtocol; +import org.apache.coyote.http11.Http11Nio2Protocol; import org.apache.tomcat.util.net.AbstractEndpoint; import org.eclipse.jetty.ee10.servlet.ServletContextHandler; import org.eclipse.jetty.server.Server; @@ -220,6 +221,12 @@ class ServerPropertiesTests { assertThat(this.properties.getMaxHttpRequestHeaderSize()).isEqualTo(DataSize.ofKilobytes(1)); } + @Test + void defaultMaxHttpRequestHeaderSizeMatchesTomcatsDefault() { + assertThat(this.properties.getMaxHttpRequestHeaderSize().toBytes()) + .isEqualTo(new Http11Nio2Protocol().getMaxHttpRequestHeaderSize()); + } + @Test void testCustomizeTomcatMaxThreads() { bind("server.tomcat.threads.max", "10");