From 81c25ef6cb123fcd6e168ea582d6efbb424c6888 Mon Sep 17 00:00:00 2001 From: Joe Grandja <10884212+jgrandja@users.noreply.github.com> Date: Tue, 4 Mar 2025 07:02:39 -0500 Subject: [PATCH] Fix test in OAuth2PushedAuthorizationRequestEndpointFilterTests Issue gh-1925 --- ...OAuth2PushedAuthorizationRequestEndpointFilterTests.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/web/OAuth2PushedAuthorizationRequestEndpointFilterTests.java b/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/web/OAuth2PushedAuthorizationRequestEndpointFilterTests.java index ee5930a4..14cdf7d3 100644 --- a/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/web/OAuth2PushedAuthorizationRequestEndpointFilterTests.java +++ b/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/web/OAuth2PushedAuthorizationRequestEndpointFilterTests.java @@ -16,7 +16,6 @@ package org.springframework.security.oauth2.server.authorization.web; import java.time.Instant; -import java.time.temporal.ChronoUnit; import java.util.Map; import java.util.function.Consumer; @@ -426,8 +425,9 @@ public class OAuth2PushedAuthorizationRequestEndpointFilterTests { assertThat(response.getStatus()).isEqualTo(HttpStatus.CREATED.value()); Map responseParameters = readPushedAuthorizationResponse(response); assertThat(responseParameters.get("request_uri")).isEqualTo(requestUri); - assertThat(responseParameters.get("expires_in")) - .isEqualTo((int) ChronoUnit.SECONDS.between(Instant.now(), requestUriExpiresAt)); + Instant requestUriExpiry = Instant.now() + .plusSeconds(Long.parseLong(String.valueOf(responseParameters.get("expires_in")))); + assertThat(requestUriExpiry).isBetween(requestUriExpiresAt.minusSeconds(1), requestUriExpiresAt.plusSeconds(1)); } private void doFilterWhenPushedAuthorizationRequestInvalidParameterThenError(RegisteredClient registeredClient,