compose-jb/gradle-plugins at e20717fb9d6e1925919d74b2724513a8c5af3ca8 - compose-jb - Gitea: Git with a cup of tea

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.

javascript android desktop kotlin compose declarative-ui awt gui multiplatform reactive swing ui

Tree: e20717fb9d

History

Igor Demin af7c80c571 Fix `runRelease` task when navigation and `obfuscate.set(true)` are used (#5384 ) Fixes https://youtrack.jetbrains.com/issue/CMP-8050/Desktop-runRelease-crash-when-upgrade-to-CMP-1.8.0-rc01 `./gradlew runRelease` throws an error: ``` Exception in thread "main" kotlinx.a.g: Serializer for class 'LoginRoute' is not found ``` in this code: ``` import androidx.compose.ui.window.singleWindowApplication import androidx.navigation.compose.NavHost import androidx.navigation.compose.composable import androidx.navigation.compose.rememberNavController import kotlinx.serialization.Serializable fun main() = singleWindowApplication { NavHost( navController = rememberNavController(), startDestination = LoginRoute() ) { composable<LoginRoute> {} } } @Serializable data class LoginRoute(val id: Long? = null) ``` with obfuscation enabled: ``` compose.desktop { application { mainClass = "MainKt" nativeDistributions { targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb) packageName = "org.jetbrains.nav_cupcake" packageVersion = "1.0.0" } buildTypes.release.proguard { obfuscate.set(true) } } } ``` It crashes because: - we use `@InternalSerializationApi kotlinx.serialization.serializer` which is used by Navigation - it uses reflection underneath. Looks like it tries to find serializer 2 ways: - Looking at the field `static final LoginRoute.Companion.serializer` - Looking at the `inner class LoginRoute.Companion` and its name - The [the default](https://github.com/Kotlin/kotlinx.serialization/blob/4667a18/rules/common.pro) rules: - [no obfuscation] work by the second way, but doesn't work by the first - [with obfuscation] don't work by both ways The new rule support the first for both obfuscated/non-obfuscated code ## Details ### Old rules #### Without obfuscation ``` // LoginRoute.class public final class LoginRoute { public static final Companion Companion = new Companion((byte)0); ... public static final class Companion { private Companion() {} } } // LoginRoute$Companion.class public final class Companion { private Companion() {} } ``` #### With obfuscation ``` // LoginRoute.class @Serializable public final class LoginRoute { public static final a Companion = new a((byte)0); ... } // a.class public final class a { private a() {} } ``` ### With new rule #### Without obfuscation ``` // LoginRoute.class @Serializable public final class LoginRoute { public static final Companion Companion = new Companion((byte)0); ... public static final class Companion { private Companion() {} public final KSerializer<LoginRoute> serializer() { return (KSerializer<LoginRoute>)LoginRoute.$serializer.INSTANCE; } } } // LoginRoute$Companion.class public final class Companion { private Companion() {} public final KSerializer<LoginRoute> serializer() { return (KSerializer<LoginRoute>)LoginRoute.$serializer.INSTANCE; } } ``` #### With obfuscation ``` // LoginRoute.class @Serializable public final class LoginRoute { public static final a Companion = new a((byte)0); ... } // a.class public final class a { private a() {} public final b serializer() { return (b)LoginRoute$$serializer.INSTANCE; } } ``` ## Testing - new test - snippet above doesn't produce the error anymore ## Release Notes ### Fixes - Desktop Fix `runRelease` task when navigation and `obfuscate.set(true)` are used		4 months ago
..
buildSrc	Add gradle "8.6" and AGP "7.3.1", "8.2.2" to the gradle plugin integration tests (#4309 )	2 years ago
compose	Fix `runRelease` task when navigation and `obfuscate.set(true)` are used (#5384 )	4 months ago
gradle	Replace `KotlinPlatformType` check with `KotlinJvmTarget` in JVM target configuration. (#5330 )	6 months ago
jdk-version-probe	Raise error when Homebrew JDK is used for packaging (#3451 )	2 years ago
preview-rpc	CMP-6806 fix warnings and deprecations	1 year ago
.gitignore	Refactor gradle-plugin build configuration to allow other plugins	5 years ago
README.md	Rename JetPack -> JetBrains	5 years ago
build.gradle.kts	Configure compose resources in XCFrameworks.	8 months ago
gradle.properties	Introduce public API for clearing internal resource caches (#5341 )	6 months ago
gradlew	[gradle] Update Kotlin to 2.0 (#5043 )	1 year ago
gradlew.bat	[gradle] Update Kotlin to 2.0 (#5043 )	1 year ago
settings.gradle.kts	Improve error messages when checking tasks (#3194 )	3 years ago

README.md

JetBrains Compose gradle plugin for easy configuration

Environment variables:

COMPOSE_GRADLE_PLUGIN_VERSION - version of plugin
COMPOSE_GRADLE_PLUGIN_COMPOSE_VERSION - version of JetBrains Compose used by the plugin