Browse Source

improving code efficiency

SM-1548-SecretViewSlow
cd-bitwarden 4 months ago
parent
commit
ed2d66144a
  1. 9
      bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/SecretRepository.cs

9
bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/SecretRepository.cs

@ -50,8 +50,10 @@ public class SecretRepository : Repository<Core.SecretsManager.Entities.Secret,
{ {
await using var scope = ServiceScopeFactory.CreateAsyncScope(); await using var scope = ServiceScopeFactory.CreateAsyncScope();
var dbContext = GetDatabaseContext(scope); var dbContext = GetDatabaseContext(scope);
var query = dbContext.Secret.Where(c => c.OrganizationId == organizationId && c.DeletedDate == null); IQueryable<Secret> query = dbContext.Secret
query.Include(c => c.Projects); .Where(c => c.OrganizationId == organizationId && c.DeletedDate == null)
.Include(c => c.Projects);
query = accessType switch query = accessType switch
{ {
AccessClientType.NoAccessCheck => query, AccessClientType.NoAccessCheck => query,
@ -129,7 +131,8 @@ public class SecretRepository : Repository<Core.SecretsManager.Entities.Secret,
using var scope = ServiceScopeFactory.CreateScope(); using var scope = ServiceScopeFactory.CreateScope();
var dbContext = GetDatabaseContext(scope); var dbContext = GetDatabaseContext(scope);
var query = dbContext.Secret.Where(s => s.Projects.Any(p => p.Id == projectId) && s.DeletedDate == null) var query = dbContext.Secret.Where(s => s.Projects.Any(p => p.Id == projectId) && s.DeletedDate == null)
.Include(s => s.Projects); .Include(s => s.Projects)
;
var secrets = SecretToPermissionDetails(query, userId, accessType); var secrets = SecretToPermissionDetails(query, userId, accessType);

Loading…
Cancel
Save