diff --git a/src/Api/AdminConsole/Controllers/GroupsController.cs b/src/Api/AdminConsole/Controllers/GroupsController.cs index 9b66af7dd5..d7a56f0ca2 100644 --- a/src/Api/AdminConsole/Controllers/GroupsController.cs +++ b/src/Api/AdminConsole/Controllers/GroupsController.cs @@ -1,5 +1,4 @@ -using Api.AdminConsole.Queries; -using Bit.Api.AdminConsole.Models.Request; +using Bit.Api.AdminConsole.Models.Request; using Bit.Api.AdminConsole.Models.Response; using Bit.Api.Models.Response; using Bit.Api.Utilities; @@ -7,6 +6,7 @@ using Bit.Api.Vault.AuthorizationHandlers.Collections; using Bit.Api.Vault.AuthorizationHandlers.Groups; using Bit.Core; using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Interfaces; +using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Requests; using Bit.Core.AdminConsole.Repositories; using Bit.Core.AdminConsole.Services; using Bit.Core.Context; diff --git a/src/Api/AdminConsole/Queries/IGroupDetailsQuery.cs b/src/Api/AdminConsole/Queries/IGroupDetailsQuery.cs deleted file mode 100644 index e81b4d4a6a..0000000000 --- a/src/Api/AdminConsole/Queries/IGroupDetailsQuery.cs +++ /dev/null @@ -1,6 +0,0 @@ -namespace Api.AdminConsole.Queries; - -public interface IGroupDetailsQuery -{ - Task> GetGroupDetails(GroupDetailsQueryRequest request); -} diff --git a/src/Api/Startup.cs b/src/Api/Startup.cs index 48a16b2c8a..8a7721bcbf 100644 --- a/src/Api/Startup.cs +++ b/src/Api/Startup.cs @@ -32,7 +32,6 @@ using Bit.Core.Tools.Entities; using Bit.Core.Vault.Entities; using Bit.Api.Auth.Models.Request.WebAuthn; using Bit.Core.Auth.Models.Data; -using Api.AdminConsole.Queries; #if !OSS @@ -178,9 +177,6 @@ public class Startup services.AddCoreLocalizationServices(); services.AddBillingOperations(); - // Queries - services.AddScoped(); - // Authorization Handlers services.AddAuthorizationHandlers(); diff --git a/src/Api/AdminConsole/Queries/GroupDetailsQuery.cs b/src/Core/AdminConsole/OrganizationFeatures/Groups/GroupDetailsQuery.cs similarity index 86% rename from src/Api/AdminConsole/Queries/GroupDetailsQuery.cs rename to src/Core/AdminConsole/OrganizationFeatures/Groups/GroupDetailsQuery.cs index 1eeb0e1d36..336934d759 100644 --- a/src/Api/AdminConsole/Queries/GroupDetailsQuery.cs +++ b/src/Core/AdminConsole/OrganizationFeatures/Groups/GroupDetailsQuery.cs @@ -1,22 +1,11 @@ -using Bit.Core.AdminConsole.Entities; +using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Interfaces; +using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Requests; +using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Responses; using Bit.Core.AdminConsole.Repositories; using Bit.Core.Context; using Bit.Core.Exceptions; -using Bit.Core.Models.Data; -namespace Api.AdminConsole.Queries; - -public class GroupDetailsQueryRequest -{ - public Guid OrganizationId { get; set; } - public Guid? GroupId { get; set; } -} - -public class GroupDetailsQueryResponse -{ - public Group Group { get; set; } - public IEnumerable CollectionAccessSelection { get; set; } -} +namespace Bit.Core.AdminConsole.OrganizationFeatures.Groups; public class GroupDetailsQuery : IGroupDetailsQuery { diff --git a/src/Core/AdminConsole/OrganizationFeatures/Groups/Interfaces/IGroupDetailsQuery.cs b/src/Core/AdminConsole/OrganizationFeatures/Groups/Interfaces/IGroupDetailsQuery.cs new file mode 100644 index 0000000000..0b0876900e --- /dev/null +++ b/src/Core/AdminConsole/OrganizationFeatures/Groups/Interfaces/IGroupDetailsQuery.cs @@ -0,0 +1,9 @@ +using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Requests; +using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Responses; + +namespace Bit.Core.AdminConsole.OrganizationFeatures.Groups.Interfaces; + +public interface IGroupDetailsQuery +{ + Task> GetGroupDetails(GroupDetailsQueryRequest request); +} diff --git a/src/Core/AdminConsole/OrganizationFeatures/Groups/Requests/GroupDetailsQueryRequest.cs b/src/Core/AdminConsole/OrganizationFeatures/Groups/Requests/GroupDetailsQueryRequest.cs new file mode 100644 index 0000000000..767305dafc --- /dev/null +++ b/src/Core/AdminConsole/OrganizationFeatures/Groups/Requests/GroupDetailsQueryRequest.cs @@ -0,0 +1,7 @@ +namespace Bit.Core.AdminConsole.OrganizationFeatures.Groups.Requests; + +public class GroupDetailsQueryRequest +{ + public Guid OrganizationId { get; set; } + public Guid? GroupId { get; set; } +} diff --git a/src/Core/AdminConsole/OrganizationFeatures/Groups/Responses/GroupDetailsQueryResponse.cs b/src/Core/AdminConsole/OrganizationFeatures/Groups/Responses/GroupDetailsQueryResponse.cs new file mode 100644 index 0000000000..6a61b88aa6 --- /dev/null +++ b/src/Core/AdminConsole/OrganizationFeatures/Groups/Responses/GroupDetailsQueryResponse.cs @@ -0,0 +1,10 @@ +using Bit.Core.AdminConsole.Entities; +using Bit.Core.Models.Data; + +namespace Bit.Core.AdminConsole.OrganizationFeatures.Groups.Responses; + +public class GroupDetailsQueryResponse +{ + public Group Group { get; set; } + public IEnumerable CollectionAccessSelection { get; set; } +} diff --git a/src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs b/src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs index daf5caf000..396dfe1623 100644 --- a/src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs +++ b/src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs @@ -109,6 +109,7 @@ public static class OrganizationServiceCollectionExtensions services.AddScoped(); services.AddScoped(); services.AddScoped(); + services.AddScoped(); } private static void AddOrganizationLicenseCommandsQueries(this IServiceCollection services)