Browse Source

Refactor WebAuthn IoC container (#1302)

* Refactor WebAuthn IoC container

* Move to AddDefaultServices
pull/1312/head
Oscar Hinton 5 years ago committed by GitHub
parent
commit
cae204cb7c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 9
      bitwarden_license/src/Portal/Startup.cs
  2. 9
      bitwarden_license/src/Sso/Startup.cs
  3. 9
      src/Admin/Startup.cs
  4. 9
      src/Api/Startup.cs
  5. 9
      src/Billing/Startup.cs
  6. 14
      src/Core/Utilities/ServiceCollectionExtensions.cs
  7. 9
      src/Identity/Startup.cs

9
bitwarden_license/src/Portal/Startup.cs

@ -61,15 +61,6 @@ namespace Bit.Portal @@ -61,15 +61,6 @@ namespace Bit.Portal
services.AddDefaultServices(globalSettings);
services.AddCoreLocalizationServices();
// Fido2
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
// Mvc
services.AddControllersWithViews()
.AddViewAndDataAnnotationLocalization();

9
bitwarden_license/src/Sso/Startup.cs

@ -59,15 +59,6 @@ namespace Bit.Sso @@ -59,15 +59,6 @@ namespace Bit.Sso
});
}
// Fido2
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
// Authentication
services.AddDistributedIdentityServices(globalSettings);
services.AddAuthentication()

9
src/Admin/Startup.cs

@ -66,15 +66,6 @@ namespace Bit.Admin @@ -66,15 +66,6 @@ namespace Bit.Admin
services.AddBaseServices();
services.AddDefaultServices(globalSettings);
// Fido2
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
// Mvc
services.AddMvc(config =>
{

9
src/Api/Startup.cs

@ -119,15 +119,6 @@ namespace Bit.Api @@ -119,15 +119,6 @@ namespace Bit.Api
services.AddDefaultServices(globalSettings);
services.AddCoreLocalizationServices();
// Fido2
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
// MVC
services.AddMvc(config =>
{

9
src/Billing/Startup.cs

@ -49,15 +49,6 @@ namespace Bit.Billing @@ -49,15 +49,6 @@ namespace Bit.Billing
// Context
services.AddScoped<ICurrentContext, CurrentContext>();
// Fido2
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
// Identity
services.AddCustomIdentityServices(globalSettings);
//services.AddPasswordlessIdentityServices<ReadOnlyDatabaseIdentityUserStore>(globalSettings);

14
src/Core/Utilities/ServiceCollectionExtensions.cs

@ -126,6 +126,9 @@ namespace Bit.Core.Utilities @@ -126,6 +126,9 @@ namespace Bit.Core.Utilities
public static void AddDefaultServices(this IServiceCollection services, GlobalSettings globalSettings)
{
// Required for UserService
services.AddWebAuthn(globalSettings);
services.AddSingleton<IPaymentService, StripePaymentService>();
services.AddSingleton<IMailService, HandlebarsMailService>();
services.AddSingleton<ILicensingService, LicensingService>();
@ -535,5 +538,16 @@ namespace Bit.Core.Utilities @@ -535,5 +538,16 @@ namespace Bit.Core.Utilities
return services;
}
public static void AddWebAuthn(this IServiceCollection services, GlobalSettings globalSettings)
{
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
}
}
}

9
src/Identity/Startup.cs

@ -56,15 +56,6 @@ namespace Bit.Identity @@ -56,15 +56,6 @@ namespace Bit.Identity
// Caching
services.AddMemoryCache();
// Fido2
services.AddFido2(options =>
{
options.ServerDomain = new Uri(globalSettings.BaseServiceUri.Vault).Host;
options.ServerName = "Bitwarden";
options.Origin = globalSettings.BaseServiceUri.Vault;
options.TimestampDriftTolerance = 300000;
});
// Mvc
services.AddMvc();

Loading…
Cancel
Save