Remove Secrets Manager LaunchDarkly feature flag (#2925)

src/Core/Constants.cs

@@ -27,7 +27,6 @@ public static class AuthenticationSchemes
 
 public static class FeatureFlagKeys
 {
-    public const string SecretsManager = "secrets-manager";
     public const string DisplayEuEnvironment = "display-eu-environment";
     public const string DisplayLowKdfIterationWarning = "display-kdf-iteration-warning";
     public const string TrustedDeviceEncryption = "trusted-device-encryption";

test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs

@@ -47,7 +47,7 @@ public class LaunchDarklyFeatureServiceTests
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.False(sutProvider.Sut.IsEnabled(FeatureFlagKeys.SecretsManager, currentContext));
+        Assert.False(sutProvider.Sut.IsEnabled("somekey", currentContext));
     }
 
     [Fact(Skip = "For local development")]
@@ -61,7 +61,7 @@ public class LaunchDarklyFeatureServiceTests
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.False(sutProvider.Sut.IsEnabled(FeatureFlagKeys.SecretsManager, currentContext));
+        Assert.False(sutProvider.Sut.IsEnabled("somekey", currentContext));
     }
 
     [Fact(Skip = "For local development")]
@@ -75,7 +75,7 @@ public class LaunchDarklyFeatureServiceTests
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.Equal(0, sutProvider.Sut.GetIntVariation(FeatureFlagKeys.SecretsManager, currentContext));
+        Assert.Equal(0, sutProvider.Sut.GetIntVariation("somekey", currentContext));
     }
 
     [Fact(Skip = "For local development")]
@@ -89,7 +89,7 @@ public class LaunchDarklyFeatureServiceTests
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.Null(sutProvider.Sut.GetStringVariation(FeatureFlagKeys.SecretsManager, currentContext));
+        Assert.Null(sutProvider.Sut.GetStringVariation("somekey", currentContext));
     }
 
     [Fact(Skip = "For local development")]