Fix failing tests (#2095)

src/Core/Utilities/JsonHelpers.cs

@@ -1,4 +1,5 @@
-using System.Text.Json;
+using System.Globalization;
+using System.Text.Json;
 using System.Text.Json.Serialization;
 using NS = Newtonsoft.Json;
 
@@ -140,14 +141,15 @@ namespace Bit.Core.Utilities
     /// </summary>
     public class PermissiveStringConverter : JsonConverter<string>
     {
-        internal static PermissiveStringConverter Instance = new();
+        internal static readonly PermissiveStringConverter Instance = new();
+        private static readonly CultureInfo _cultureInfo = new("en-US");
 
         public override string Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             return reader.TokenType switch
             {
                 JsonTokenType.String => reader.GetString(),
-                JsonTokenType.Number => reader.GetDecimal().ToString(),
+                JsonTokenType.Number => reader.GetDecimal().ToString(_cultureInfo),
                 JsonTokenType.True => bool.TrueString,
                 JsonTokenType.False => bool.FalseString,
                 _ => throw new JsonException($"Unsupported TokenType: {reader.TokenType}"),

test/Core.Test/Utilities/PermissiveStringConverterTests.cs

@@ -1,4 +1,5 @@
-using System.Text.Json;
+using System.Globalization;
+using System.Text.Json;
 using System.Text.Json.Serialization;
 using Bit.Core.Utilities;
 using Bit.Test.Common.Helpers;
@@ -41,6 +42,17 @@ namespace Bit.Core.Test.Utilities
             Assert.Equal("1.2", obj.EnumerableStringProp.ElementAt(1));
         }
 
+        [Fact]
+        public void Read_Float_Success_Culture()
+        {
+            var ci = new CultureInfo("sv-SE");
+            Thread.CurrentThread.CurrentCulture = ci;
+            Thread.CurrentThread.CurrentUICulture = ci;
+
+            var obj = JsonSerializer.Deserialize<TestObject>(boolJson);
+            Assert.Equal("1.2", obj.EnumerableStringProp.ElementAt(1));
+        }
+
         [Fact]
         public void Read_BigNumbers_Success()
         {

test/Identity.IntegrationTest/Endpoints/IdentityServerTests.cs

@@ -418,13 +418,10 @@ namespace Bit.Identity.IntegrationTest.Endpoints
                 tasks[i] = MakeRequest();
             }
 
-            var responses = await Task.WhenAll(tasks);
+            var responses = (await Task.WhenAll(tasks)).ToList();
 
-            var allowedCalls = responses[..AmountInOneSecondAllowed];
-            var notAllowedCall = responses[^1];
-
-            Assert.True(allowedCalls.All(c => c.Response.StatusCode == StatusCodes.Status200OK));
-            Assert.True(notAllowedCall.Response.StatusCode == StatusCodes.Status429TooManyRequests);
+            Assert.Equal(5, responses.Count(c => c.Response.StatusCode == StatusCodes.Status200OK));
+            Assert.Equal(1, responses.Count(c => c.Response.StatusCode == StatusCodes.Status429TooManyRequests));
 
             Task<HttpContext> MakeRequest()
             {