Use all organization memberships for LaunchDarkly user context, better separate context kinds (#2807)

* Use all organization memberships for LaunchDarkly context

* Use simpler null check

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Remove unnecessary interpolation

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Remove unnecessary interpolation

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Fully spell out organizations

* Use client type for context separation decisions

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

src/Core/Services/Implementations/LaunchDarklyFeatureService.cs

@@ -104,18 +104,42 @@ public class LaunchDarklyFeatureService : IFeatureService, IDisposable
     {
         var builder = LaunchDarkly.Sdk.Context.MultiBuilder();
 
-        if (currentContext.UserId.HasValue)
+        switch (currentContext.ClientType)
         {
-            var user = LaunchDarkly.Sdk.Context.Builder(currentContext.UserId.Value.ToString());
+            case Identity.ClientType.User:
-            user.Kind(LaunchDarkly.Sdk.ContextKind.Default);
+                {
-            builder.Add(user.Build());
+                    var ldUser = LaunchDarkly.Sdk.Context.Builder(currentContext.UserId.Value.ToString());
-        }
+                    ldUser.Kind(LaunchDarkly.Sdk.ContextKind.Default);
 
-        if (currentContext.OrganizationId.HasValue)
+                    if (currentContext.Organizations?.Any() ?? false)
-        {
+                    {
-            var org = LaunchDarkly.Sdk.Context.Builder(currentContext.OrganizationId.Value.ToString());
+                        var ldOrgs = currentContext.Organizations.Select(o => LaunchDarkly.Sdk.LdValue.Of(o.Id.ToString()));
-            org.Kind("org");
+                        ldUser.Set("organizations", LaunchDarkly.Sdk.LdValue.ArrayFrom(ldOrgs));
-            builder.Add(org.Build());
+                    }
+
+                    builder.Add(ldUser.Build());
+                }
+                break;
+
+            case Identity.ClientType.Organization:
+                {
+                    var ldOrg = LaunchDarkly.Sdk.Context.Builder(currentContext.OrganizationId.Value.ToString());
+                    ldOrg.Kind("organization");
+                    builder.Add(ldOrg.Build());
+                }
+                break;
+
+            case Identity.ClientType.ServiceAccount:
+                {
+                    var ldServiceAccount = LaunchDarkly.Sdk.Context.Builder(currentContext.UserId.Value.ToString());
+                    ldServiceAccount.Kind("service-account");
+                    builder.Add(ldServiceAccount.Build());
+
+                    var ldOrg = LaunchDarkly.Sdk.Context.Builder(currentContext.OrganizationId.Value.ToString());
+                    ldOrg.Kind("organization");
+                    builder.Add(ldOrg.Build());
+                }
+                break;
         }
 
         return builder.Build();

test/Api.IntegrationTest/Controllers/ConfigControllerTests.cs

@@ -1,30 +1,79 @@
 using System.Net.Http.Headers;
 using Bit.Api.IntegrationTest.Factories;
+using Bit.Api.IntegrationTest.Helpers;
 using Bit.Api.Models.Response;
+using Bit.Core.Entities;
 using Xunit;
 
 namespace Bit.Api.IntegrationTest.Controllers;
 
-public class ConfigControllerTests : IClassFixture<ApiApplicationFactory>
+public class ConfigControllerTests : IClassFixture<ApiApplicationFactory>, IAsyncLifetime
 {
+    private readonly HttpClient _client;
     private readonly ApiApplicationFactory _factory;
 
-    public ConfigControllerTests(ApiApplicationFactory factory) => _factory = factory;
+    private string _email = null!;
+
+    public ConfigControllerTests(ApiApplicationFactory factory)
+    {
+        _factory = factory;
+        _client = _factory.CreateClient();
+    }
+
+    public async Task InitializeAsync()
+    {
+        _email = $"integration-test{Guid.NewGuid()}@bitwarden.com";
+
+        var tokens = await _factory.LoginWithNewAccount(_email);
+        _client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", tokens.Token);
+    }
+
+    public Task DisposeAsync()
+    {
+        _client.Dispose();
+        return Task.CompletedTask;
+    }
+
+    private async Task LoginAsync()
+    {
+        var tokens = await _factory.LoginAsync(_email);
+        _client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", tokens.Token);
+    }
 
     [Fact]
     public async Task GetConfigs()
     {
-        var tokens = await _factory.LoginWithNewAccount();
+        var response = await _client.GetAsync("/config");
-        var client = _factory.CreateClient();
+        response.EnsureSuccessStatusCode();
+        var result = await response.Content.ReadFromJsonAsync<ConfigResponseModel>();
+
+        Assert.NotNull(result);
+        Assert.NotEmpty(result!.Version);
+    }
+
+    [Theory]
+    [InlineData(1)]
+    [InlineData(3)]
+    public async Task GetConfigs_WithOrganizations(int orgCount)
+    {
+        for (var i = 0; i < orgCount; i++)
+        {
+            var ownerEmail = $"integration-test{Guid.NewGuid()}@bitwarden.com";
+            await _factory.LoginWithNewAccount(ownerEmail);
 
-        using var message = new HttpRequestMessage(HttpMethod.Get, "/config");
+            Organization org;
-        message.Headers.Authorization = new AuthenticationHeaderValue("Bearer", tokens.Token);
+            (org, _) = await OrganizationTestHelpers.SignUpAsync(_factory, plan: Core.Enums.PlanType.Free, ownerEmail: ownerEmail,
-        var response = await client.SendAsync(message);
+                name: i.ToString(), billingEmail: ownerEmail, ownerKey: i.ToString());
+            await OrganizationTestHelpers.CreateUserAsync(_factory, org.Id, _email, Core.Enums.OrganizationUserType.User);
+        }
 
-        response.EnsureSuccessStatusCode();
+        await LoginAsync();
 
-        var content = await response.Content.ReadFromJsonAsync<ConfigResponseModel>();
+        var response = await _client.GetAsync("/config");
+        response.EnsureSuccessStatusCode();
+        var result = await response.Content.ReadFromJsonAsync<ConfigResponseModel>();
 
-        Assert.NotEmpty(content!.Version);
+        Assert.NotNull(result);
+        Assert.NotEmpty(result!.Version);
     }
 }