remove re-throws of exceptions, which clear the stack trace (#1760)

* remove re-throws of exceptions, which clear the stack trace

* remove whitespace

src/Admin/HostedServices/DatabaseMigrationHostedService.cs

@@ -46,7 +46,7 @@ namespace Bit.Admin.HostedServices
                     if (i >= maxMigrationAttempts)
                     {
                         _logger.LogError(e, "Database failed to migrate.");
-                        throw e;
+                        throw;
                     }
                     else
                     {

src/Billing/Controllers/StripeController.cs

@@ -603,7 +603,7 @@ namespace Bit.Billing.Controllers
                 }
                 else
                 {
-                    throw e;
+                    throw;
                 }
             }
 
@@ -698,7 +698,7 @@ namespace Bit.Billing.Controllers
                 }
                 else
                 {
-                    throw e;
+                    throw;
                 }
             }
 

src/Core/Repositories/TableStorage/InstallationDeviceRepository.cs

@@ -79,12 +79,9 @@ namespace Bit.Core.Repositories.TableStorage
                 entity.ETag = "*";
                 await _table.ExecuteAsync(TableOperation.Delete(entity));
             }
-            catch (StorageException e)
+            catch (StorageException e) when (e.RequestInformation.HttpStatusCode != (int)HttpStatusCode.NotFound)
             {
-                if (e.RequestInformation.HttpStatusCode != (int)HttpStatusCode.NotFound)
+                throw;
-                {
-                    throw e;
-                }
             }
         }
     }

src/Core/Repositories/TableStorage/MetaDataRepository.cs

@@ -88,12 +88,9 @@ namespace Bit.Core.Repositories.TableStorage
                     ETag = "*"
                 }));
             }
-            catch (StorageException e)
+            catch (StorageException e) when (e.RequestInformation.HttpStatusCode != (int)HttpStatusCode.NotFound)
             {
-                if (e.RequestInformation.HttpStatusCode != (int)HttpStatusCode.NotFound)
+                throw;
-                {
-                    throw e;
-                }
             }
         }
     }

src/Core/Services/Implementations/AmazonSesMailDeliveryService.cs

@@ -130,7 +130,7 @@ namespace Bit.Core.Services
             {
                 _logger.LogWarning(e, "Failed to send email. Retrying...");
                 await SendAsync(request, true);
-                throw e;
+                throw;
             }
         }
 

src/Core/Services/Implementations/NotificationHubPushRegistrationService.cs

@@ -133,12 +133,9 @@ namespace Bit.Core.Services
                     await _installationDeviceRepository.DeleteAsync(new InstallationDeviceEntity(deviceId));
                 }
             }
-            catch (Exception e)
+            catch (Exception e) when (e.InnerException == null || !e.InnerException.Message.Contains("(404) Not Found"))
             {
-                if (e.InnerException == null || !e.InnerException.Message.Contains("(404) Not Found"))
+                throw;
-                {
-                    throw e;
-                }
             }
         }
 
@@ -192,12 +189,9 @@ namespace Bit.Core.Services
                 {
                     await _client.PatchInstallationAsync(id, new List<PartialUpdateOperation> { operation });
                 }
-                catch (Exception e)
+                catch (Exception e) when (e.InnerException == null || !e.InnerException.Message.Contains("(404) Not Found"))
                 {
-                    if (e.InnerException == null || !e.InnerException.Message.Contains("(404) Not Found"))
+                    throw;
-                    {
-                        throw e;
-                    }
                 }
             }
         }

src/Core/Services/Implementations/StripePaymentService.cs

@@ -171,7 +171,7 @@ namespace Bit.Core.Services
                 {
                     await _btGateway.Customer.DeleteAsync(braintreeCustomer.Id);
                 }
-                throw e;
+                throw;
             }
 
             org.Gateway = GatewayType.Stripe;
@@ -367,7 +367,7 @@ namespace Bit.Core.Services
                         var message = e.Message.ToLowerInvariant();
                         if (message.Contains("apple") || message.Contains("in-app"))
                         {
-                            throw e;
+                            throw;
                         }
                     }
                 }
@@ -692,7 +692,7 @@ namespace Bit.Core.Services
                     throw new GatewayException("Bank account is not yet verified.");
                 }
 
-                throw e;
+                throw;
             }
         }
 
@@ -1105,7 +1105,7 @@ namespace Bit.Core.Services
             {
                 if (e.Message != $"No such subscription: {subscriber.GatewaySubscriptionId}")
                 {
-                    throw e;
+                    throw;
                 }
             }
         }
@@ -1408,13 +1408,13 @@ namespace Bit.Core.Services
                     });
                 }
             }
-            catch (Exception e)
+            catch
             {
                 if (braintreeCustomer != null && !hadBtCustomer)
                 {
                     await _btGateway.Customer.DeleteAsync(braintreeCustomer.Id);
                 }
-                throw e;
+                throw;
             }
 
             return createdCustomer;

util/Setup/Program.cs

@@ -213,7 +213,7 @@ namespace Bit.Setup
                     MigrateDatabase(nextAttempt);
                     return;
                 }
-                throw e;
+                throw;
             }
         }