Amy Galles
2 months ago
committed by
GitHub
9 changed files with 146 additions and 34 deletions
@ -0,0 +1,9 @@
@@ -0,0 +1,9 @@
|
||||
# Bitwarden Key Connector |
||||
|
||||
## References |
||||
|
||||
- [Architectural Decision Records (ADRs)](https://contributing.bitwarden.com/architecture/adr/) |
||||
- [Contributing Guidelines](https://contributing.bitwarden.com/contributing/) |
||||
- [Code Style](https://contributing.bitwarden.com/contributing/code-style/) |
||||
- [Security Whitepaper](https://bitwarden.com/help/bitwarden-security-white-paper/) |
||||
- [Security Definitions](https://contributing.bitwarden.com/architecture/security/definitions) |
||||
@ -0,0 +1,27 @@
@@ -0,0 +1,27 @@
|
||||
Please review this pull request with a focus on: |
||||
|
||||
- Code quality and best practices |
||||
- Potential bugs or issues |
||||
- Security implications |
||||
- Performance considerations |
||||
|
||||
Note: The PR branch is already checked out in the current working directory. |
||||
|
||||
Provide a comprehensive review including: |
||||
|
||||
- Summary of changes since last review |
||||
- Critical issues found (be thorough) |
||||
- Suggested improvements (be thorough) |
||||
- Good practices observed (be concise - list only the most notable items without elaboration) |
||||
- Action items for the author |
||||
- Leverage collapsible <details> sections where appropriate for lengthy explanations or code |
||||
snippets to enhance human readability |
||||
|
||||
When reviewing subsequent commits: |
||||
|
||||
- Track status of previously identified issues (fixed/unfixed/reopened) |
||||
- Identify NEW problems introduced since last review |
||||
- Note if fixes introduced new issues |
||||
|
||||
IMPORTANT: Be comprehensive about issues and improvements. For good practices, be brief - just note |
||||
what was done well without explaining why or praising excessively. |
||||
@ -1,23 +0,0 @@
@@ -1,23 +0,0 @@
|
||||
{ |
||||
"$schema": "https://docs.renovatebot.com/renovate-schema.json", |
||||
"extends": ["github>bitwarden/renovate-config"], |
||||
"enabledManagers": ["dockerfile", "github-actions", "nuget"], |
||||
"packageRules": [ |
||||
{ |
||||
"groupName": "dockerfile minor", |
||||
"matchManagers": ["dockerfile"], |
||||
"matchUpdateTypes": ["minor", "patch"] |
||||
}, |
||||
{ |
||||
"groupName": "gh minor", |
||||
"matchManagers": ["github-actions"], |
||||
"matchUpdateTypes": ["minor", "patch"] |
||||
}, |
||||
{ |
||||
"groupName": "nuget minor", |
||||
"matchManagers": ["nuget"], |
||||
"matchUpdateTypes": ["minor", "patch"] |
||||
} |
||||
], |
||||
"ignoreDeps": ["dotnet-sdk"] |
||||
} |
||||
@ -0,0 +1,55 @@
@@ -0,0 +1,55 @@
|
||||
{ |
||||
$schema: "https://docs.renovatebot.com/renovate-schema.json", |
||||
extends: ["github>bitwarden/renovate-config"], |
||||
enabledManagers: ["dockerfile", "github-actions", "nuget"], |
||||
packageRules: [ |
||||
{ |
||||
groupName: "dockerfile minor", |
||||
matchManagers: ["dockerfile"], |
||||
matchUpdateTypes: ["minor", "patch"] |
||||
}, |
||||
{ |
||||
groupName: "gh minor", |
||||
matchManagers: ["github-actions"], |
||||
matchUpdateTypes: ["minor", "patch"] |
||||
}, |
||||
// nuget groups |
||||
{ |
||||
groupName: "Entity Framework Core", |
||||
matchPackageNames: ["/\\.EntityFrameworkCore\\./", "/^dotnet-ef/"], |
||||
matchUpdateTypes: ["minor", "patch"] |
||||
}, |
||||
{ |
||||
groupName: "Testing", |
||||
matchPackageNames: [ |
||||
"coverlet.collector", |
||||
"Microsoft.NET.Test.Sdk", |
||||
"NSubstitute", |
||||
"xunit", |
||||
"xunit.runner.visualstudio" |
||||
], |
||||
matchUpdateTypes: ["minor", "patch"] |
||||
}, |
||||
{ |
||||
groupName: "Serilog", |
||||
matchPackageNames: ["/^Serilog\\./"], |
||||
matchUpdateTypes: ["minor", "patch"] |
||||
}, |
||||
{ |
||||
groupName: "nuget minor", |
||||
matchManagers: ["nuget"], |
||||
matchUpdateTypes: ["minor", "patch"] |
||||
}, |
||||
// Ignore major updates that require newer .NET SDK versions |
||||
{ |
||||
matchPackageNames: [ |
||||
"/\\.EntityFrameworkCore\\./", |
||||
"/^dotnet-ef/", |
||||
"/^Serilog\\./" |
||||
], |
||||
matchUpdateTypes: ["major"], |
||||
enabled: false |
||||
} |
||||
], |
||||
ignoreDeps: ["dotnet-sdk"] |
||||
} |
||||
@ -0,0 +1,28 @@
@@ -0,0 +1,28 @@
|
||||
name: Respond |
||||
|
||||
on: |
||||
issue_comment: |
||||
types: [created] |
||||
pull_request_review_comment: |
||||
types: [created] |
||||
issues: |
||||
types: [opened, assigned] |
||||
pull_request_review: |
||||
types: [submitted] |
||||
|
||||
permissions: {} |
||||
|
||||
jobs: |
||||
respond: |
||||
name: Respond |
||||
uses: bitwarden/gh-actions/.github/workflows/_respond.yml@main |
||||
secrets: |
||||
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }} |
||||
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }} |
||||
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }} |
||||
permissions: |
||||
actions: read |
||||
contents: write |
||||
id-token: write |
||||
issues: write |
||||
pull-requests: write |
||||
@ -0,0 +1,20 @@
@@ -0,0 +1,20 @@
|
||||
name: Code Review |
||||
|
||||
on: |
||||
pull_request: |
||||
types: [opened, synchronize, reopened, ready_for_review] |
||||
|
||||
permissions: {} |
||||
|
||||
jobs: |
||||
review: |
||||
name: Review |
||||
uses: bitwarden/gh-actions/.github/workflows/_review-code.yml@main |
||||
secrets: |
||||
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }} |
||||
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }} |
||||
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }} |
||||
permissions: |
||||
contents: read |
||||
id-token: write |
||||
pull-requests: write |
||||
Loading…
Reference in new issue