Browse Source

Update gui builds to use nvmrc (#838)

- use .nvmrc node version in GUI build jobs (matches CLI build jobs)
- has the effect of upgrading from node 18 -> 20 in these jobs
(but note Electron uses its own version of node not this one)
pull/780/head
Thomas Rittson 5 months ago committed by GitHub
parent
commit
926202f80a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 9
      .github/workflows/build.yml
  2. 2
      .github/workflows/integration-test.yml

9
.github/workflows/build.yml

@ -267,6 +267,7 @@ jobs:
env: env:
NODE_OPTIONS: --max_old_space_size=4096 NODE_OPTIONS: --max_old_space_size=4096
_PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
_NODE_VERSION: ${{ needs.setup.outputs.node_version }}
HUSKY: 0 HUSKY: 0
steps: steps:
- name: Checkout repo - name: Checkout repo
@ -277,7 +278,7 @@ jobs:
with: with:
cache: 'npm' cache: 'npm'
cache-dependency-path: '**/package-lock.json' cache-dependency-path: '**/package-lock.json'
node-version: '18' node-version: ${{ env._NODE_VERSION }}
- name: Update NPM - name: Update NPM
run: | run: |
@ -364,6 +365,7 @@ jobs:
env: env:
NODE_OPTIONS: --max_old_space_size=4096 NODE_OPTIONS: --max_old_space_size=4096
_PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
_NODE_VERSION: ${{ needs.setup.outputs.node_version }}
HUSKY: 0 HUSKY: 0
steps: steps:
- name: Checkout repo - name: Checkout repo
@ -374,7 +376,7 @@ jobs:
with: with:
cache: 'npm' cache: 'npm'
cache-dependency-path: '**/package-lock.json' cache-dependency-path: '**/package-lock.json'
node-version: '18' node-version: ${{ env._NODE_VERSION }}
- name: Update NPM - name: Update NPM
run: | run: |
@ -421,6 +423,7 @@ jobs:
env: env:
NODE_OPTIONS: --max_old_space_size=4096 NODE_OPTIONS: --max_old_space_size=4096
_PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
_NODE_VERSION: ${{ needs.setup.outputs.node_version }}
HUSKY: 0 HUSKY: 0
steps: steps:
- name: Checkout repo - name: Checkout repo
@ -431,7 +434,7 @@ jobs:
with: with:
cache: 'npm' cache: 'npm'
cache-dependency-path: '**/package-lock.json' cache-dependency-path: '**/package-lock.json'
node-version: '18' node-version: ${{ env._NODE_VERSION }}
- name: Update NPM - name: Update NPM
run: | run: |

2
.github/workflows/integration-test.yml

@ -10,12 +10,14 @@ on:
- "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment - "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment
- "./openldap/**/*" # any change to test fixtures - "./openldap/**/*" # any change to test fixtures
- "./docker-compose.yml" # any change to Docker configuration - "./docker-compose.yml" # any change to Docker configuration
- "./package.json" # dependencies
pull_request: pull_request:
paths: paths:
- ".github/workflows/integration-test.yml" # this file - ".github/workflows/integration-test.yml" # this file
- "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment - "src/services/ldap-directory.service*" # we only have integration for LDAP testing at the moment
- "./openldap/**/*" # any change to test fixtures - "./openldap/**/*" # any change to test fixtures
- "./docker-compose.yml" # any change to Docker configuration - "./docker-compose.yml" # any change to Docker configuration
- "./package.json" # dependencies
permissions: permissions:
contents: read contents: read
checks: write # required by dorny/test-reporter to upload its results checks: write # required by dorny/test-reporter to upload its results

Loading…
Cancel
Save