clients

Commit Graph

Author	SHA1	Message	Date
Addison Beck	ccd715d7b8	[Bug] [Account Switching] Improve State Management Performance (#611 ) * [bug] Improve state management performance Large vaults see a clear degrade in performance using the state service, especially when multiple vaults are authed and unlocked at the same time. Some changes made to address this: 1. Clearing in memory decrypted data for non active accounts. This really should have been something we were doing anyway, but letting go of that memory burden has a noticable performance boost. 2. Not loading a bunch of unecsassary data from disk accounts into memory on application startup. This was being done to initilize in memory accounts, but brought a lot of extra baggage with it like storing encrypted data in memory, even though it is never referenced that way. 3. Breaking the on disk state object up into seperate keys for accounts instead of storing everything together under a "state" key. This ensures there is less information fetched from disk each time we call for an account. There were some restructuring changes needed to facilitate these items: 1. We need to be able to construct an account in the StateService, but typescript doesn't allow for new() constraints on generics so a factory needs to be created and passed into the StateService for this to work. 2. Since we can't reference an all-knowing "accounts" object for on disk state anymore we have to maintain a list of authenticated accounts, and this has been added. 3. The StateMigration service needed to be updated to break up the accounts object, so current dev and QA state will be broken and need to be reset. Some other general refactorings that were helpful gettings this working: 1. Added a constant for keys to the StateService and StateMigrationService. 2. Bundling everything needed to deauthenticate a user into a dedicated method. 3. Bundling all the disk storage clear methods (that should be refactored later into client specific state services) into one helper method. 4. Bundling everything needed to dynamically select a new active user into a dedicated method. * [bug] Set environmentUrls appropriatly on account add * [bug] Stop tracking activity without an active user * [bug] Remove lastActive from globalState and globalState migration * [style] Ran prettier	4 years ago
Thomas Rittson	cc285e5ea7	Always migrate envUrls (#614 )	4 years ago
Daniel James Smith	8460629de4	Bump electron from 16.0.2 to 16.0.7 (#613 )	4 years ago
Oscar Hinton	12011bf4da	Add a shared tsconfig file (#609 )	4 years ago
Thomas Rittson	ddcfe23367	Make lowdbStorageService wait until initialised (#605 ) * Make lowdbStorageService wait until initialised * Fix prettier	4 years ago
Addison Beck	957e010036	[bug] Ensure neverLock vaults can be manually locked (#607 ) The client side storage restructuring work incorrectly checks if a vault has ever been unlocked to determine neverLock scenerios, but production does the opposite. This creates an inability to never manually lock neverLock vaults. This commit sets that condition back to the way it was.	4 years ago
Addison Beck	c7ccb997bd	[bug] Use the correct login url in lock guard (#606 )	4 years ago
Robyn MacCallum	172392ff3b	[Account Switching] Fix options dropdowns being empty (#603 ) * Fix dropdowns initially being empty * run prettier * Remove default nulls for locale and theme	4 years ago
Thomas Rittson	2341b1907a	Fix "no amr found" error in bwdc cli (#589 ) * Fix amr error when authing with org api key * Fix linting * Return null instead of error if no amr * Return false instead of null	4 years ago
Addison Beck	4074c2a45f	[Bug] [Account Switching] Ensure EnvironmentUrls Pull From The Correction Location On Account Add (#602 ) * [bug] Fully initilize environmentUrls default value We want the full environmentUrls object to be saved to storage with null values as an indicator of using BW cloud. Currently the initilization behavior creates an empty object instead. Setting property values returns the correct behavior. * [bug] Return the correct environmentUrls when scaffloging a new account To allow for setting environmentUrls before an account is created we save that value as a global setting and then apply it to any newly authed accounts. There is a bug that will instead save the urls used by the previous logged in account, making account switching with multiple servers cause errors. This commit resolves this by specifically getting environementUrls from global state when creating a new account	4 years ago
Oscar Hinton	def3c47a1e	Disable spell checking (#601 )	4 years ago
Addison Beck	57d60bdfa6	Misc Account Switching Fixes & Refactors (#600 ) * [refactor] Restructure EnvironmentUrls in state * Patch up (add missing fields) and more extensivly use the EnvironmentUrls class instead of passing around an any * Add environmentUrls to the AccountSettings model in addition to GlobalState for use in both scopes * Move EnvironmentUrls initialization to the model level and out of StateSerice * Adjust the StateMigrationService to account for these changes * [refactor] Improve order of operations for LockGuardService We currently jump through a bunch of hoops to verify users can access the Lock page, like checking authentication first. If a user is not authenticated, they are not locked, so we can improve performance for the happy path of this serivice by checking isLocked first and using isAuthenticated to deviate from the normal flow if needed. * [bug] Subscribe to State.accounts in EnvironmentService and set urls accordingly The EnvironmentService has no context for account changes currently and does not update actively used urls based on active account. This commit addresses this issue by subscribing to State.accounts and resetting the service's urls on account change. * [bug] Clear AccessToken from State on clean In order for logout flows to function as expected we need to deauthenticate users when cleaning up state before checking for the next active user Otherwise the service will continue to think the user being logged out is active * [refactor] Stop pushing accounts when modifying disk state There is no reason to push new accounts to subscribers when updating disk state. Subscribers recieve a copy of in memory state, so changes to disk will not be refelected and have to be fetched seperatly from the service. Pushing when saving disk state is just creating an unecassary performance burden. * [refactor] Default to in memory active user if availible, even when accessing disk state Sometimes we need to pull activeUserId from storage to access a bit of data, like on initial boot, but most of the time this isn't necassary. Since we pull this userId a lot, checking disk each time is a performance burden. Defaulting to the in memory user ID if avaible helps alleviate this. * [style] Ran prettier * [style] Change a let to a const	4 years ago
Daniel James Smith	c6f20f8142	Fix prettier (#598 ) * Add .github/workflows to .prettierignore * Add all filestypes to prettier and ignore via .prettierignore * Add --ignore-unknown to prettier for lint-staged	4 years ago
Robyn MacCallum	c27fc39411	Use correct api Keys (#599 )	4 years ago
Robyn MacCallum	cc989e4071	Rename all occurances of fb to formBuilder (#595 )	4 years ago
Addison Beck	e4cd0af2f9	[bug] Add several state value defaults (#593 ) * [bug] Add several state value defaults * [refactor] Implement StateVersion as an enum * [refactor] Implement StateVersion enum over magic number	4 years ago
Daniel James Smith	d68c1dafaf	Remove usage/detection of NativeScript (#566 ) * Remove usage of NativeScript * npm prettier run * Removing type from Utils.global	4 years ago
Jake Fink	3d7b427b0e	Use MP policies when registering a new user through SSO (#587 ) * use MP policies when registering a new user through SSO * prettier and linting	4 years ago
Addison Beck	9e26336549	[feat(Account Switching)] Allow for extending application state (#584 ) * [feat(Account Switching)] Allow for extending application state * [bug(Account Switching)] Remove hardcoded dev urls * [bug(Account Switching)] Init Account when signing in * [bug(Account Switching)] Check for state migration version in local storage for web * [bug(Account Switching)] Fix never lock configurations * [chore] Prettier merge * [bug] Move environmentUrls to global state * [chore] Ran prettier * [bug]change storage location for enityId and type * [style] Ran prettier Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>	4 years ago
Jake Fink	59a5300458	move sso properties to globalstate (#583 ) * move sso properties to globalstate * whitespace * npm prettier changes	4 years ago
Linus Aarnio	a8168d6ee7	Fix for issue #1287 in bitwarden/web (#569 ) * Format the fieldvalue as a LocaleDateString instead of epoch when importing a date from 1P This would be better solved by storing it as a date FieldType instead of Text. But since it is unclear when new field types are added, this solution serves as a fix for now and also guides the solution when new fieldtype exists. * Remove trailing whitespace * Add tests for custom fields of 1pif imported identity * Change representation of 1pif imported dates to UTC string * Changes after running prettier Co-authored-by: Daniel James Smith <djsmith@web.de>	4 years ago
Linus Aarnio	e9666458c4	Select an image to display for credit cards based on the brand. (#537 ) Co-authored-by: Hinton <oscar@oscarhinton.com>	4 years ago
Daniel James Smith	36b3aea758	Update README.md (#586 ) * Update README.md * Replace header Git diff with Git blame	4 years ago
Oscar Hinton	cf1d82ac66	Add .git-blame-ignore-revs and prettier instructions (#585 )	4 years ago
Oscar Hinton	193434461d	Apply Prettier (#581 )	4 years ago
Oscar Hinton	8b2dfc6cdc	Add Prettier configuration (#574 )	4 years ago
Addison Beck	512c5c2837	[bug] Correct storage location of organizations (#580 )	4 years ago
Daniel James Smith	3fc7dd7089	Bump electron to 16 (#579 ) * Bump electron to 16.0.2 * Bump electron-update to 4.6.1	4 years ago
Daniel James Smith	8644d84e68	FSescure-Importer: Add support for style = global (#578 ) * Fescure-Importer: Add support for style = global * Fix linting	4 years ago
Addison Beck	f90b3456d5	[Account Switching] [Feature] Allow clients to store data for more than one user (#491 ) * [refactor] Extract, rename, and expand StorageServiceOptions * Pulled StorageServiceOptions into its own file * Renamed StorageServiceOptions to StorageOptions * Pulled KeySuffixOpptions into its own file * Converted KeySuffixOptions into an enum from a union type * [refactor] Expand StateService into a full coverage storage proxy * Expand StateService to allow it to manage all data points of the application state regardless of memory. * Expand StateService to allow for storing and managing multiple accounts * [refactor] Create helper services for managing organization and provider state data * [refactor] Implement StateService across service layer * Remove service level variables used for in memory data storage and replaced with calls to StateService * Remove direct calls to StorageService in favor of using StateService as a proxy * [feature] Implement account switching capable services across components and processes * Replace calls to StorageService and deprecated services with calls to a StateService * [chore] Remove unused services Several services are no longer in use because of the expanded state service. These have simply been removed. * [bug] Add loginRedirect to the account model * [bug] Add awaits to newly async calls in TokenService * [bug] Add several missing awaits * [bug] Add state service handlers for AutoConfirmFingerprint * [bug] Move TwoFactorToken to global state * Update unauth-guard.service.ts Add back return true * [refactor] Slim down the boilerplate needed to manage options on StateService calls * [bug] Allow the lock message handler to manipulate a specific acount * [bug] Add missing await to auth guard * [bug] Adjust state scope of several biometric data points * [bug] Ensure vault locking logic can operate over non-active accounts * [style] Fix lint complaints * [bug] Move disableFavicon to global state * [refactor] Remove an unecassary parameter from a StorageOptions instance * [bug] Ensure HtmlStorageService paths are accounted for in StateService * [feature] Add a server url helper to the account model for the account switcher * [refactor] Remove some unused getters from the account model * [bug] Ensure locking and logging out can function over any user * Fix account getting set to null in getAccountFromDisk * [bug] Ensure lock component is always working with the latest active account in state * [chore] Update recent KeyConnector changes to use stateService * [style] Fix lint complaints * [chore] Resolve TokenService merge issues from KeyConnector * [bug] Add missing service arguement * [bug] Correct several default storage option types * [bug] Check for the right key in hasEncKey * [bug] Add enableFullWidth to the account model * [style] Fix lint complaints * [review] Revist remember email * [refactor] Remove RememberEmail from state * setDisableFavicon to correct storage location * [bug] Convert vault lock loop returns into continues to not skip secondary accounts * [review] Sorted state service methods * [bug] Correct neverDomains type on the account model * [review] Rename stateService.purge to stateService.clean * [review] [refactor] Extract lock refresh logic to a load function * [review] [refactor] Extract some timeout logic to dedicated functions * [review] [refactor] Move AuthenticationStatus to a dedicated file * [review] [refactor] Rename Globals to GlobalState * [style] Fix lint complaints * [review] Remove unused global state property for decodedToken * [review] [bug] Adjust state scope for OrganizationInvitation * [review] [bug] Put back the homepage variable in lock guard * [review] Un-try-catch the window creation function * Revert "[review] [bug] Adjust state scope for OrganizationInvitation" This reverts commit caa4574a65d9d0c3573a7529ed2221764fd55497. * [bug] Change \|\| to && in recent vault timeout refactor * [bug] Keep up with entire state in storage instead of just accounts and globals Not having access to the last active user was creating issues across clients when restarting the process. For example: when refreshing the page on web we no longer maintain an understanding of who is logged in. To resolve this I converted all storage save operations to get and save an entire state object, instead of specifying accounts and globals. This allows for more flexible saving, like saving activeUserId as a top level storage item. * [style] Fix lint complaints * Revert "[bug] Keep up with entire state in storage instead of just accounts and globals" This reverts commit e8970725be472386358c1e2f06f53663c4979e0e. * [bug] Initialize GlobalState by default * [bug] Only get key hash from storage * [bug] Remove settings storage location overrides * [bug] Only save accessToken to storage * [refactor] Remove unecassary argements from electron crypto state calls * [bug] Ensure keys and tokens load and save to the right locations for web * [style] Fix lint complaints * [bug] Remove keySuffix storage option and split uses into unique methods The keySuffix options don't work with saving serialized json as a storage object - use cases simply overwrite each other in state. This commit breaks Auto and Biometric keys into distinct storage items and adjusts logic accordingly. * [bug] Add default vault timeouts to new accounts * [bug] Save appId as a top level storage item * [bug] Add missing await to timeout logic * [bug] Adjust state scope for everBeenUnlocked * [bug] Clear access tokens when loading account state from disk * [bug] Adjust theme to be a global state item * [bug] Adjust null checking for window in state * [bug] Correct getGlobals not pulling from the stored state item * [bug] Null check in memory account before claiming it has a userId * [bug] Scaffold secure storage service when building storage objects on init * [bug] Adjusted state scope of event collection * [bug] Adjusted state scope of vault timeout and action * [bug] Grab account from normal storage if secure storage is requested but does not exist * [bug] Create a State if one is requested from memory before it exists * [bug] Ensure all storage locations are cleared on state clean * [style] Fix lint complaints * [bug] Remove uneeded clearing of access token * [bug] Reset tokens when toggling * [refactor] Split up the Account model Until this point the account model has been very flat, holding many kinds of data. In order to be able to prune data at appropriate times, for example clearing keys at logout without clearing QoL settings like locale, the Account model has been divided into logical chunks. * [bug] Correct the serverUrl helpers return * Fix sends always coming back as empty in browser * Get settings properly (I think) * [bug] Fix lint error * [bug] Add missing await to identity token refresh This was causing weird behavior in web that was creating a lot of 429s * [bug] Scaffold memory storage for web Not properly creating storage objects on signin was creating weird behavior when logging out, locking, and logging back in. Namely, encrypted data that was recently synced had nowhere to save to and was lost. * [bug] Implement better null handling in a few places for retrieving state * [bug] Update correct storage locations on account removal * [bug] Added missing awaits to lock component * [bug] Reload lock component on account switching vs. account update * [bug] Store master keys correctly * [bug] Move some biometrics storage items to global state * [feature] Add platform helper isMac() * [refactor] Comment emphasis and call order refresh * [refactor] Remove unecassary using * [bug] Relocate authenticationStatus check logic to component * [bug] Stop not clearing everything on state clean * [style] Fix lint complaints * [bug] Correct mismatched uses of encrypted and decrypted pin states * Add browser specific state classes and methods * lint fixes * [bug] Migrate existing persistant data to new schema * [style] Fix lint complaints * [bug] Dont clear settings on state clean * [bug] Maintain the right storage items on logout * [chore] resolve issues from merge * [bug] Resolve settings clearing on lock * [chore] Added a comment * [review] fromatting for code review * Revert browser state items Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com> Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>	4 years ago
Daniel James Smith	8fc3cf50d2	Bump node to 16 and npm (#575 ) * Bump engines required to node 16 and npm 8 * Bump @types/node to 16 The dep on node 14.18 will get cleaned up once we bump electron * Modify build.yml to build with node 16 and npm 8 * Update requirements in README.md * Remove install step for npm 8 npm v8.1.2 is included in node v16 * Rename install step * Fixed typo	4 years ago
Daniel James Smith	e9630eeae5	Sync package-lock.json after Angular bump (#573 ) * Sync package-lock.json after Angular bump * Add form-data as dev dependency and bump typescript * Install rxjs as dev-dep in root package.json	4 years ago
Oscar Hinton	6a179ab2df	Bump angular to 12. (#571 )	4 years ago
Oscar Hinton	a6b95b15e3	Add toastr component (#568 )	4 years ago
Oscar Hinton	5db94cc9d0	BEEEP: Move DI logic to jslib (#565 )	4 years ago
Thomas Rittson	78429aa720	Change ngZone from private to protected (#567 ) * Change ngZone from private to protected * Remove unneeded file	4 years ago
Yuan Chao	920ec05fbb	Fix cursor location changing issue on toggle password (#561 )	4 years ago
Matt Gibson	d02fcd082e	Add sponsorship pre validate endpoint (#564 )	4 years ago
Jake Fink	340a79bfe6	reset ownershipOptions on init (#563 )	4 years ago
Matt Gibson	e1c6e4973a	Fix cli user agent (#562 )	4 years ago
Justin Baur	b4f475251a	Feature/families for enterprise (#549 ) * Families for enterprise/account settings (#541) * Add node tests to pipeline (#525) * Add support for crypto agent (#520) * feat: add an importer for Safari (CSV) (#512) * feat(importers/safariCsvImporter): add the importer for Safari (CSV) * Revert changes to package-lock.json Co-authored-by: Thomas Rittson <trittson@bitwarden.com> * Dynamically set electron user agent (#524) * Dynamically set electron user agent * PR review * linter fixes * Test agent static version does not change * Fix formatting * Add role="alert" to callouts only when enforceAlert is passed (#528) * Add role="alert" to callouts when enforceAlert is passed * Remove ElementRef and do a different way * Rename input variable * Add PR template (#529) * Allow managers to create collections (#530) * Pass in null for sso organziation for now. (#531) This will bypass cryptoagent * Add Linked Field as custom field type (#431) * Basic proof of concept of Linked custom fields * Linked Fields for all cipher types, use dropdown * Move linkedFieldOptions to view models * Move add-edit custom fields to own component * Fix change handling if cipherType changes * Use Field.LinkedId to store linked field info * Refactor accessors in cipherView for type safety * Use map for linkedFieldOptions * Refactor: use decorators to record linkable info * Add ItemView * Use enums for linked field ids * Add union type for linkedId enums, add jsdoc comment * Use parameter properties for linkedFieldOption Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Fix type casting Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Update electron to 14.2.0 (#534) * Update electron to 14.1.1 * Update electron to 14.2.0 and fix it to this version * Removed ^ from electron in electron/package-lock.json * [Linked fields] Reset linkedIds if cipher type changes (#535) * Reset linkedIds if cipher type changes * Only reset linkedId if !editmode * Add call to server * Fix linting * Add call to server * Fix linting * Run linting * Add new properties to organization * Remove organizationUserId from request model * Added in org sponsorship calls * Sponsorship redeem existing org flow Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Oscar Hinton <oscar@oscarhinton.com> Co-authored-by: pan93412 <pan93412@gmail.com> Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com> * Revoke sponsorship uses organization id * Expect information in billing items on whether the item is sponsored * Families for enterprise/redeem card (#546) * Add userservice helper * Run linter * Add resend email to api service (#548) * Remove unneeded imports * Remove unneeded files * Add newline * Reorder import * Remove accidental newline * Fix lint issue Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Oscar Hinton <oscar@oscarhinton.com> Co-authored-by: pan93412 <pan93412@gmail.com> Co-authored-by: Thomas Rittson <trittson@bitwarden.com> Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>	4 years ago
Oscar Hinton	f4c66b2c8c	Add support for hiding input on lock screen if using key connector (#560 )	4 years ago
Oscar Hinton	a3e00cdc15	Add usesKeyConnector to OrganizationUserUserDetailsResponse (#559 )	4 years ago
Oscar Hinton	8b01eea446	[Key Connector] Resolve desktop not prompting to remove password (#558 )	4 years ago
Thomas Rittson	10fa164ffc	Add FirstSsoLogin event (#555 )	4 years ago
Oscar Hinton	9b7aaa272d	Add confirm identity helper text to password in verify component (#554 )	4 years ago
Thomas Rittson	fc0d624621	[Key Connector] Hide "Master Pass On Restart" prompt when setting pin (#556 ) * Disable Master Pass on Restart for Key Connector * Fix linting	4 years ago
Thomas Rittson	07dde6e321	Add getKeyConnectorAlive to ApiService (#543 )	4 years ago
Oscar Hinton	ea9a8b979d	Update verify master password component (#553 )	4 years ago
Oscar Hinton	e1b1efeea2	Add useKeyConnector flag (#551 )	4 years ago

1 2 3 4 5 ...

1571 Commits (e2d95741b00b24b96275bc11334aab7324a56d3a) All Branches Search

1571 Commits (e2d95741b00b24b96275bc11334aab7324a56d3a)

All Branches