clients

Commit Graph

Author	SHA1	Message	Date
Thomas Rittson	bcb232cc80	[AC-2026] Add flexible collections opt-in UI (#7443 )	2 years ago
✨ Audrey ✨	8555dcc613	fix const lint (#7673 )	2 years ago
✨ Audrey ✨	df2329f059	[PM-5781] Anon addy forwarder (#7654 )	2 years ago
Justin Baur	c1d5351075	[PM-5535] Migrate Environment Service to StateProvider (#7621 ) * Migrate EnvironmentService * Move Migration Test Helper * Claim StateDefinition * Add State Migration * Update StateServices * Update EnvironmentService Abstraction * Update DI * Update Browser Instantiation * Fix BrowserEnvironmentService * Update Desktop & CLI Instantiation * Update Usage * Create isStringRecord helper * Fix Old Tests * Use Existing AccountService * Don't Rely on Parameter Mutation * Fix Conflicts	2 years ago
Bernd Schoolmann	842fa5153b	Replace promise.all with for loop for performance reasons (#7582 )	2 years ago
Matt Gibson	af0d2f515d	Vault/pm-4185/checksum uris (#6485 ) * Validate checksum on decrypt of URI * Add uri checksum to domain during encryption * Move hash to stateless encrypt service * Add checksum field to all the other models necessary for syncing with server * Remove old test in favor of `describe` block * PM-4185 Added a boolean to control checksum validation * PM-4185 Fi unit tests * [PM-4810][PM-4825][PM-4880] Fix encrypted import and add null check (#6935) * PM-4810 Bumped up version * PM-4880 Add null check * PM-4825 Fix encrypted export * PM-5462 Fix item saving with blank URI (#7640) * PM-4185 Add back uriChecksum setting --------- Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com> Co-authored-by: Matt Bishop <mbishop@bitwarden.com> Co-authored-by: gbubemismith <gsmithwalter@gmail.com> Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>	2 years ago
Shane Melton	622791307a	[AC-1890] Update the collection PUT/POST response models to include collection permission details (#7512 )	2 years ago
Matt Gibson	e23bcb50e8	[PM-5533] Migrate Org Keys to state providers (#7521 ) * Move org keys to state providers * Create state for org keys and derive decrypted for use * Make state readonly * Remove org keys from state service * Migrate user keys state * Review feedback * Correct test name * Refix key types * `npm run prettier` 🤖	2 years ago
✨ Audrey ✨	dbf836b573	[PM-5606] Add reactive generator service (#7446 )	2 years ago
Alex Morask	014281cb93	[AC-1758] Show banner when organization requires a payment method (#7088 ) * Add billing banner states to account settings * Add billing banner service * Add add-payment-method-banners.component * Use add-payment-method-banners.component in layouts * Clear banner on payment method addition * Ran prettier after CI update * Finalize banners styling/translations * Will's (non-Tailwind) feedback * Review feedback * Review feedback * Review feedback * Replace StateService with StateProvider in BillingBannerService * Remove StateService methods	2 years ago
✨ Audrey ✨	d5738b7483	[PM-5780] New username generation settings types (#7613 ) Split from #6924	2 years ago
Cesar Gonzalez	0127db44a0	[PM-5551] Removing Autofill v2 and AutofillOverlay Feature Flags (#7642 ) * [PM-5551] Removing Autofillv2 and AutofillOverlay Feature Flags * [PM-5551] Fully removing references to autofill v1	2 years ago
Jake Fink	07af08b893	[PM-2772] add flag to deter process reload if cancel is clicked on biometrics (#7350 ) * add flag to deter process reload if cancel is clicked on biometrics * rename flag * store biometrics cancelled to disk instead of integrating with process reload * allow auto-prompt when opening app	2 years ago
Kyle Spearrin	06c7c3fd18	[PM-5149] UI for unique SP entity id on organization sso configs (#7117 ) * add ui for making sp entity id unique * pretty * updates	2 years ago
Justin Baur	06028c35bc	Fully Test EnvironmentService (#7589 ) Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
Justin Baur	57609737f1	Fix SingleUserStateProvider (#7593 ) * Fix SingleUserStateProvider - Fix cache key to be unique per instance per user * Add Specific State Provider Tests * Add Missing await	2 years ago
Jonathan Prusik	8e9a104bd0	[deps] Autofill: Update prettier to v3.2.2 (#7565 ) * [deps] Autofill: Update prettier to v3.2.2 * prettier fixes --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2 years ago
Thomas Rittson	ee4aa31444	[AC-2027] Update Flexible Collections logic to use organization property (#7445 ) * Remove unused feature flag * Replace feature flag ref with org flag * Remove deprecated feature flag to discourage use * Add check to org.canCreateNewCollections * Adjust init logic of components to avoid race conditions * Make canCreateNewCollections logic more explicit * Resolve merge conflicts with vault changes * Update comments * Remove uses of old feature flag * Remove last of old feature flag * Clean up feature flag * Fix linting * Fix linting	2 years ago
Matt Gibson	160a636fa0	Move key types to central location (#7531 )	2 years ago
Jared Snider	756c02cec2	Auth/PM-4596 - Extract PIN and Biometrics unlock method logic into re-useable services for user verification (#7107 ) * PM-4596 - PinCryptoService first draft * PM-4596 - PinCryptoService - Refactor pinKeyEncryptedKey retrievals out into own method getPinKeyEncryptedKeys * PM-4596 - npm ci + npm run prettier to fix lint issues * PM-4596 - PinCryptoService - Add kdf types * PM-4596 - PinCryptoService - Refactor pin validation into own helper method. * PM-4596 - Rename pin-crypto.service.ts to pin-crypto.service.implementation.ts * PM-4596 - PinCryptoService - add additional logging for error states. * PM-4596 - JslibServicesModule - register new PinCryptoService and PinCryptoServiceAbstraction * PM-4596 - PinCryptoService - modify decryptUserKeyWithPin signature to not require email to match MP verification process in user verification service. * PM-4596 - Lock components - use new PinCryptoService.decryptUserKeyWithPin(...) to get user key + refactor base comp unlock with pin method to improve * PM-4596 - Lock component - if too many invalid attempts, added toast explaining that we were logging the user out due to excess PIN entry attempts * PM-4596 - UserVerificationService - (1) Refactor verifyUser(...) to use switch + separate methods for a cleaner parent method + better extensibility for PIN & biometrics which are TBD (2) Add PIN support to validateInput(...) * PM-4596 - UserVerificationService - add PIN and biometrics functions to verifyUser(...) * PM-4596 - PinCryptoService Spec - start test file - instantiates properly * PM-4596 - PinCryptoService tests - WIP * PM-4596 - PinCryptoService tests - WIP - got success cases working * PM-4596 - pin-crypto.service.implementation.spec.ts renamed to pin-crypto.service.spec.ts * PM-4596 - PinCryptoService.getPinKeyEncryptedKeys(...) - add comment + var name change for clarity * PM-4596 - PinCryptoService tests - test invalid, null return scenarios * PM-4596 - CLI - bw.ts - update UserVerificationService instantiation to include new pinCryptoService * PM-4596 - PinCryptoService - import VaultTimeoutSettingsServiceAbstraction instead of implementation for factory creation to get browser building * PM-4596 - (1) Create pinCryptoServiceFactory for browser background (2) Add it to the existing userVerificationServiceFactory * PM-4596 - Browser - Main.background.ts - Add pinCryptoService and add to userVerificationService dependencies * PM-4596 - UserVerificationService - per PR feedback simplify returns of verifyUserByPIN(...) and verifyUserByBiometrics(...) * PM-4596 - Messages.json on desktop & browser - per PR feedback, adjust tooManyInvalidPinEntryAttemptsLoggingOut translation text to remove "you" * PM-4596 - VerificationType enum - fix line copy mistake and give BIOMETRICS own, unique value. * PM-4596 - VerificationType - rename BIOMETRICS to Biometrics to match existing MasterPassword value case. * PM-4596 - Update verification type to consider whether or not a secret exists as we have added a new verification which doesn't have a type. Add new server and client side verification types. Update all relevant code to pass compilation checks. * PM-4596 - More verification type tweaking * PM-4596 - Verification - verificationHasSecret - tweak logic to be more dynamic and flexible for future verification types * PM-4596 - UpdateTempPasswordComp - use new MasterPasswordVerification * PM-4596 - Desktop - DeleteAcctComp - use VerificationWithSecret to solve compile error w/ accessing secret * PM-4596 - Per discussions with Andreas & Will, move new Pin Crypto services into libs/auth + added @bitwarden/auth path to CLI tsconfig + added new, required index.ts files for exporting service abstractions & implementations * PM-4596 - Fixed missed import fixes for lock components across clients for pin crypto service after moving into @bitwarden/auth * PM-4596 - More PinCryptoService import fixes to get browser & desktop building * PM-4596 - Update desktop lock comp tests to pass by providing new pin crypto service. * PM-4596 - User verification service -update todo * PM-4596 - PinCryptoService - per PR feedback, fix auto import wrong paths. * PM-4596 - PinCryptoService tests - fix imports per PR feedback * PM-4596 - UserVerificationSvc - rename method to validateSecretInput per PR feedback * Fix imports * PM-4596 - PinCryptoService - Refactor naming for clarity and move test cases into describes per PR feedback * reorg libs/auth; expose only libs/auth/core to cli app * PM-4596 - UserVerification - Resolve import issue with importing from libs/auth. Can't use @bitwarden/auth for whatever reason. * PM-4596 - Fix desktop build by fixing import * PM-4596 - Provide PinCryptoService to UserVerificationService * PM-4596 - PinCryptoServiceFactory - you cannot import services from @bitwarden/auth in the background b/c it brings along the libs/auth/components and introduces angular into the background context which doesn't have access to angular which causes random test failures. So, we must separate out the core services just like the CLI to only bring along the angular agnostic services from core. * PM-4596 - Refactor libs/auth to have angular / common + update all imports per discussion with Matt & Will. Introduced circular dep between PinCryptoService + VaultTimeoutSettingsService + UserVerificationService * PM-4596 - VaultTimeoutSettingsService - Refactor UserVerificationService out of the service and update all service instantiations and tests. The use of the UserVerificationService.hasMasterPassword method no longer needs to be used for backwards compatibility. This resolves the circular dependency between the PinCryptoService, the UserVerificationService, and the VaultTimeoutSettingsService. We will likely refactor the hasMasterPassword method out of the UserVerificationService in the future. * PM-4596 - Update CL tsconfig.libs.json to add new auth/common and auth/angular paths for jslib-services.module imports of pin crypto service to work and for test code coverage to run successfully. * PM-4596 - Address PR feedback * PM-4596 - Update root tsconfig (only used by storybook) to add new libs/auth paths to fix chromatic build pipeline. * PM-4596 - Actually update tsconfig with proper routes to fix storybook * PM-4596 - UserVerificationService - verifyUserByBiometrics - add error handling logic to convert failed or cancelled biometrics verification to a usable boolean * PM-4596 - Add missing await * PM-4596 - (1) Add log service and log to user verification service biometric flow to ensure errors are at least revealed to the console (2) Fix factory missing PinCryptoServiceInitOptions * PM-4596 - Use the correct log service abstraction * PM-4596 - Remove unused types per PR review --------- Co-authored-by: William Martin <contact@willmartian.com>	2 years ago
Jonathan Prusik	eae845d900	[PM-4260] [BEEEP] Mask TOTP seeds in cipher edit view - similar to how the password is hidden (#6649 ) * PoC disallow changing masked values in edit mode and mask TOTP with password * toggle totp seed visibility independently from password visibility in edit mode * cleanup * add fallback value for when a cipher returns a null value for maskedPassword * toggle masks off for maskable login properties with no value on load * do not show mask toggle for password or totp if no value is present	2 years ago
Oscar Hinton	93e9937e5c	Add some test cases to the password strength service (#7483 ) Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>	2 years ago
Rui Tomé	48643e45ea	[AC-1893] Removed logic to downgrade Manager roles and remove Edit/Delete any collection permissions for Flexible Collections (#7365 )	2 years ago
Justin Baur	0874df8b84	Global State Rewrite (#7515 ) * Global State Rewrite * Apply suggestions from code review Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Prettier --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
Matt Bishop	6baad76088	[PM-5548] Eliminate in-app purchase logic (#7433 ) * Eliminate in-app purchase logic * Remove more in-app logic found, for payment and subscription management --------- Co-authored-by: Lotus Scott <148992878+lscottbw@users.noreply.github.com>	2 years ago
Matt Gibson	f8d72f0231	[PM-5465] Fix null checks in login view uris (#7421 ) * Prefer empty lists to null * Defensively null check public properties	2 years ago
Thomas Rittson	1f57244d1a	Add organization.flexibleCollections to models (#7442 )	2 years ago
Todd Martin	7bd8b00fbf	[PM-2260] Remove TDE feature flag and all conditional logic based on it (#7352 )	2 years ago
Matt Gibson	46a3834f46	Add state for everHadUserKey (#7208 ) * Migrate ever had user key * Add DI for state providers * Add state for everHadUserKey * Use ever had user key migrator Co-authored-by: SmithThe4th <gsmithwalter@gmail.com> Co-authored-by: Carlos Gonçalves <LRNcardozoWDF@users.noreply.github.com> Co-authored-by: Jason Ng <Jcory.ng@gmail.com> * Fix test from merge * Prefer stored observables to getters getters create a new observable every time they're called, whereas one set in the constructor is created only once. * Fix another merge issue * Fix cli background build --------- Co-authored-by: SmithThe4th <gsmithwalter@gmail.com> Co-authored-by: Carlos Gonçalves <LRNcardozoWDF@users.noreply.github.com> Co-authored-by: Jason Ng <Jcory.ng@gmail.com>	2 years ago
Matt Gibson	211d7a2626	Ps/improve state provider fakers (#7494 ) * Expand state provider fakes - default null initial value for fake states - Easier mocking of key definitions through just the use of key names - allows for not exporting KeyDefinition as long as the key doesn't collide - mock of fake state provider to verify `get` calls - `nextMock` for use of the fn mock matchers on emissions of `state$` - `FakeAccountService` which allows for easy initialization and working with account switching * Small bug fix for cache key collision on key definitions unique by only storage location * Fix initial value for test	2 years ago
Todd Martin	c9a2f07e04	Remove Fido2VaultCredentials feature flag (#7463 ) * Removed Fido2 client credentials feature flag * Removed test for feature flag.	2 years ago
Ike	6f22f05eee	Update sso prevalidate path (#7479 ) * Update sso prevalidate path * fixed formatting	2 years ago
Matt Gibson	92f593df08	Remove unnecessary complex types (#7451 ) #7290 introduced these types, but during development we switched over to specifying dependencies in type parameters instead of an object. This change meant we no longer needed these `Type` or `ShapeToInstance` types, greatly simplifying the types related to derived state.	2 years ago
Justin Baur	5e11cb212d	Combined State (#7383 ) * Introduce Combined State * Cleanup Test * Update Fakes * Address PR Feedback * Update libs/common/src/platform/state/implementations/default-active-user-state.ts Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Prettier * Get rid of ReplaySubject reference --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
Matt Gibson	06affa9654	Rework derived state (#7290 ) * Remove derived state from state classes * Create provider for derived state Derived state is automatically stored to memory storage, but can be derived from any observable. * Fixup state provider method definitions * Test `DefaultDerivedState` * remove implementation notes * Write docs for derived state * fixup derived state provider types * Implement buffered delayUntil operator * Move state types to a common module * Move mock ports to centra location * Alias DerivedStateDependency type * Add dependencies to browser * Prefer internal rxjs operators for ref counting * WIP * Ensure complete on subjects * Foreground/background messaging for browser Defers work for browser to the background * Test foreground port behaviors * Inject foreground and background derived state services * remove unnecessary class field * Adhere to required options * Add dderived state to CLI * Prefer type definition in type parameters to options * Prefer instance method * Implements factory methods for common uses * Remove nothing test * Remove share subject reference Share manages connector subjects internally and will reuse them until refcount is 0 and the cleanup time has passed. Saving our own reference just risks memory leaks without real testability benefits. * Fix interaction state	2 years ago
Jared Snider	1fdc6629e3	Auth/PM-3859 - Desktop - Create lock mechanism to prevent app menu redraw on sync complete when user logging out (#6920 ) * PM-3859 - Desktop App Comp - Build lock mechanism for update app menu which doesn't try to update the menu for users who are being logged out which was causing errors (primary scenario was triggered by logging in on desktop with a TDE user w/out a MP, triggering a sync, then hitting the command to lock the vault right after which would trigger a log out while the sync was still in process. Then, while the log out was in process, the sync would try and trigger an update to the app menu but it would error as some of the user's state had already been cleaned up) * PM-3859 - App comp - remove use of promise.all to prevent any race conditions from causing intermittent logout errors with state being cleared and then values trying to be set on the cleared state (I observed setMasterKey get called after state account.keys was cleared - received error when attempting to set value on undefined). * PM-3859 - Desktop Vault Items Component - on log out, if you were on the vault screen, the loss of focus on the vault search text box would trigger a search 200 ms after log out had been triggered. This would eventually attempt to set an undefined master key (VaultItemsComponent.doSearch() --> cipherService.getAllDecrypted() --> cryptoService.getUserKeyWithLegacySupport() --> cryptoService.getMasterKey() --> cryptoService.setMasterKey()). However, at this point, the account had been cleared as part of the log out process and an error would be thrown in the state service for trying to set account.keys.masterKey to undefined when the account and account.keys were undefined. These changes prevent the search from firing until the value changes and also prevents setMasterKey from being called if it is undefined.	2 years ago
Andreas Coroiu	551d2c2441	[PM-5302] Refactor Passkey feature enable/disable logic (#7242 ) * feat: add missing tests for `isFido2FeatureEnabled` * feat: add user logged in check * chore: rewrite with cartesian product * chore: remove test The test was more complex than the actual function, removing. * feat: add domain exclusion * feat: add origin equal vault case * chore: clean up the old code from `content-secript` * feat: return early to avoid making api calls * fix: prettier linting * fix: incorrect logic inversion --------- Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com> Co-authored-by: SmithThe4th <gsmith@bitwarden.com>	2 years ago
Matt Gibson	a682f2a0ef	[PM-5468] Ensure prototypes available on memory stored objects (#7399 ) * Hide account switcher in addEdit generator * Handle AddEditCipher deserialization * Opaque types are not serializable * Better handle jsonification of login uris * Ensure we don't overwrite original with clone * Ensure cipherView prototype is always restored if it exists	2 years ago
SmithThe4th	c289b3b8a4	Removed automatic fallback to browser when no credentials exist (#7135 ) Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>	2 years ago
SmithThe4th	6755c8c6ce	[PM-5347] Fix buggy P1363 to DER conversion (#7303 ) * [PM-5347] feat: add tests * fixed miscalculated lengths for R and S components by not by prepending an extra byte when the MSB of the first byte in a component is greater than or equal to 0x80 * renamed to correct format * fixed issue when there is a leading zero and a negative * removed comment * Made test cases clearer and more informative, renamed joseToDer, removed alg parameter and defaulted to use ES256 algorithm --------- Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>	2 years ago
Jake Fink	a62f8cd652	[PM-3797] Client changes to use new key rotation process (#6881 ) ## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Final Client changes for Key Rotation Improvements. - Introduces a new `KeyRotationService` that is responsible for owning rotation process. - Moves `Send` re-encryption to the `SendService` (`KeyRotationService` shouldn't have knowledge about how domains are encrypted). - Moves `EmergencyAccess` re-encryption to the `EmergencyAccessService`. - Renames `AccountRecoveryService` to `OrganizationUserResetPasswordService` after feedback from Admin Console ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Auth - emergency-access-update.request.ts: New request model for domain updates that includes Id - emergency-access.service.ts: Moved `EmergencyAccess` re-encryption to the `EmergencyAccessService`. Add deprecated method for legacy key rotations if feature flag is off - key-rotation.service/api/spec/module: New key rotation service for owning the rotation process. Added api service, module, and spec file. - update-key.request.ts: Moved to Auth ownership. Also added new properties for including other domains. - migrate-legacy-encryption.component.ts: Use new key rotation service instead of old component specific service. Delete old service. - change-password.component.ts: Use new key rotation service. - settings.module.ts: Import key rotation module. Admin Console - organization-user-reset-password.service.ts/spec: Responsible for re-encryption of reset password keys during key rotation. Added tests. - organization-user-reset-password-enrollment.request.ts: New request model for key rotations - reset-password.component.ts: Update `AccountRecoveryService` to `OrganizationUserResetPasswordService` - enroll-master-password-reset.component.ts: Update `AccountRecoveryService` to `OrganizationUserResetPasswordService` Tools - send.service/spec.ts: Responsible only for re-encryption of sends during key rotation. Added tests. Other - api.service.ts: Move `postAccountKey` to `KeyRotationApiService` - feature-flag.enum.ts: add new feature flag ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please add unit tests where it makes sense to do so (encouraged but not required) - If this change requires a documentation update - notify the documentation team - If this change has particular deployment requirements - notify the DevOps team - Ensure that all UI additions follow [WCAG AA requirements](https://contributing.bitwarden.com/contributing/accessibility/)	2 years ago
Shane Melton	a19a4ffdf7	[AC-1879] Add null check for collection view helpers (#7073 ) * [AC-1879] Add null check for collection view helpers * [AC-1879] Add additional null check to organization-options.component.ts	2 years ago
cyprain-okeke	de04bc4410	[AC-1753] Automatically assign provider's pricing to new organizations (#7228 ) * changes for the msp task * fix an issues * resolve pr comment	2 years ago
Jared Snider	9544da28c7	PM-5304 - Sync Service - setForceSetPasswordReasonIfNeeded(...) - Add bandaid to early return if state gets corrupted with undefined acctDecryptionOpts so that the sync won't error and prevent users from accessing their data added on another device. (#7265 )	2 years ago
Shane Melton	cdb59f0939	[AC-1982] Add AllowAdminAccessToAllCollectionItems setting to the organization (#7268 )	2 years ago
Jonathan Prusik	f04cd7eeef	autofill overlay visibility setting should be off by default (#7266 )	2 years ago
Matt Gibson	69657a5ab5	Ps/allow state provider migrations from v 9 (#7263 ) * Provide missing spec helpers and fakers * We need to be able to migrate v9 stuff to state providers	2 years ago
bharat	96d1c83385	[PM-4077] safeincloud multiple url fix (#6394 ) * safeincloud multiple url fix * Ensure LoginView.uris is consistently populated	2 years ago
Justin Baur	7abbe0dafd	State definitions tests (#7173 ) * Add StateDefinition Tests and Rules * Update Comments	2 years ago
Matt Gibson	fd85d13b18	Ps/avoid state emit until updated (#7198 ) * Add a small default time to limit timing failures * Handle subscription race conditions * Add Symbols to tracked emission types This is a bit of a cheat, but Symbols can't be cloned, so we need to nudge them to something we can handle. They are rare enough that anyone hitting this is likely to expect some special handling. * Ref count state listeners to minimize storage activity * Ensure statuses are updated * Remove notes * Use `test` when gramatically more proper * Copy race and subscription improvements to single user * Simplify observer initialization * Correct parameter names * Simplify update promises test we don't accidentally deadlock along the `getFromState` path * Fix save mock * WIP: most tests working * Avoid infinite update loop * Avoid potential deadlocks with awaiting assigned promises We were awaiting a promise assigned in a thenable. It turns out that assignment occurs before all thenables are concatenated, which can cause deadlocks. Likely, these were not showing up in tests because we're using very quick memory storage. * Fix update deadlock test * Add user update tests * Assert no double emit for multiple observers * Add use intent to method name * Ensure new subscriptions receive only newest data TODO: is this worth doing for active user state? * Remove unnecessary design requirement We don't need to await an executing update promise, we can support two emissions as long as the observable is guaranteed to get the new data. * Cleanup await spam * test cleanup option behavior * Remove unnecessary typecast * Throw over coerce for definition options * Fix state$ observable durability on cleanup	2 years ago

... 11 12 13 14 15 ...

1031 Commits (DEVOPS-1573_add-web-build-script)