clients

Commit Graph

Author	SHA1	Message	Date
Jared Snider	4de7cb8012	BEEEP - Auth AccountService Improvements (#11779 ) * BEEEP Adjacent - AccountService misc improvements - (1) prefer null over undefined and (2) add new Account type * LockCompV2 - Fix activeAccount type per PR feedback * AccountService - update getUserId per PR feedback.	1 year ago
Thomas Rittson	d0ed9aaa5d	[PM-13779] Add vNext CollectionService without ActiveUserState (#11705 ) - add tests - install jest-extended for additional matchers - allow for generation of different crypto keys in tests	1 year ago
Oscar Hinton	c88c5bf1ef	[PM-11766] Introduce SDK client (#10974 ) Integrate the SDK into our other clients.	1 year ago
Matt Gibson	9459cda304	Pm-10953/add-user-context-to-sync-replaces (#10627 ) * Require userId for setting masterKeyEncryptedUserKey * Replace folders for specified user * Require userId for collection replace * Cipher Replace requires userId * Require UserId to update equivalent domains * Require userId for policy replace * sync state updates between fake state for better testing * Revert to public observable tests Since they now sync, we can test single-user updates impacting active user observables * Do not init fake states through sync Do not sync initial null values, that might wipe out already existing data. * Require userId for Send replace * Include userId for organization replace * Require userId for billing sync data * Require user Id for key connector sync data * Allow decode of token by userId * Require userId for synced key connector updates * Add userId to policy setting during organization invite accept * Fix cli * Handle null userId --------- Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>	1 year ago
Matt Gibson	97f44ace66	Loosen timings to avoid false failures. (#10215 ) Biggest ones here are the not resolved tests that can be evaluated at any time.	1 year ago
Matt Gibson	5b5c165e10	[PM-8847] Delay browser local storage operations during reseed (#9536 ) * Define matchers to test promise fulfillment These are useful for validating that promises depend on other events prior to fulfilling. * Expose custom matchers to jest projects Team-specific projects are not touched here to try and reduce review burden. * Block browser local operations awaiting reseed This should closes a narrow race condition resulting from storage operations during a reseed event. * Import from barrel file This might fix the failing test, but I'm not sure _why_ * Document helper methods * Validate as few properties as possible per test * Simplify expected value representation * Allow waiting in promise matchers * Specify resolution times in promise orchestration tests. * Test behavior triggering multiple reseeds. * Fix typo * Avoid testing implementation details * Clear reseed on startup in case a previous process was aborted in the middle of a reseed. * Correct formatting	1 year ago
Andreas Coroiu	9d060be48c	[PM-9442] Add tests for undefined state values and proper emulation of ElectronStorageService in tests (#9910 ) * fix: handle undefined value in migration 66 * fix: the if-statement was typo * feat: duplicate error behavior in fake storage service * feat: fix all migrations that were setting undefined values * feat: add test for disabled fingrint in migration 66 * fix: default single user state saving undefined value to state * revert: awaiting floating promise gonna fix this in a separate PR * Revert "feat: fix all migrations that were setting undefined values" This reverts commit `034713256c`. * feat: automatically convert save to remove * Revert "fix: default single user state saving undefined value to state" This reverts commit `6c36da6ba5`.	1 year ago
Shane Melton	19f2d2aefc	[PM-8379] Update vault popup items service to track loading state (#9528 )	2 years ago
Matt Gibson	96d4312b82	Require lifetime specification of user-scoped data (#8669 ) * Require lifetime specification of user-scoped data * Decouple tests for different classes This coupling assumed constant interfaces with classes that isn't a guarantee and requires significant acrobatics to make types work, now that key definitions are not a consistent base. * Fix types	2 years ago
Matt Gibson	3154d21925	[PM-8285] Resolve app id race (#9501 ) * Do not update appId if it is not null * Prefer linear transformations to side-effect-based changes This leaves us open to repeat emits due to updates, but distinct until changed stops those. Tracker improvements are due to passed in observables with replay causing immediate emits when `expectingEmission`s. This converts to a cold observable that only emits when the tracked observable does _after_ subscribing. * Prefer while * PR review	2 years ago
Matt Gibson	37eef7731f	Prefer prefetching keys (#9289 ) magical black-box key retrieval is slow, due to needing to repeatedly resolve (and potentially decrypt) keys. Doing the work up front is both more explicit and much faster. It would be preferable to move OrganizationId to an opaque type in the models, but that has rippling effects all over the place and ultimately is stopped by vault filtering on strings rather than ids, but still calling the property `organizationId`, we need to fix that first.	2 years ago
Matt Gibson	b4631b0dd1	Ps/improve-log-service (#8989 ) * Match console method signatures in logService abstraction * Add a few usages of improved signature * Remove reality check test * Improve electron logging	2 years ago
Matt Gibson	c70a5aa024	[PM-6688] Use AccountService as account source (#8893 ) * Use account service to track accounts and active account * Remove state service active account Observables. * Add email verified to account service * Do not store account info on logged out accounts * Add account activity tracking to account service * Use last account activity from account service * migrate or replicate account service data * Add `AccountActivityService` that handles storing account last active data * Move active and next active user to account service * Remove authenticated accounts from state object * Fold account activity into account service * Fix builds * Fix desktop app switch * Fix logging out non active user * Expand helper to handle new authenticated accounts location * Prefer view observable to tons of async pipes * Fix `npm run test:types` * Correct user activity sorting test * Be more precise about log out messaging * Fix dev compare errors All stored values are serializable, the next step wasn't necessary and was erroring on some types that lack `toString`. * If the account in unlocked on load of lock component, navigate away from lock screen * Handle no users case for auth service statuses * Specify account to switch to * Filter active account out of inactive accounts * Prefer constructor init * Improve comparator * Use helper methods internally * Fixup component tests * Clarify name * Ensure accounts object has only valid userIds * Capitalize const values * Prefer descriptive, single-responsibility guards * Update libs/common/src/state-migrations/migrate.ts Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com> * Fix merge * Add user Id validation activity for undefined was being set, which was resulting in requests for the auth status of `"undefined"` (string) userId, due to key enumeration. These changes stop that at both locations, as well as account add for good measure. --------- Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>	2 years ago
findseat	72f411b6e3	Signed-off-by: findseat <penglili@outlook.com> (#8636 ) Signed-off-by: findseat <penglili@outlook.com>	2 years ago
Matt Gibson	089f251a0c	Remove memory storage cache from derived state. Use observable cache and port messaging (#8939 )	2 years ago
Matt Gibson	300b17aaeb	[PM-7653] Do not store disk-backed sessions as single blobs (#8852 ) * Implement a lazy value class This will be used as a source for composing key-protected storage from a single key source. * Simplify local-backed-session-storage The new implementation stores each value to a unique location, prefixed with `session_` to help indicate the purpose. I've also removed the complexity around session keys, favoring passing in a pre-defined value that is determined lazily once for the service worker. This is more in line with how I expect a key-protected storage would work. * Remove decrypted session flag This has been nothing but an annoyance. If it's ever added back, it needs to have some way to determine if the session key matches the one it was written with * Remove unnecessary string interpolation * Remove sync Lazy This is better done as a separate class. * Handle async through type * prefer two factory calls to incorrect value on races. * Fix type * Remove log * Update libs/common/src/platform/misc/lazy.ts Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com> --------- Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>	2 years ago
Matt Gibson	b5362ca1ce	Browser MV3: Default store values to session storage (#8844 ) * Introduce browser large object storage location. This location is encrypted and serialized to disk in order to allow for storage of uncountable things like vault items that take a significant amount of time to prepare, but are not guaranteed to fit within session storage. however, limit the need to write to disk is a big benefit, so _most_ things are written to storage.session instead, where things specifically flagged as large will be moved to disk-backed memory * Store derived values in large object store for browser * Fix AbstractMemoryStorageService implementation	2 years ago
Matt Gibson	8d698d9d84	[PM-7169][PM-5267] Remove auth status from account info (#8539 ) * remove active account unlocked from state service * Remove status from account service `AccountInfo` * Fixup lingering usages of status Fixup missed factories * Fixup account info usage * fixup CLI build * Fixup current account type * Add helper for all auth statuses to auth service * Fix tests * Uncomment mistakenly commented code * Rework logged out account exclusion tests * Correct test description * Avoid getters returning observables * fixup type	2 years ago
Matt Gibson	c02723d6a6	Specify clearOn options for platform services (#8584 ) * Use UserKeys in biometric state * Remove global clear todo. Answer is never * User UserKeys in crypto state * Clear userkey on both lock and logout via User Key Definitions * Use UserKeyDefinitions in environment service * Rely on userKeyDefinition to clear org keys * Rely on userKeyDefinition to clear provider keys * Rely on userKeyDefinition to clear user keys * Rely on userKeyDefinitions to clear user asym key pair	2 years ago
Matt Gibson	62ad39e697	Ps/pm 5965/better config polling (#8325 ) * Create tracker that can await until expected observables are received. * Test dates are almost equal * Remove unused class method * Allow for updating active account in accout service fake * Correct observable tracker behavior Clarify documentation * Transition config service to state provider Updates the config fetching behavior to be lazy and ensure that any emitted value has been updated if older than a configurable value (statically compiled). If desired, config fetching can be ensured fresh through an async. * Update calls to config service in DI and bootstrapping * Migrate account server configs * Fix global config fetching * Test migration rollback * Adhere to implementation naming convention * Adhere to abstract class naming convention * Complete config abstraction rename * Remove unnecessary cli config service * Fix builds * Validate observable does not complete * Use token service to determine authed or unauthed config pull * Remove superfluous factory config * Name describe blocks after the thing they test * Remove implementation documentation Unfortunately the experience when linking to external documentation is quite poor. Instead of following the link and retrieving docs, you get a link that can be clicked to take you out of context to the docs. No link _does_ retrieve docs, but lacks indication in the implementation that documentation exists at all. On the balance, removing the link is the better experience. * Fix storybook	2 years ago
Matt Gibson	600cc080b8	Ps/fix biometric prompt error on close (#8353 ) * Fix error on close due to context differences in background Desktop background does not have active user information. Also, we want to delete _all_ prompt cancelled data, not just that for the active user. Storing this on global and manipulating observables to active achieves this without needing any user information in the background. * Remove potentially orphaned data * Throw nice error if prompt cancelled used without active user * Register migration * split prompt cancelled reset to user-specific and global	2 years ago
Matt Gibson	8ee1965832	Revert "Use global state for biometric prompt cancel storage (#8328 )" (#8351 ) This reverts commit `770f782a16`.	2 years ago
Matt Gibson	770f782a16	Use global state for biometric prompt cancel storage (#8328 ) * Fix error on close due to context differences in background Desktop background does not have active user information. Also, we want to delete _all_ prompt cancelled data, not just that for the active user. Storing this on global and manipulating observables to active achieves this without needing any user information in the background. * Remove potentially orphaned data * Throw nice error if prompt cancelled used without active user * Register migration	2 years ago
Justin Baur	1e921eb4f6	`getUserState$` Helper Improvements (#8267 ) * Block Sending Null to `getUser` * Update Comments & Tests Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Update Comment * Update Fake --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
Matt Gibson	e9a34ac5b8	Fix and test hasUserKey implementation (#8336 )	2 years ago
Justin Baur	8f8385d822	Reorder import (#8313 )	2 years ago
Justin Baur	3175b20ca5	Add `UserKeyDefinition` to union (#8298 )	2 years ago
Justin Baur	c9b5125f74	Include Storage Location In Fake Cache Key (#8203 )	2 years ago
Justin Baur	c3eba7f2c8	[PM-6404] Fully Integrate `clearOn` Events (#8134 ) * Add New KeyDefinitionOption * Add New Services * Add WebStorageServiceProvider Tests * Update Error Message * Add `UserKeyDefinition` * Fix Deserialization Helpers * Fix KeyDefinition * Add `UserKeyDefinition` * Fix Deserialization Helpers * Fix KeyDefinition * Move `ClearEvent` * Cleanup * Fix Imports * Integrate onClear Events * Remove Accidental Addition * Fix Test * Add VaultTimeoutService Tests * Only Register When Current State is Null * Address Feedback	2 years ago
✨ Audrey ✨	d87a8f9271	[PM-6523] generator service tuning (#8155 ) * rename policy$ to evaluator$ * replace `ActiveUserState` with `SingleUserState` * implement `SingleUserState<T>` on `SecretState`	2 years ago
Justin Baur	87c75e5ac8	[PM-6404] Initial Clear Events Code (#8029 ) * Add New KeyDefinitionOption * Add New Services * Add WebStorageServiceProvider Tests * Update Error Message * Add `UserKeyDefinition` * Fix Deserialization Helpers * Fix KeyDefinition * Add `UserKeyDefinition` * Fix Deserialization Helpers * Fix KeyDefinition * Move `ClearEvent` * Cleanup * Fix Imports * Remove `updateMock` * Call Super in Web Implementation * Use Better Type to Avoid Casting * Better Error Docs * Move StorageKey Creation to Function * Throw Aggregated Error for Failures	2 years ago
Justin Baur	632598d804	[PM-6404] Add `UserKeyDefinition` (#8052 ) * Add `UserKeyDefinition` * Fix Deserialization Helpers * Fix KeyDefinition * Move `ClearEvent` * Address PR Feedback * Feedback	2 years ago
Matt Gibson	9775e77079	[PM-5537] Migrate Biometric Prompts (#7771 ) * Fix nextMock arguments * Add state for biometric prompts * Use biometric state for prompts * Migrate biometric prompt data * wire up biometric state to logouts * Add migrator to migrate list * Remove usages of prompt automatically Explicitly list non-nulled state as intentional * `npm run prettier` 🤖 * Fix web lock component	2 years ago
Matt Gibson	56bffb04bb	Ps/pm 5533/migrate decrypted user key (#7970 ) * Move user key memory state to state providers Note: state service observable change is because these updates are no longer internal to the class, but reporter directly to account service through crypto service on update of a user key * remove decrypted user key state Note, we're going to move the encrypted cryptoSymmetric key (and associated master key encrypted user keys) as part of the master key service creation. Crypto service will no longer be responsible for the encrypted forms of user key. * Deprecate notices belong on abstraction * Allow for single-direction status updates This is necessary since we don't want to have to guarantee that the update to logged out occurs after the update to locked. * Remove deprecated subject It turns out the set for cryptoMasterKey was also unused 🎉	2 years ago
Matt Gibson	f0ae318f57	Link derived state fake to parent observable. (#7922 )	2 years ago
Matt Gibson	4c051f8d7f	ActiveUserState Update should return the userId of the impacted user. (#7869 ) This allows us to ensure that linked updates all go to the same user without risking active account changes in the middle of an operation.	2 years ago
Matt Gibson	2525a3707f	Prefer get methods to return single user states unless specified active (#7834 ) * Prefer get methods to return single user states unless specified active * Improve comment	2 years ago
Matt Gibson	166269520c	Allow common get and set operations from state providers (#7824 ) * Allow common get and set operations from state providers * Use finnish endings for observables	2 years ago
Matt Gibson	414ee2563f	[PM-5537] Biometric State Service (#7761 ) * Create state for biometric client key halves * Move enc string util to central utils * Provide biometric state through service * Use biometric state to track client key half * Create migration for client key half * Ensure client key half is removed on logout * Remove account data for client key half * Remove unnecessary key definition likes * Remove moved state from account * Fix null-conditional operator failure * Simplify migration * Remove lame test * Fix test type * Add migrator * Prefer userKey when legacy not needed * Fix tests	2 years ago
Will Martin	cb8849c355	Add eslint rule no-floating-promises (#7789 ) * add eslint rule no-floating-promises * add eslint-disable comment to offending lines	2 years ago
Matt Gibson	1da6733e71	JSON stringify memory items (#7731 ) * JSON stringify memory items stringification is required so they can be reliably sent through messaging * Simplify null handling	2 years ago
Justin Baur	45c0c09b71	[PM-5829] Add `disk-local` option for `web` (#7669 ) * Add `disk-local` option for web * Fix `web` DI * Update libs/common/src/platform/state/state-definition.ts Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Rely On Default Implementation for Most of Cache Key --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
✨ Audrey ✨	dbf836b573	[PM-5606] Add reactive generator service (#7446 )	2 years ago
Matt Gibson	211d7a2626	Ps/improve state provider fakers (#7494 ) * Expand state provider fakes - default null initial value for fake states - Easier mocking of key definitions through just the use of key names - allows for not exporting KeyDefinition as long as the key doesn't collide - mock of fake state provider to verify `get` calls - `nextMock` for use of the fn mock matchers on emissions of `state$` - `FakeAccountService` which allows for easy initialization and working with account switching * Small bug fix for cache key collision on key definitions unique by only storage location * Fix initial value for test	2 years ago
Matt Gibson	92f593df08	Remove unnecessary complex types (#7451 ) #7290 introduced these types, but during development we switched over to specifying dependencies in type parameters instead of an object. This change meant we no longer needed these `Type` or `ShapeToInstance` types, greatly simplifying the types related to derived state.	2 years ago
Justin Baur	5e11cb212d	Combined State (#7383 ) * Introduce Combined State * Cleanup Test * Update Fakes * Address PR Feedback * Update libs/common/src/platform/state/implementations/default-active-user-state.ts Co-authored-by: Matt Gibson <mgibson@bitwarden.com> * Prettier * Get rid of ReplaySubject reference --------- Co-authored-by: Matt Gibson <mgibson@bitwarden.com>	2 years ago
Matt Gibson	06affa9654	Rework derived state (#7290 ) * Remove derived state from state classes * Create provider for derived state Derived state is automatically stored to memory storage, but can be derived from any observable. * Fixup state provider method definitions * Test `DefaultDerivedState` * remove implementation notes * Write docs for derived state * fixup derived state provider types * Implement buffered delayUntil operator * Move state types to a common module * Move mock ports to centra location * Alias DerivedStateDependency type * Add dependencies to browser * Prefer internal rxjs operators for ref counting * WIP * Ensure complete on subjects * Foreground/background messaging for browser Defers work for browser to the background * Test foreground port behaviors * Inject foreground and background derived state services * remove unnecessary class field * Adhere to required options * Add dderived state to CLI * Prefer type definition in type parameters to options * Prefer instance method * Implements factory methods for common uses * Remove nothing test * Remove share subject reference Share manages connector subjects internally and will reuse them until refcount is 0 and the cleanup time has passed. Saving our own reference just risks memory leaks without real testability benefits. * Fix interaction state	2 years ago
Matt Gibson	69657a5ab5	Ps/allow state provider migrations from v 9 (#7263 ) * Provide missing spec helpers and fakers * We need to be able to migrate v9 stuff to state providers	2 years ago
Matt Gibson	fd85d13b18	Ps/avoid state emit until updated (#7198 ) * Add a small default time to limit timing failures * Handle subscription race conditions * Add Symbols to tracked emission types This is a bit of a cheat, but Symbols can't be cloned, so we need to nudge them to something we can handle. They are rare enough that anyone hitting this is likely to expect some special handling. * Ref count state listeners to minimize storage activity * Ensure statuses are updated * Remove notes * Use `test` when gramatically more proper * Copy race and subscription improvements to single user * Simplify observer initialization * Correct parameter names * Simplify update promises test we don't accidentally deadlock along the `getFromState` path * Fix save mock * WIP: most tests working * Avoid infinite update loop * Avoid potential deadlocks with awaiting assigned promises We were awaiting a promise assigned in a thenable. It turns out that assignment occurs before all thenables are concatenated, which can cause deadlocks. Likely, these were not showing up in tests because we're using very quick memory storage. * Fix update deadlock test * Add user update tests * Assert no double emit for multiple observers * Add use intent to method name * Ensure new subscriptions receive only newest data TODO: is this worth doing for active user state? * Remove unnecessary design requirement We don't need to await an executing update promise, we can support two emissions as long as the observable is guaranteed to get the new data. * Cleanup await spam * test cleanup option behavior * Remove unnecessary typecast * Throw over coerce for definition options * Fix state$ observable durability on cleanup	2 years ago
Matt Gibson	08b69fffe1	Revert "Ps/avoid state emit until updated (#7124 )" (#7187 ) This reverts commit `38c335d8fb`.	2 years ago

1 2 3

136 Commits (DEVOPS-1573_add-web-build-script)