Ps 575 pop out (#2705)

* Disable the ability to open infinite popouts in the browser

* fixing lint error

* Adding padding

* Updating code to use ngIf instead of show for the app-pop-out

apps/browser/src/popup/components/pop-out.component.ts

@@ -18,7 +18,10 @@ export class PopOutComponent implements OnInit {
 
   ngOnInit() {
     if (this.show) {
-      if (this.popupUtilsService.inSidebar(window) && this.platformUtilsService.isFirefox()) {
+      if (
+        (this.popupUtilsService.inSidebar(window) && this.platformUtilsService.isFirefox()) ||
+        this.popupUtilsService.inPopout(window)
+      ) {
         this.show = false;
       }
     }

apps/browser/src/popup/scss/base.scss

@@ -215,6 +215,7 @@ header {
 
   app-pop-out {
     display: flex;
+    padding-right: 0.5em;
   }
 
   .title {

apps/browser/src/popup/vault/current-tab.component.html

@@ -1,7 +1,7 @@
 <header>
   <h1 class="sr-only">{{ "currentTab" | i18n }}</h1>
   <div class="left">
-    <app-pop-out [show]="!inSidebar"></app-pop-out>
+    <app-pop-out *ngIf="!inSidebar"></app-pop-out>
     <button
       type="button"
       appBlurClick