Browse Source

PS-2450 EC-1073 Do not decode and normalize query (#4708)

Co-authored-by: Jake Fink <jfink@bitwarden.com>
pull/4732/head
Matt Gibson 3 years ago committed by GitHub
parent
commit
13746c1840
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      libs/common/src/services/api.service.ts

4
libs/common/src/services/api.service.ts

@ -1991,7 +1991,9 @@ export class ApiService implements ApiServiceAbstraction { @@ -1991,7 +1991,9 @@ export class ApiService implements ApiServiceAbstraction {
apiUrl = Utils.isNullOrWhitespace(apiUrl) ? this.environmentService.getApiUrl() : apiUrl;
// Prevent directory traversal from malicious paths
const requestUrl = apiUrl + Utils.normalizePath(path);
const pathParts = path.split("?");
const requestUrl =
apiUrl + Utils.normalizePath(pathParts[0]) + (pathParts.length > 1 ? `?${pathParts[1]}` : "");
const headers = new Headers({
"Device-Type": this.deviceType,

Loading…
Cancel
Save